You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by lu...@apache.org on 2015/11/02 16:21:35 UTC

[math] reintroduced modifiers needed for serialization.

Repository: commons-math
Updated Branches:
  refs/heads/master 026fce5c5 -> 8e0b98bf6


reintroduced modifiers needed for serialization.


Project: http://git-wip-us.apache.org/repos/asf/commons-math/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-math/commit/8e0b98bf
Tree: http://git-wip-us.apache.org/repos/asf/commons-math/tree/8e0b98bf
Diff: http://git-wip-us.apache.org/repos/asf/commons-math/diff/8e0b98bf

Branch: refs/heads/master
Commit: 8e0b98bf6bd30713d94b72c7c410addb26c3c472
Parents: 026fce5
Author: Luc Maisonobe <lu...@apache.org>
Authored: Mon Nov 2 16:20:54 2015 +0100
Committer: Luc Maisonobe <lu...@apache.org>
Committed: Mon Nov 2 16:20:54 2015 +0100

----------------------------------------------------------------------
 checkstyle.xml                                                  | 5 +++++
 .../math4/ode/nonstiff/ClassicalRungeKuttaStepInterpolator.java | 5 ++++-
 .../math4/ode/nonstiff/DormandPrince54StepInterpolator.java     | 5 ++++-
 .../math4/ode/nonstiff/DormandPrince853StepInterpolator.java    | 5 ++++-
 .../commons/math4/ode/nonstiff/EulerStepInterpolator.java       | 5 ++++-
 .../apache/commons/math4/ode/nonstiff/GillStepInterpolator.java | 5 ++++-
 .../math4/ode/nonstiff/GraggBulirschStoerStepInterpolator.java  | 5 ++++-
 .../math4/ode/nonstiff/HighamHall54StepInterpolator.java        | 5 ++++-
 .../commons/math4/ode/nonstiff/LutherStepInterpolator.java      | 5 ++++-
 .../commons/math4/ode/nonstiff/MidpointStepInterpolator.java    | 5 ++++-
 .../math4/ode/nonstiff/ThreeEighthesStepInterpolator.java       | 5 ++++-
 11 files changed, 45 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-math/blob/8e0b98bf/checkstyle.xml
----------------------------------------------------------------------
diff --git a/checkstyle.xml b/checkstyle.xml
index c35f8ba..af59d2b 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -190,6 +190,11 @@
     <property name="checkFormat"      value="DeclarationOrder"/>
   </module>
   <module name="SuppressionCommentFilter">
+    <property name="offCommentFormat" value="CHECKSTYLE\: stop RedundantModifier"/>
+    <property name="onCommentFormat"  value="CHECKSTYLE\: resume RedundantModifier"/>
+    <property name="checkFormat"      value="RedundantModifier"/>
+  </module>
+  <module name="SuppressionCommentFilter">
     <property name="offCommentFormat" value="CHECKSTYLE\: stop all"/>
     <property name="onCommentFormat" value="CHECKSTYLE\: resume all"/>
   </module>

http://git-wip-us.apache.org/repos/asf/commons-math/blob/8e0b98bf/src/main/java/org/apache/commons/math4/ode/nonstiff/ClassicalRungeKuttaStepInterpolator.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/ClassicalRungeKuttaStepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/ClassicalRungeKuttaStepInterpolator.java
index dd23975..d7704d7 100644
--- a/src/main/java/org/apache/commons/math4/ode/nonstiff/ClassicalRungeKuttaStepInterpolator.java
+++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/ClassicalRungeKuttaStepInterpolator.java
@@ -68,8 +68,11 @@ class ClassicalRungeKuttaStepInterpolator
      * interpolators by cloning an uninitialized model and latter initializing
      * the copy.
      */
-    ClassicalRungeKuttaStepInterpolator() {
+    // CHECKSTYLE: stop RedundantModifier
+    // the public modifier here is needed for serialization
+    public ClassicalRungeKuttaStepInterpolator() {
     }
+    // CHECKSTYLE: resume RedundantModifier
 
     /** Copy constructor.
      * @param interpolator interpolator to copy from. The copy is a deep

http://git-wip-us.apache.org/repos/asf/commons-math/blob/8e0b98bf/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince54StepInterpolator.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince54StepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince54StepInterpolator.java
index 815b9b8..a13d6d0 100644
--- a/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince54StepInterpolator.java
+++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince54StepInterpolator.java
@@ -97,7 +97,9 @@ class DormandPrince54StepInterpolator
    * prototyping design pattern to create the step interpolators by
    * cloning an uninitialized model and latter initializing the copy.
    */
-  DormandPrince54StepInterpolator() {
+  // CHECKSTYLE: stop RedundantModifier
+  // the public modifier here is needed for serialization
+  public DormandPrince54StepInterpolator() {
     super();
     v1 = null;
     v2 = null;
@@ -105,6 +107,7 @@ class DormandPrince54StepInterpolator
     v4 = null;
     vectorsInitialized = false;
   }
+  // CHECKSTYLE: resume RedundantModifier
 
   /** Copy constructor.
    * @param interpolator interpolator to copy from. The copy is a deep

http://git-wip-us.apache.org/repos/asf/commons-math/blob/8e0b98bf/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince853StepInterpolator.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince853StepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince853StepInterpolator.java
index 9a17fe1..5e6953c 100644
--- a/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince853StepInterpolator.java
+++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/DormandPrince853StepInterpolator.java
@@ -227,12 +227,15 @@ class DormandPrince853StepInterpolator
    * prototyping design pattern to create the step interpolators by
    * cloning an uninitialized model and latter initializing the copy.
    */
-  DormandPrince853StepInterpolator() {
+  // CHECKSTYLE: stop RedundantModifier
+  // the public modifier here is needed for serialization
+  public DormandPrince853StepInterpolator() {
     super();
     yDotKLast = null;
     v         = null;
     vectorsInitialized = false;
   }
+  // CHECKSTYLE: resume RedundantModifier
 
   /** Copy constructor.
    * @param interpolator interpolator to copy from. The copy is a deep

http://git-wip-us.apache.org/repos/asf/commons-math/blob/8e0b98bf/src/main/java/org/apache/commons/math4/ode/nonstiff/EulerStepInterpolator.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/EulerStepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/EulerStepInterpolator.java
index c31db8e..74691b5 100644
--- a/src/main/java/org/apache/commons/math4/ode/nonstiff/EulerStepInterpolator.java
+++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/EulerStepInterpolator.java
@@ -59,8 +59,11 @@ class EulerStepInterpolator
    * to create the step interpolators by cloning an uninitialized model
    * and later initializing the copy.
    */
-  EulerStepInterpolator() {
+  // CHECKSTYLE: stop RedundantModifier
+  // the public modifier here is needed for serialization
+  public EulerStepInterpolator() {
   }
+  // CHECKSTYLE: resume RedundantModifier
 
   /** Copy constructor.
    * @param interpolator interpolator to copy from. The copy is a deep

http://git-wip-us.apache.org/repos/asf/commons-math/blob/8e0b98bf/src/main/java/org/apache/commons/math4/ode/nonstiff/GillStepInterpolator.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/GillStepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/GillStepInterpolator.java
index 3a7c034..435c5b2 100644
--- a/src/main/java/org/apache/commons/math4/ode/nonstiff/GillStepInterpolator.java
+++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/GillStepInterpolator.java
@@ -75,8 +75,11 @@ class GillStepInterpolator
    * to create the step interpolators by cloning an uninitialized model
    * and later initializing the copy.
    */
-  GillStepInterpolator() {
+  // CHECKSTYLE: stop RedundantModifier
+  // the public modifier here is needed for serialization
+  public GillStepInterpolator() {
   }
+  // CHECKSTYLE: resume RedundantModifier
 
   /** Copy constructor.
    * @param interpolator interpolator to copy from. The copy is a deep

http://git-wip-us.apache.org/repos/asf/commons-math/blob/8e0b98bf/src/main/java/org/apache/commons/math4/ode/nonstiff/GraggBulirschStoerStepInterpolator.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/GraggBulirschStoerStepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/GraggBulirschStoerStepInterpolator.java
index 6afdf37..a991221 100644
--- a/src/main/java/org/apache/commons/math4/ode/nonstiff/GraggBulirschStoerStepInterpolator.java
+++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/GraggBulirschStoerStepInterpolator.java
@@ -107,13 +107,16 @@ class GraggBulirschStoerStepInterpolator
    * This constructor should not be used directly, it is only intended
    * for the serialization process.
    */
-  GraggBulirschStoerStepInterpolator() {
+    // CHECKSTYLE: stop RedundantModifier
+    // the public modifier here is needed for serialization
+  public GraggBulirschStoerStepInterpolator() {
     y0Dot    = null;
     y1       = null;
     y1Dot    = null;
     yMidDots = null;
     resetTables(-1);
   }
+  // CHECKSTYLE: resume RedundantModifier
 
   /** Simple constructor.
    * @param y reference to the integrator array holding the current state

http://git-wip-us.apache.org/repos/asf/commons-math/blob/8e0b98bf/src/main/java/org/apache/commons/math4/ode/nonstiff/HighamHall54StepInterpolator.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/HighamHall54StepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/HighamHall54StepInterpolator.java
index 01a00d0..4e40f81 100644
--- a/src/main/java/org/apache/commons/math4/ode/nonstiff/HighamHall54StepInterpolator.java
+++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/HighamHall54StepInterpolator.java
@@ -45,9 +45,12 @@ class HighamHall54StepInterpolator
    * to create the step interpolators by cloning an uninitialized model
    * and later initializing the copy.
    */
-  HighamHall54StepInterpolator() {
+  // CHECKSTYLE: stop RedundantModifier
+  // the public modifier here is needed for serialization
+  public HighamHall54StepInterpolator() {
     super();
   }
+  // CHECKSTYLE: resume RedundantModifier
 
   /** Copy constructor.
    * @param interpolator interpolator to copy from. The copy is a deep

http://git-wip-us.apache.org/repos/asf/commons-math/blob/8e0b98bf/src/main/java/org/apache/commons/math4/ode/nonstiff/LutherStepInterpolator.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/LutherStepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/LutherStepInterpolator.java
index e4d212b..e4eedd2 100644
--- a/src/main/java/org/apache/commons/math4/ode/nonstiff/LutherStepInterpolator.java
+++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/LutherStepInterpolator.java
@@ -51,8 +51,11 @@ class LutherStepInterpolator extends RungeKuttaStepInterpolator {
      * to create the step interpolators by cloning an uninitialized model
      * and later initializing the copy.
      */
-    LutherStepInterpolator() {
+    // CHECKSTYLE: stop RedundantModifier
+    // the public modifier here is needed for serialization
+    public LutherStepInterpolator() {
     }
+    // CHECKSTYLE: resume RedundantModifier
 
     /** Copy constructor.
      * @param interpolator interpolator to copy from. The copy is a deep

http://git-wip-us.apache.org/repos/asf/commons-math/blob/8e0b98bf/src/main/java/org/apache/commons/math4/ode/nonstiff/MidpointStepInterpolator.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/MidpointStepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/MidpointStepInterpolator.java
index 38393ca..45014bb 100644
--- a/src/main/java/org/apache/commons/math4/ode/nonstiff/MidpointStepInterpolator.java
+++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/MidpointStepInterpolator.java
@@ -61,8 +61,11 @@ class MidpointStepInterpolator
    * to create the step interpolators by cloning an uninitialized model
    * and later initializing the copy.
    */
-  MidpointStepInterpolator() {
+  // CHECKSTYLE: stop RedundantModifier
+  // the public modifier here is needed for serialization
+  public MidpointStepInterpolator() {
   }
+  // CHECKSTYLE: resume RedundantModifier
 
   /** Copy constructor.
    * @param interpolator interpolator to copy from. The copy is a deep

http://git-wip-us.apache.org/repos/asf/commons-math/blob/8e0b98bf/src/main/java/org/apache/commons/math4/ode/nonstiff/ThreeEighthesStepInterpolator.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/math4/ode/nonstiff/ThreeEighthesStepInterpolator.java b/src/main/java/org/apache/commons/math4/ode/nonstiff/ThreeEighthesStepInterpolator.java
index 2dba16e..c5a20e0 100644
--- a/src/main/java/org/apache/commons/math4/ode/nonstiff/ThreeEighthesStepInterpolator.java
+++ b/src/main/java/org/apache/commons/math4/ode/nonstiff/ThreeEighthesStepInterpolator.java
@@ -71,8 +71,11 @@ class ThreeEighthesStepInterpolator
    * to create the step interpolators by cloning an uninitialized model
    * and later initializing the copy.
    */
-  ThreeEighthesStepInterpolator() {
+  // CHECKSTYLE: stop RedundantModifier
+  // the public modifier here is needed for serialization
+  public ThreeEighthesStepInterpolator() {
   }
+  // CHECKSTYLE: resume RedundantModifier
 
   /** Copy constructor.
    * @param interpolator interpolator to copy from. The copy is a deep