[GitHub] [doris] jacktengg commented on a diff in pull request #10745: [improvement] remove _free_blocks of VOlapScannode to simplify logic

[GitBox <gi...@apache.org>]

jacktengg commented on code in PR #10745:
URL: https://github.com/apache/doris/pull/10745#discussion_r917918822


##########
be/src/vec/exec/volap_scan_node.cpp:
##########
@@ -42,19 +42,16 @@ VOlapScanNode::VOlapScanNode(ObjectPool* pool, const TPlanNode& tnode, const Des
           _tuple_desc(nullptr),
           _tuple_idx(0),
           _eos(false),
-          _max_materialized_row_batches(config::doris_scanner_queue_size),
           _start(false),
           _scanner_done(false),
           _transfer_done(false),
           _status(Status::OK()),
           _resource_info(nullptr),
-          _buffered_bytes(0),
           _eval_conjuncts_fn(nullptr),
           _runtime_filter_descs(tnode.runtime_filters),
           _max_materialized_blocks(config::doris_scanner_queue_size),
           _output_slot_ids(tnode.output_slot_ids) {
     _materialized_blocks.reserve(_max_materialized_blocks);

Review Comment:
   fixed



##########
be/src/vec/exec/volap_scan_node.cpp:
##########
@@ -518,32 +502,24 @@ void VOlapScanNode::scanner_thread(VOlapScanner* scanner) {
             break;
         }
 
-        auto block = _alloc_block(get_free_block);
-        status = scanner->get_block(_runtime_state, block, &eos);
+        auto block = std::make_unique<Block>(Block(_tuple_desc->slots(), _block_size));

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org