You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "Jon Kessler (JIRA)" <ji...@apache.org> on 2018/01/24 12:01:00 UTC
[jira] [Updated] (NIFI-4813) ControllerServiceLookup: Add method
signature
[ https://issues.apache.org/jira/browse/NIFI-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Kessler updated NIFI-4813:
------------------------------
Description:
The ControllerServiceLookup interface contains the following method signature:
{code:java}
Set<String> getControllerServiceIdentifiers(Class<? extends ControllerService> serviceType) throws IllegalArgumentException;{code}
Its implementation in the StandardControllerServiceProvider has more or less been deprecated as it now just throws an UnsupportedOperationException. It has been replaced in that class by the following method but that signature has not yet been added to the interface:
{code:java}
public Set<String> getControllerServiceIdentifiers(final Class<? extends ControllerService> serviceType, final String groupId){code}
This causes a problem for processors that used the former method via getControllerServiceLookup() as that method only returns the interface. Therefore it should be added to the interface.
[1][https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=blob;f=nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceProvider.java;hb=HEAD#l662]
[2][https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=blob;f=nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceProvider.java;hb=HEAD#l798]
[3][https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=blob;f=nifi-api/src/main/java/org/apache/nifi/controller/ControllerServiceLookup.java;hb=HEAD#l64]
was:
The ControllerServiceLookup interface contains the following method signature:
{code:java}
Set<String> getControllerServiceIdentifiers(Class<? extends ControllerService> serviceType) throws IllegalArgumentException;{code}
Its implementation in the StandardControllerServiceProvider has more or less been deprecated as it now just throws an UnsupportedOperationException. It has been replaced in that class by the following method but that signature has not yet been added to the interface:
{code:java}
public Set<String> getControllerServiceIdentifiers(final Class<? extends ControllerService> serviceType, final String groupId){code}
This causes a problem for processors that used the former method via getControllerServiceLookup() as that class only returns the interface. Therefore it should be added to the interface.
[1][https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=blob;f=nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceProvider.java;hb=HEAD#l662]
[2][https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=blob;f=nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceProvider.java;hb=HEAD#l798]
[3][https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=blob;f=nifi-api/src/main/java/org/apache/nifi/controller/ControllerServiceLookup.java;hb=HEAD#l64]
> ControllerServiceLookup: Add method signature
> ---------------------------------------------
>
> Key: NIFI-4813
> URL: https://issues.apache.org/jira/browse/NIFI-4813
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 1.4.0
> Reporter: Jon Kessler
> Priority: Minor
>
> The ControllerServiceLookup interface contains the following method signature:
> {code:java}
> Set<String> getControllerServiceIdentifiers(Class<? extends ControllerService> serviceType) throws IllegalArgumentException;{code}
> Its implementation in the StandardControllerServiceProvider has more or less been deprecated as it now just throws an UnsupportedOperationException. It has been replaced in that class by the following method but that signature has not yet been added to the interface:
> {code:java}
> public Set<String> getControllerServiceIdentifiers(final Class<? extends ControllerService> serviceType, final String groupId){code}
> This causes a problem for processors that used the former method via getControllerServiceLookup() as that method only returns the interface. Therefore it should be added to the interface.
> [1][https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=blob;f=nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceProvider.java;hb=HEAD#l662]
> [2][https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=blob;f=nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceProvider.java;hb=HEAD#l798]
> [3][https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=blob;f=nifi-api/src/main/java/org/apache/nifi/controller/ControllerServiceLookup.java;hb=HEAD#l64]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)