You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/08/18 13:36:29 UTC

[GitHub] [zeppelin] milooy opened a new pull request #3880: [ZEPPELIN-5002] Update JDK version in documentation

milooy opened a new pull request #3880:
URL: https://github.com/apache/zeppelin/pull/3880


   ### What is this PR for?
   Java 8 is required to building from source.
   
   In 'install' page, it is 1.8 (151+)
   http://zeppelin.apache.org/docs/0.9.0-preview2/quickstart/install.html
   
   
   but in 'build' page, it's 1.7
   http://zeppelin.apache.org/docs/0.9.0-preview2/setup/basics/how_to_build.html#how-to-build-zeppelin-from-source
   
   
   ### What type of PR is it?
   Bug Fix
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/ZEPPELIN-5002
   
   ### How should this be tested?
   * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
   * Strongly recommended: add automated unit tests for any new or changed behavior
   * Outline any manual steps to test the PR here.
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update?
   * Is there breaking changes for older versions?
   * Does this needs documentation?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] asfgit closed pull request #3880: [ZEPPELIN-5002] Update JDK version in documentation

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3880:
URL: https://github.com/apache/zeppelin/pull/3880


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] Reamer commented on a change in pull request #3880: [ZEPPELIN-5002] Update JDK version in documentation

Posted by GitBox <gi...@apache.org>.
Reamer commented on a change in pull request #3880:
URL: https://github.com/apache/zeppelin/pull/3880#discussion_r472267915



##########
File path: docs/setup/basics/how_to_build.md
##########
@@ -41,8 +41,8 @@ If you want to build from source, you must first install the following dependenc
     <td>3.1.x or higher</td>
   </tr>
   <tr>
-    <td>JDK</td>
-    <td>1.7</td>
+    <td>OpenJDK or Oracle JDK	</td>

Review comment:
       Can you please remove the tab character after 'JDK'?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [zeppelin] Reamer commented on a change in pull request #3880: [ZEPPELIN-5002] Update JDK version in documentation

Posted by GitBox <gi...@apache.org>.
Reamer commented on a change in pull request #3880:
URL: https://github.com/apache/zeppelin/pull/3880#discussion_r472267915



##########
File path: docs/setup/basics/how_to_build.md
##########
@@ -41,8 +41,8 @@ If you want to build from source, you must first install the following dependenc
     <td>3.1.x or higher</td>
   </tr>
   <tr>
-    <td>JDK</td>
-    <td>1.7</td>
+    <td>OpenJDK or Oracle JDK	</td>

Review comment:
       Can you please remove the tab character after `JDK`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org