You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/23 11:21:43 UTC
[GitHub] [dolphinscheduler] retime123 opened a new pull request, #10206: [Bug]Added disk available capacity monitoring
retime123 opened a new pull request, #10206:
URL: https://github.com/apache/dolphinscheduler/pull/10206
Modify the bug
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
Through version 3.0.0, E2E test results, found a bug, so fix it
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #10206: [Bug]Added disk available capacity monitoring
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on code in PR #10206:
URL: https://github.com/apache/dolphinscheduler/pull/10206#discussion_r882596130
##########
script/dolphinscheduler-daemon.sh:
##########
@@ -33,8 +33,9 @@ echo "Begin $startStop $command......"
BIN_DIR=`dirname $0`
BIN_DIR=`cd "$BIN_DIR"; pwd`
-DOLPHINSCHEDULER_HOME=`cd "$BIN_DIR/.."; pwd`
+export DOLPHINSCHEDULER_HOME=`cd "$BIN_DIR/.."; pwd`
+chmod -R 700 ${DOLPHINSCHEDULER_HOME}/config
Review Comment:
Hi, why is this change needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10206: [Bug]Added disk available capacity monitoring
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10206:
URL: https://github.com/apache/dolphinscheduler/pull/10206#discussion_r881151657
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HeartBeat.java:
##########
@@ -245,18 +245,18 @@ public static HeartBeat decodeHeartBeat(String heartBeatInfo) {
HeartBeat heartBeat = new HeartBeat();
heartBeat.cpuUsage = Double.parseDouble(parts[0]);
heartBeat.memoryUsage = Double.parseDouble(parts[1]);
- heartBeat.diskAvailable = Double.parseDouble(parts[2]);
- heartBeat.loadAverage = Double.parseDouble(parts[3]);
- heartBeat.availablePhysicalMemorySize = Double.parseDouble(parts[4]);
- heartBeat.maxCpuloadAvg = Double.parseDouble(parts[5]);
- heartBeat.reservedMemory = Double.parseDouble(parts[6]);
- heartBeat.startupTime = Long.parseLong(parts[7]);
- heartBeat.reportTime = Long.parseLong(parts[8]);
- heartBeat.serverStatus = Integer.parseInt(parts[9]);
- heartBeat.processId = Integer.parseInt(parts[10]);
- heartBeat.workerHostWeight = Integer.parseInt(parts[11]);
- heartBeat.workerExecThreadCount = Integer.parseInt(parts[12]);
- heartBeat.workerWaitingTaskCount = Integer.parseInt(parts[13]);
+ heartBeat.loadAverage = Double.parseDouble(parts[2]);
+ heartBeat.availablePhysicalMemorySize = Double.parseDouble(parts[3]);
+ heartBeat.maxCpuloadAvg = Double.parseDouble(parts[4]);
+ heartBeat.reservedMemory = Double.parseDouble(parts[5]);
+ heartBeat.startupTime = Long.parseLong(parts[6]);
+ heartBeat.reportTime = Long.parseLong(parts[7]);
+ heartBeat.serverStatus = Integer.parseInt(parts[8]);
+ heartBeat.processId = Integer.parseInt(parts[9]);
+ heartBeat.workerHostWeight = Integer.parseInt(parts[10]);
+ heartBeat.workerExecThreadCount = Integer.parseInt(parts[11]);
+ heartBeat.workerWaitingTaskCount = Integer.parseInt(parts[12]);
+ heartBeat.diskAvailable = Double.parseDouble(parts[13]);
Review Comment:
do you mean you want to add disk caption check but when you submit PR and find it already in `dev` branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10206: [Bug]Added disk available capacity monitoring
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10206:
URL: https://github.com/apache/dolphinscheduler/pull/10206#discussion_r881192765
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HeartBeat.java:
##########
@@ -245,18 +245,18 @@ public static HeartBeat decodeHeartBeat(String heartBeatInfo) {
HeartBeat heartBeat = new HeartBeat();
heartBeat.cpuUsage = Double.parseDouble(parts[0]);
heartBeat.memoryUsage = Double.parseDouble(parts[1]);
- heartBeat.diskAvailable = Double.parseDouble(parts[2]);
- heartBeat.loadAverage = Double.parseDouble(parts[3]);
- heartBeat.availablePhysicalMemorySize = Double.parseDouble(parts[4]);
- heartBeat.maxCpuloadAvg = Double.parseDouble(parts[5]);
- heartBeat.reservedMemory = Double.parseDouble(parts[6]);
- heartBeat.startupTime = Long.parseLong(parts[7]);
- heartBeat.reportTime = Long.parseLong(parts[8]);
- heartBeat.serverStatus = Integer.parseInt(parts[9]);
- heartBeat.processId = Integer.parseInt(parts[10]);
- heartBeat.workerHostWeight = Integer.parseInt(parts[11]);
- heartBeat.workerExecThreadCount = Integer.parseInt(parts[12]);
- heartBeat.workerWaitingTaskCount = Integer.parseInt(parts[13]);
+ heartBeat.loadAverage = Double.parseDouble(parts[2]);
+ heartBeat.availablePhysicalMemorySize = Double.parseDouble(parts[3]);
+ heartBeat.maxCpuloadAvg = Double.parseDouble(parts[4]);
+ heartBeat.reservedMemory = Double.parseDouble(parts[5]);
+ heartBeat.startupTime = Long.parseLong(parts[6]);
+ heartBeat.reportTime = Long.parseLong(parts[7]);
+ heartBeat.serverStatus = Integer.parseInt(parts[8]);
+ heartBeat.processId = Integer.parseInt(parts[9]);
+ heartBeat.workerHostWeight = Integer.parseInt(parts[10]);
+ heartBeat.workerExecThreadCount = Integer.parseInt(parts[11]);
+ heartBeat.workerWaitingTaskCount = Integer.parseInt(parts[12]);
+ heartBeat.diskAvailable = Double.parseDouble(parts[13]);
Review Comment:
In this case you should change your target branch to `dev`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] retime123 commented on a diff in pull request #10206: [Bug]Added disk available capacity monitoring
Posted by GitBox <gi...@apache.org>.
retime123 commented on code in PR #10206:
URL: https://github.com/apache/dolphinscheduler/pull/10206#discussion_r882598752
##########
script/dolphinscheduler-daemon.sh:
##########
@@ -33,8 +33,9 @@ echo "Begin $startStop $command......"
BIN_DIR=`dirname $0`
BIN_DIR=`cd "$BIN_DIR"; pwd`
-DOLPHINSCHEDULER_HOME=`cd "$BIN_DIR/.."; pwd`
+export DOLPHINSCHEDULER_HOME=`cd "$BIN_DIR/.."; pwd`
+chmod -R 700 ${DOLPHINSCHEDULER_HOME}/config
Review Comment:
Well, I developed it on the `2.0.6-prepare` branch, this comparison is on the 2.0.5 branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10206: [Bug]Added disk available capacity monitoring
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10206:
URL: https://github.com/apache/dolphinscheduler/pull/10206#issuecomment-1134562080
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10206)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=BUG) [52 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=VULNERABILITY) [6 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=SECURITY_HOTSPOT) [11 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=CODE_SMELL) [1281 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10206&metric=new_coverage&view=list) [18.8% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10206&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10206&metric=new_duplicated_lines_density&view=list) [4.8% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10206&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] retime123 commented on a diff in pull request #10206: [Bug]Added disk available capacity monitoring
Posted by GitBox <gi...@apache.org>.
retime123 commented on code in PR #10206:
URL: https://github.com/apache/dolphinscheduler/pull/10206#discussion_r880361647
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HeartBeat.java:
##########
@@ -245,18 +245,18 @@ public static HeartBeat decodeHeartBeat(String heartBeatInfo) {
HeartBeat heartBeat = new HeartBeat();
heartBeat.cpuUsage = Double.parseDouble(parts[0]);
heartBeat.memoryUsage = Double.parseDouble(parts[1]);
- heartBeat.diskAvailable = Double.parseDouble(parts[2]);
- heartBeat.loadAverage = Double.parseDouble(parts[3]);
- heartBeat.availablePhysicalMemorySize = Double.parseDouble(parts[4]);
- heartBeat.maxCpuloadAvg = Double.parseDouble(parts[5]);
- heartBeat.reservedMemory = Double.parseDouble(parts[6]);
- heartBeat.startupTime = Long.parseLong(parts[7]);
- heartBeat.reportTime = Long.parseLong(parts[8]);
- heartBeat.serverStatus = Integer.parseInt(parts[9]);
- heartBeat.processId = Integer.parseInt(parts[10]);
- heartBeat.workerHostWeight = Integer.parseInt(parts[11]);
- heartBeat.workerExecThreadCount = Integer.parseInt(parts[12]);
- heartBeat.workerWaitingTaskCount = Integer.parseInt(parts[13]);
+ heartBeat.loadAverage = Double.parseDouble(parts[2]);
+ heartBeat.availablePhysicalMemorySize = Double.parseDouble(parts[3]);
+ heartBeat.maxCpuloadAvg = Double.parseDouble(parts[4]);
+ heartBeat.reservedMemory = Double.parseDouble(parts[5]);
+ heartBeat.startupTime = Long.parseLong(parts[6]);
+ heartBeat.reportTime = Long.parseLong(parts[7]);
+ heartBeat.serverStatus = Integer.parseInt(parts[8]);
+ heartBeat.processId = Integer.parseInt(parts[9]);
+ heartBeat.workerHostWeight = Integer.parseInt(parts[10]);
+ heartBeat.workerExecThreadCount = Integer.parseInt(parts[11]);
+ heartBeat.workerWaitingTaskCount = Integer.parseInt(parts[12]);
+ heartBeat.diskAvailable = Double.parseDouble(parts[13]);
Review Comment:
Yes. I didn't think there was a quote anywhere else.
Switch to version 2.0.6 if you can
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10206: [Bug]Added disk available capacity monitoring
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10206:
URL: https://github.com/apache/dolphinscheduler/pull/10206#discussion_r880304342
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HeartBeat.java:
##########
@@ -245,18 +245,18 @@ public static HeartBeat decodeHeartBeat(String heartBeatInfo) {
HeartBeat heartBeat = new HeartBeat();
heartBeat.cpuUsage = Double.parseDouble(parts[0]);
heartBeat.memoryUsage = Double.parseDouble(parts[1]);
- heartBeat.diskAvailable = Double.parseDouble(parts[2]);
- heartBeat.loadAverage = Double.parseDouble(parts[3]);
- heartBeat.availablePhysicalMemorySize = Double.parseDouble(parts[4]);
- heartBeat.maxCpuloadAvg = Double.parseDouble(parts[5]);
- heartBeat.reservedMemory = Double.parseDouble(parts[6]);
- heartBeat.startupTime = Long.parseLong(parts[7]);
- heartBeat.reportTime = Long.parseLong(parts[8]);
- heartBeat.serverStatus = Integer.parseInt(parts[9]);
- heartBeat.processId = Integer.parseInt(parts[10]);
- heartBeat.workerHostWeight = Integer.parseInt(parts[11]);
- heartBeat.workerExecThreadCount = Integer.parseInt(parts[12]);
- heartBeat.workerWaitingTaskCount = Integer.parseInt(parts[13]);
+ heartBeat.loadAverage = Double.parseDouble(parts[2]);
+ heartBeat.availablePhysicalMemorySize = Double.parseDouble(parts[3]);
+ heartBeat.maxCpuloadAvg = Double.parseDouble(parts[4]);
+ heartBeat.reservedMemory = Double.parseDouble(parts[5]);
+ heartBeat.startupTime = Long.parseLong(parts[6]);
+ heartBeat.reportTime = Long.parseLong(parts[7]);
+ heartBeat.serverStatus = Integer.parseInt(parts[8]);
+ heartBeat.processId = Integer.parseInt(parts[9]);
+ heartBeat.workerHostWeight = Integer.parseInt(parts[10]);
+ heartBeat.workerExecThreadCount = Integer.parseInt(parts[11]);
+ heartBeat.workerWaitingTaskCount = Integer.parseInt(parts[12]);
+ heartBeat.diskAvailable = Double.parseDouble(parts[13]);
Review Comment:
You just change the position and do nothing on it? Am I right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] retime123 commented on a diff in pull request #10206: [Bug]Added disk available capacity monitoring
Posted by GitBox <gi...@apache.org>.
retime123 commented on code in PR #10206:
URL: https://github.com/apache/dolphinscheduler/pull/10206#discussion_r881178705
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HeartBeat.java:
##########
@@ -245,18 +245,18 @@ public static HeartBeat decodeHeartBeat(String heartBeatInfo) {
HeartBeat heartBeat = new HeartBeat();
heartBeat.cpuUsage = Double.parseDouble(parts[0]);
heartBeat.memoryUsage = Double.parseDouble(parts[1]);
- heartBeat.diskAvailable = Double.parseDouble(parts[2]);
- heartBeat.loadAverage = Double.parseDouble(parts[3]);
- heartBeat.availablePhysicalMemorySize = Double.parseDouble(parts[4]);
- heartBeat.maxCpuloadAvg = Double.parseDouble(parts[5]);
- heartBeat.reservedMemory = Double.parseDouble(parts[6]);
- heartBeat.startupTime = Long.parseLong(parts[7]);
- heartBeat.reportTime = Long.parseLong(parts[8]);
- heartBeat.serverStatus = Integer.parseInt(parts[9]);
- heartBeat.processId = Integer.parseInt(parts[10]);
- heartBeat.workerHostWeight = Integer.parseInt(parts[11]);
- heartBeat.workerExecThreadCount = Integer.parseInt(parts[12]);
- heartBeat.workerWaitingTaskCount = Integer.parseInt(parts[13]);
+ heartBeat.loadAverage = Double.parseDouble(parts[2]);
+ heartBeat.availablePhysicalMemorySize = Double.parseDouble(parts[3]);
+ heartBeat.maxCpuloadAvg = Double.parseDouble(parts[4]);
+ heartBeat.reservedMemory = Double.parseDouble(parts[5]);
+ heartBeat.startupTime = Long.parseLong(parts[6]);
+ heartBeat.reportTime = Long.parseLong(parts[7]);
+ heartBeat.serverStatus = Integer.parseInt(parts[8]);
+ heartBeat.processId = Integer.parseInt(parts[9]);
+ heartBeat.workerHostWeight = Integer.parseInt(parts[10]);
+ heartBeat.workerExecThreadCount = Integer.parseInt(parts[11]);
+ heartBeat.workerWaitingTaskCount = Integer.parseInt(parts[12]);
+ heartBeat.diskAvailable = Double.parseDouble(parts[13]);
Review Comment:
What I added on the 2.0.6 branch was merged, and then I submitted it to version 3.0 and found a bug! Now I want to fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10206: [Bug]Added disk available capacity monitoring
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10206:
URL: https://github.com/apache/dolphinscheduler/pull/10206#issuecomment-1135833446
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10206)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=BUG) [52 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=VULNERABILITY) [6 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=SECURITY_HOTSPOT) [11 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=CODE_SMELL) [1279 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10206&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10206&metric=new_coverage&view=list) [18.7% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10206&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10206&metric=new_duplicated_lines_density&view=list) [4.8% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10206&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10206: [Bug]Added disk available capacity monitoring
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10206:
URL: https://github.com/apache/dolphinscheduler/pull/10206#issuecomment-1136695950
It is a feature instead of bug, remove the milestone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] retime123 commented on a diff in pull request #10206: [Bug]Added disk available capacity monitoring
Posted by GitBox <gi...@apache.org>.
retime123 commented on code in PR #10206:
URL: https://github.com/apache/dolphinscheduler/pull/10206#discussion_r881194902
##########
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HeartBeat.java:
##########
@@ -245,18 +245,18 @@ public static HeartBeat decodeHeartBeat(String heartBeatInfo) {
HeartBeat heartBeat = new HeartBeat();
heartBeat.cpuUsage = Double.parseDouble(parts[0]);
heartBeat.memoryUsage = Double.parseDouble(parts[1]);
- heartBeat.diskAvailable = Double.parseDouble(parts[2]);
- heartBeat.loadAverage = Double.parseDouble(parts[3]);
- heartBeat.availablePhysicalMemorySize = Double.parseDouble(parts[4]);
- heartBeat.maxCpuloadAvg = Double.parseDouble(parts[5]);
- heartBeat.reservedMemory = Double.parseDouble(parts[6]);
- heartBeat.startupTime = Long.parseLong(parts[7]);
- heartBeat.reportTime = Long.parseLong(parts[8]);
- heartBeat.serverStatus = Integer.parseInt(parts[9]);
- heartBeat.processId = Integer.parseInt(parts[10]);
- heartBeat.workerHostWeight = Integer.parseInt(parts[11]);
- heartBeat.workerExecThreadCount = Integer.parseInt(parts[12]);
- heartBeat.workerWaitingTaskCount = Integer.parseInt(parts[13]);
+ heartBeat.loadAverage = Double.parseDouble(parts[2]);
+ heartBeat.availablePhysicalMemorySize = Double.parseDouble(parts[3]);
+ heartBeat.maxCpuloadAvg = Double.parseDouble(parts[4]);
+ heartBeat.reservedMemory = Double.parseDouble(parts[5]);
+ heartBeat.startupTime = Long.parseLong(parts[6]);
+ heartBeat.reportTime = Long.parseLong(parts[7]);
+ heartBeat.serverStatus = Integer.parseInt(parts[8]);
+ heartBeat.processId = Integer.parseInt(parts[9]);
+ heartBeat.workerHostWeight = Integer.parseInt(parts[10]);
+ heartBeat.workerExecThreadCount = Integer.parseInt(parts[11]);
+ heartBeat.workerWaitingTaskCount = Integer.parseInt(parts[12]);
+ heartBeat.diskAvailable = Double.parseDouble(parts[13]);
Review Comment:
I wrote this function on branch 2.0.6, and it also fits this branch! I have also committed the ** edge of dev, but it is not merged yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet commented on pull request #10206: [Bug]Added disk available capacity monitoring
Posted by GitBox <gi...@apache.org>.
songjianet commented on PR #10206:
URL: https://github.com/apache/dolphinscheduler/pull/10206#issuecomment-1135464152
Please associate the corresponding issue. @retime123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #10206: [Bug]Added disk available capacity monitoring
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #10206:
URL: https://github.com/apache/dolphinscheduler/pull/10206#issuecomment-1135826975
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10206?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`2.0.6-prepare@930c7d4`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 2.0.6-prepare #10206 +/- ##
================================================
Coverage ? 21.08%
Complexity ? 1595
================================================
Files ? 536
Lines ? 22541
Branches ? 2674
================================================
Hits ? 4752
Misses ? 17303
Partials ? 486
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10206?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10206?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [930c7d4...b55a2d1](https://codecov.io/gh/apache/dolphinscheduler/pull/10206?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org