[GitHub] [incubator-devlake] mintsweet commented on a diff in pull request #4792: feat: add tapd config ui bp

["mintsweet (via GitHub)" <gi...@apache.org>]

mintsweet commented on code in PR #4792:
URL: https://github.com/apache/incubator-devlake/pull/4792#discussion_r1150031508


##########
config-ui/src/plugins/components/transformation-form/index.tsx:
##########
@@ -109,10 +112,19 @@ export const TransformationForm = ({ plugin, connectionId, id, onCancel }: Props
         {plugin === 'bitbucket' && (
           <BitbucketTransformation transformation={transformation} setTransformation={setTransformation} />
         )}
+
+        {plugin === 'tapd' && (
+          <TapdTransformation
+            connectionId={connectionId}
+            scopeId={scopeId}
+            transformation={transformation}
+            setTransformation={setTransformation}
+          />
+        )}
       </Card>
 
       <S.Btns>
-        <Button outlined intent={Intent.PRIMARY} text="Cancel" onClick={onCancel} />
+        <Button outlined intent={Intent.PRIMARY} text="Cancel" onClick={() => onCancel?.(undefined)} />

Review Comment:
   What is this change?



##########
config-ui/src/plugins/components/data-scope-miller-columns/index.tsx:
##########
@@ -32,6 +32,7 @@ interface Props extends Pick<MillerColumnsSelectProps<ExtraType>, 'columnCount'>
   plugin: string;
   connectionId: ID;
   selectedItems?: any[];
+  firstPageToken?: string;

Review Comment:
   why use `firstPageToken`?
   



##########
config-ui/src/hooks/use-refresh-data.ts:
##########
@@ -61,6 +61,7 @@ export const useRefreshData = <T>(request: (signal: AbortSignal) => Promise<T>,
           return;
         }
         ref.current.state = 'error';
+        console.error(err);

Review Comment:
   don't use the console, you can export errors to the outer layer.



##########
config-ui/src/plugins/components/transformation-select/index.tsx:
##########
@@ -65,7 +69,11 @@ export const TransformationSelect = ({ plugin, connectionId, onCancel, onSubmit
 
   const handleReset = () => {
     setStep(1);
-    setUpdatedId(undefined);
+    setUpdatedId('');

Review Comment:
   The empty string has no undefined to express its meaning.



##########
config-ui/src/plugins/components/transformation/index.tsx:
##########
@@ -51,8 +51,11 @@ export const Transformation = ({
 }: Props) => {
   const [selected, setSelected] = useState<Record<string, ID[]>>({});
   const [connection, setConnection] = useState<MixConnection>();
+  const [startStepOption, setStartStepOption] = useState<{ type: 'add' | 'edit'; id?: ID }>();
 
-  const handleCancel = () => setConnection(undefined);
+  const handleCancel = () => {

Review Comment:
   Is this formatted by your idea?😂



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org