You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "adutra (via GitHub)" <gi...@apache.org> on 2025/09/15 16:06:38 UTC
[PR] Make database column events.request_id nullable [polaris]
adutra opened a new pull request, #2566:
URL: https://github.com/apache/polaris/pull/2566
The request ID is an optional information coming from the REST request. This PR makes it nullable in the database schema.
This PR also annotates the `ModelEvent.principalName` and `PolarisEvent.principalName` fields as nullable in code (the corresponding column was already nullable in the database schema).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make database column events.request_id nullable [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra merged PR #2566:
URL: https://github.com/apache/polaris/pull/2566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make database column events.request_id nullable [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2566:
URL: https://github.com/apache/polaris/pull/2566#discussion_r2349893921
##########
persistence/relational-jdbc/src/main/resources/h2/schema-v3.sql:
##########
@@ -129,7 +129,7 @@ CREATE TABLE IF NOT EXISTS events (
realm_id TEXT NOT NULL,
catalog_id TEXT NOT NULL,
event_id TEXT NOT NULL,
Review Comment:
side note: assuming `event_id` values are unique, this table can grow definitely, I guess... Do we have a mechanism to cap its size?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make database column events.request_id nullable [polaris]
Posted by "singhpk234 (via GitHub)" <gi...@apache.org>.
singhpk234 commented on code in PR #2566:
URL: https://github.com/apache/polaris/pull/2566#discussion_r2350016128
##########
persistence/relational-jdbc/src/main/resources/h2/schema-v3.sql:
##########
@@ -129,7 +129,7 @@ CREATE TABLE IF NOT EXISTS events (
realm_id TEXT NOT NULL,
catalog_id TEXT NOT NULL,
event_id TEXT NOT NULL,
Review Comment:
does capping size means not persisting the events when the number of records > threshold or failing unless its fixed, my understanding is failing unless we fix it (like removing last x months events in a cold store type of things and then for users we can make a view which does union from both the stores ?) would be a better way to go if we try to put a cap as we want to repurpose this for audit POV
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make database column events.request_id nullable [polaris]
Posted by "eric-maynard (via GitHub)" <gi...@apache.org>.
eric-maynard commented on code in PR #2566:
URL: https://github.com/apache/polaris/pull/2566#discussion_r2350065492
##########
persistence/relational-jdbc/src/main/resources/h2/schema-v3.sql:
##########
@@ -129,7 +129,7 @@ CREATE TABLE IF NOT EXISTS events (
realm_id TEXT NOT NULL,
catalog_id TEXT NOT NULL,
event_id TEXT NOT NULL,
Review Comment:
I would expect the listener to handle capping the size -- or some other maintenance service responsible for pruning this table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make database column events.request_id nullable [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2566:
URL: https://github.com/apache/polaris/pull/2566#discussion_r2350136946
##########
persistence/relational-jdbc/src/main/resources/h2/schema-v3.sql:
##########
@@ -129,7 +129,7 @@ CREATE TABLE IF NOT EXISTS events (
realm_id TEXT NOT NULL,
catalog_id TEXT NOT NULL,
event_id TEXT NOT NULL,
Review Comment:
My primary concern is about naive users who deploy pre-built binaries and start accumulating data in this table :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make database column events.request_id nullable [polaris]
Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on code in PR #2566:
URL: https://github.com/apache/polaris/pull/2566#discussion_r2350154023
##########
persistence/relational-jdbc/src/main/resources/h2/schema-v3.sql:
##########
@@ -129,7 +129,7 @@ CREATE TABLE IF NOT EXISTS events (
realm_id TEXT NOT NULL,
catalog_id TEXT NOT NULL,
event_id TEXT NOT NULL,
Review Comment:
Created an issue to track this: https://github.com/apache/polaris/issues/2573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org