You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/08/12 12:02:15 UTC

[GitHub] [buildstream] ssssam opened a new pull request, #1717: Update pylint config and fix some trivial issues

ssssam opened a new pull request, #1717:
URL: https://github.com/apache/buildstream/pull/1717

   This enables `lint` test to pass with Pylint >= 2.14.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [buildstream] ssssam commented on pull request #1717: Update pylint config and fix some trivial issues

Posted by GitBox <gi...@apache.org>.
ssssam commented on PR #1717:
URL: https://github.com/apache/buildstream/pull/1717#issuecomment-1213114133

   Seems this cannot work as-is with Pylint 3.13, as the `no-self-use` checks needs to be disabled there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [buildstream] gtristan commented on pull request #1717: Update pylint config and fix some trivial issues

Posted by GitBox <gi...@apache.org>.
gtristan commented on PR #1717:
URL: https://github.com/apache/buildstream/pull/1717#issuecomment-1213202282

   > Yes, can merge into #1714 if that's acceptable
   
   Of course


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [buildstream] ssssam closed pull request #1717: Update pylint config and fix some trivial issues

Posted by GitBox <gi...@apache.org>.
ssssam closed pull request #1717: Update pylint config and fix some trivial issues
URL: https://github.com/apache/buildstream/pull/1717


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [buildstream] gtristan commented on pull request #1717: Update pylint config and fix some trivial issues

Posted by GitBox <gi...@apache.org>.
gtristan commented on PR #1717:
URL: https://github.com/apache/buildstream/pull/1717#issuecomment-1213118905

   > Seems this cannot work as-is with Pylint 2.13, as the `no-self-use` checks needs to be disabled there.
   
   Better not try to submit this change separately to the branch which updates the requirements.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [buildstream] ssssam commented on pull request #1717: Update pylint config and fix some trivial issues

Posted by GitBox <gi...@apache.org>.
ssssam commented on PR #1717:
URL: https://github.com/apache/buildstream/pull/1717#issuecomment-1213122060

   Yes, can merge into https://github.com/apache/buildstream/pull/1714 if that's acceptable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org