[GitHub] [incubator-iceberg] rdblue edited a comment on issue #682: Add Parquet user-defined predicate to push down StartsWith

[GitBox <gi...@apache.org>]

rdblue edited a comment on issue #682: Add Parquet user-defined predicate to push down StartsWith
URL: https://github.com/apache/incubator-iceberg/issues/682#issuecomment-575734167
 
 
   When I opened this issue, I was thinking about the old read path. That's the one that @maqroll correctly pointed to. But we now use the new read path and the row group filters are [`ParquetMetricsRowGroupFilter`](https://github.com/apache/incubator-iceberg/blob/master/parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java) and [`ParquetDictionaryRowGroupFilter`](https://github.com/apache/incubator-iceberg/blob/master/parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java). We needed to add support to those classes for the `startsWith` predicate added by #327, which was done by @aokolnychyi in #398.
   
   I think the only remaining task for this (and for IN/NOT_IN) is to update the conversion from Spark filters to use the new Iceberg expressions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org