You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Steve Loughran (Jira)" <ji...@apache.org> on 2021/09/06 15:19:00 UTC

[jira] [Commented] (HADOOP-17894) CredentialProviderFactory.getProviders() to detect recursion

    [ https://issues.apache.org/jira/browse/HADOOP-17894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410673#comment-17410673 ] 

Steve Loughran commented on HADOOP-17894:
-----------------------------------------

need to call ProviderUtils.excludeIncompatibleCredentialProviders() on the FS conf before loading password

We are calling this in the s3a full cred binding, but not for the s3a encryptionKey.

Proposed:

* I add that recursion check to fail fast
* S3A FS excludes incompatible cred providers in init.
* hadoop-aws test.

> CredentialProviderFactory.getProviders() to detect recursion
> ------------------------------------------------------------
>
>                 Key: HADOOP-17894
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17894
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: conf, fs/s3
>    Affects Versions: 3.3.1
>            Reporter: Steve Loughran
>            Priority: Major
>
> {{CredentialProviderFactory.getProviders()}} will be called recursively if the FS being instantiated as a source of a JCECKs file calls {{Configuration.getPassword()}}.
>  S3A FileSystem does this when looking at encryption settings, even when authentication
>  is not being done by hadoop config options.
> Recursion is straightforward to detect, leaving a choice of actions
>  # Fail
>  # Fix by having getPassword() return null; this implicitly skips use of the credential providers for the nested FS instance.
>  # fix by skipping the specific credential provider factory with the problem (warn first?)
> My preference is for #3.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org