You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "BACtaki (via GitHub)" <gi...@apache.org> on 2026/03/05 22:59:10 UTC

[PR] Replace deprecated getOrComputeIfAbsent() API calls [polaris]

BACtaki opened a new pull request, #3944:
URL: https://github.com/apache/polaris/pull/3944

   Replace deprecated `getOrComputeIfAbsent()` API calls for `org.junit.jupiter.api.extension` with `computeIfAbsent()`.
   
   ## Checklist
   - [X] ๐Ÿ›ก๏ธ Don't disclose security issues! (contact security@apache.org)
   - [X] ๐Ÿ”— Clearly explained why the changes are needed, or linked related issues: Fixes #
   - [X] ๐Ÿงช Added/updated tests with good coverage, or manually tested (and explained how)
   - [X] ๐Ÿ’ก Added comments for complex logic
   - [X] ๐Ÿงพ Updated `CHANGELOG.md` (if needed)
   - [X] ๐Ÿ“š Updated documentation in `site/content/in-dev/unreleased` (if needed)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Replace deprecated getOrComputeIfAbsent() API calls [polaris]

Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #3944:
URL: https://github.com/apache/polaris/pull/3944#issuecomment-4011940629

   > We have to make this change at some point so we might as well make it now
   
   Wouldn't it be prudent to wait until after the 1.4.0 release, due in the next few days?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Replace deprecated getOrComputeIfAbsent() API calls [polaris]

Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #3944:
URL: https://github.com/apache/polaris/pull/3944#issuecomment-4280519518

   @BACtaki the PR needs a rebase now. Mind rebasing onto main?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Replace deprecated getOrComputeIfAbsent() API calls [polaris]

Posted by "adutra (via GitHub)" <gi...@apache.org>.
adutra commented on PR #3944:
URL: https://github.com/apache/polaris/pull/3944#issuecomment-4244209498

   Not stale โ€“ should be merged after the 1.4.0 release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Replace deprecated getOrComputeIfAbsent() API calls [polaris]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #3944:
URL: https://github.com/apache/polaris/pull/3944#issuecomment-4012441236

   For reference: the `integration-tests` module was specifically added for reuse in downstream projects in #590


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Replace deprecated getOrComputeIfAbsent() API calls [polaris]

Posted by "BACtaki (via GitHub)" <gi...@apache.org>.
BACtaki commented on PR #3944:
URL: https://github.com/apache/polaris/pull/3944#issuecomment-4012365336

   > > We have to make this change at some point so we might as well make it now
   > 
   > Wouldn't it be prudent to wait until after the 1.4.0 release, due in the next few days?
   
   We can wait until the 1.4.0 release, there's no rush. Any specific changes in the release you think might be relevant to this PR @adutra ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Replace deprecated getOrComputeIfAbsent() API calls [polaris]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b merged PR #3944:
URL: https://github.com/apache/polaris/pull/3944


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Replace deprecated getOrComputeIfAbsent() API calls [polaris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3944:
URL: https://github.com/apache/polaris/pull/3944#issuecomment-4240876914

   This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Replace deprecated getOrComputeIfAbsent() API calls [polaris]

Posted by "BACtaki (via GitHub)" <gi...@apache.org>.
BACtaki commented on PR #3944:
URL: https://github.com/apache/polaris/pull/3944#issuecomment-4008341547

   Requesting a quick review @adam-christian-software @snazy @dimas-b


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Replace deprecated getOrComputeIfAbsent() API calls [polaris]

Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on PR #3944:
URL: https://github.com/apache/polaris/pull/3944#issuecomment-4012424218

   Yes, merging this after 1.4.0 is branched sounds like a good compromise to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Replace deprecated getOrComputeIfAbsent() API calls [polaris]

Posted by "BACtaki (via GitHub)" <gi...@apache.org>.
BACtaki commented on PR #3944:
URL: https://github.com/apache/polaris/pull/3944#issuecomment-4009794955

   > that use `integration-tests`
   
   You make a very good point. We have to make this change at some point so we might as well make it now IMO. I have added a note in the changelog to highlight the point about downstream projects using JUnit 6. Let's see how it goes- I promise to address any fallout from this change, as unlikely as that may be (:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Replace deprecated getOrComputeIfAbsent() API calls [polaris]

Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #3944:
URL: https://github.com/apache/polaris/pull/3944#issuecomment-4259667042

   1.4 is already branched - should we merge this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org