You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/10/14 11:29:00 UTC

[jira] [Commented] (AIRFLOW-5653) Log caught AirflowSkipException in task instance log

    [ https://issues.apache.org/jira/browse/AIRFLOW-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950928#comment-16950928 ] 

ASF GitHub Bot commented on AIRFLOW-5653:
-----------------------------------------

rajatsri28 commented on pull request #6330: AIRFLOW-5653 Log caught AirflowSkipException in task instance log
URL: https://github.com/apache/airflow/pull/6330
 
 
   ### Jira
   
   - https://issues.apache.org/jira/browse/AIRFLOW-5653
   
   ### Description
   
   -  Logging any caught AirflowSkipException with message in models/taskinstance.py
   to remove confusion due to no task skipping information being present in the logs
   
   ### Tests
   
   - My PR does not needs any new tests since its just adding a single log line
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - No new functionality introduced
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Log caught AirflowSkipException in task instance log
> ----------------------------------------------------
>
>                 Key: AIRFLOW-5653
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5653
>             Project: Apache Airflow
>          Issue Type: Task
>          Components: logging
>    Affects Versions: 1.10.5
>            Reporter: Rajat Srivastava
>            Assignee: Rajat Srivastava
>            Priority: Minor
>
> It seems like when an operator throws AirflowSkipException, airflow captures it and marks following tasks as skipped too, but it leaves no trace in the task instances log and does not show exception message. This can confuse the users as they can't figure out in log why operators were marked as skipped.
> We should explicitly log the exception and its message in task instance logs, and consider other airflow-caught exceptions too. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)