You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by cloverhearts <gi...@git.apache.org> on 2016/12/29 17:14:11 UTC
[GitHub] zeppelin pull request #1821: [ZEPPELIN-1875] permission dialog code is not s...
GitHub user cloverhearts opened a pull request:
https://github.com/apache/zeppelin/pull/1821
[ZEPPELIN-1875] permission dialog code is not stable
### What is this PR for?
The code for the notification pop-up is not stable.
Sometime when response to slow for backend.
Then the permission box and the dialogue open together.
### What type of PR is it?
Bug Fix , Improvement
### Todos
- [x] changed method name (getBlockNotAuthenticatedUserErrorMsg)
- [x] permission dialog pop-up change logic.
- [x] added check logic for anonymous user in checkIfUserIsAnon method
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1875
### How should this be tested?
1. when you do have turn on the shiro and login and click to note permission button.
2. or turn off the shiro.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-PERMMIT-FIX
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1821.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1821
----
commit 4248c0b590986e59891f4289df93237a9b4284da
Author: cloverhearts <cl...@gmail.com>
Date: 2016-12-29T07:55:08Z
refix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1821: [ZEPPELIN-1875] permission dialog code is not stable
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1821
Then will merge into master if there are no more comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1821: [ZEPPELIN-1875] permission dialog code is not stable
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1821
@cloverhearts yup. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1821: [ZEPPELIN-1875] permission dialog code is not s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1821
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1821: [ZEPPELIN-1875] permission dialog code is not s...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts closed the pull request at:
https://github.com/apache/zeppelin/pull/1821
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1821: [ZEPPELIN-1875] permission dialog code is not s...
Posted by cloverhearts <gi...@git.apache.org>.
GitHub user cloverhearts reopened a pull request:
https://github.com/apache/zeppelin/pull/1821
[ZEPPELIN-1875] permission dialog code is not stable
### What is this PR for?
The code for the notification pop-up is not stable.
Sometime when response to slow for backend.
Then the permission box and the dialogue open together.
### What type of PR is it?
Bug Fix , Improvement
### Todos
- [x] changed method name (getBlockNotAuthenticatedUserErrorMsg)
- [x] permission dialog pop-up change logic.
- [x] added check logic for anonymous user in checkIfUserIsAnon method
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1875
### How should this be tested?
1. when you do have turn on the shiro and login and click to note permission button.
2. or turn off the shiro.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-PERMMIT-FIX
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1821.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1821
----
commit 4248c0b590986e59891f4289df93237a9b4284da
Author: cloverhearts <cl...@gmail.com>
Date: 2016-12-29T07:55:08Z
refix
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1821: [ZEPPELIN-1875] permission dialog code is not stable
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1821
fixed.
@AhyoungRyu Could you please review again? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1821: [ZEPPELIN-1875] permission dialog code is not stable
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1821
Tested and LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1821: [ZEPPELIN-1875] permission dialog code is not stable
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1821
@AhyoungRyu Okay, I will check it.
Thank you for your feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1821: [ZEPPELIN-1875] permission dialog code is not stable
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1821
@cloverhearts Thanks for quick fixing and improvement. I think it's my bad.. Let me test this!
But Selenium test failure looks relevant with this change like below. Could you take a look?
```
Results :
Tests in error:
AuthenticationIT.testGroupPermission:192->AbstractZeppelinIT.pollingWait:96 ยป Timeout
Tests run: 18, Failures: 0, Errors: 1, Skipped: 0
```
This is the screenshot taken when the error occurs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1821: [ZEPPELIN-1875] permission dialog code is not stable
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1821
Tested this branch and checked the verbose forbidden error messages(my bad..) are totally gone when I turned off Shiro. Thanks @cloverhearts!
LGTM \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---