You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/02/01 18:34:12 UTC
[GitHub] rhtyd commented on a change in pull request #2433: Fix and enhance package script
rhtyd commented on a change in pull request #2433: Fix and enhance package script
URL: https://github.com/apache/cloudstack/pull/2433#discussion_r165447356
##########
File path: packaging/package.sh
##########
@@ -155,31 +181,51 @@ while [ $# -gt 0 ] ; do
usage
exit 1
fi
- shift
+ shift 2
;;
+
-d | --distribution)
TARGETDISTRO=$2
if [ -z "$TARGETDISTRO" ] ; then
echo "Error: Missing target distribution"
usage
exit 1
fi
- shift
+ shift 2
;;
+
-r | --release)
RELEASE=$2
- shift
+ shift 2
;;
- -)
- echo "Error: Unrecognized option"
- usage
- exit 1
+
+ -b | --brand)
+ BRANDING=$2
+ shift 2
+ ;;
+
+ -T | --use-timestamp)
+ SNAPSHOT_TIMESTAMP="$(date +%s)"
+ shift 1
;;
+
+ -*)
+ unrecognized_flags="${unrecognized_flags}$1 "
+ shift 1
+ ;;
+
*)
- shift
+ shift 1
;;
esac
done
-packaging "$PACKAGEVAL" "$SIM" "$TARGETDISTRO" "$RELEASE"
+if [ -n "$unrecognized_flags" ]; then
+ echo "Warning: Unrecognized option(s) found \" ${unrecognized_flags}\""
+ echo " You're advised to fix your build job scripts and prevent using these"
+ echo " flags, as in the future release(s) they will break packaging script."
+ echo ""
+fi
+echo "Packaging CloudStack..."
+packaging "$PACKAGEVAL" "$SIM" "$TARGETDISTRO" "$RELEASE" "$BRANDING"
Review comment:
Should you also pass `$SNAPSHOT_TIMESTAMP` as `$6` to `packaging`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services