[jira] Commented: (TAPESTRY-257) favicon support for Shell component

["Andreas Andreou (JIRA)" <ta...@jakarta.apache.org>]

    [ http://issues.apache.org/jira/browse/TAPESTRY-257?page=comments#action_12377205 ] 

Andreas Andreou commented on TAPESTRY-257:
------------------------------------------

Of course, this could render
<link rel="shortcut icon" type="image/x-icon" href="/favicon.ico" />  (as stated)
but i've seen (for instance in this very site)
<link rel="shortcut icon" href="/jira/images/icons/favicon.ico"> (type is missing)
and also
<link rel="icon" type="image/png" href="/jira/images/icons/favicon.png"> (different type and rel)

Given those alternatives, perhaps we can take care of this in a more generic way.

Perhaps the favicon parameter should only generate:
<link rel="shortcut icon" href="/jira/images/icons/favicon.ico"> 
and we can have an additional parameter 'links' which will accept a List or Collection or array of a
new class, named Link or HtmlLink or HtmlRelation. This should have href, media, name, rev, rel, title, type
properties and will be able to render them if they contain a non-null value.
See http://www.blooberry.com/indexdot/html/tagpages/l/link.htm for more, but i think these are the most important
and they do cover css inclusion in a much better way than the currently supported.

Returning to the favicon issue, I also believe that the favicon parameter (ot whatever its name will be) should be an IAsset but also a simple string.

> favicon support for Shell component
> -----------------------------------
>
>          Key: TAPESTRY-257
>          URL: http://issues.apache.org/jira/browse/TAPESTRY-257
>      Project: Tapestry
>         Type: Improvement

>   Components: Framework
>     Versions: 3.0.1, 4.0.2
>     Reporter: Ben Walding
>     Assignee: Brian K. Wallace
>      Fix For: 4.0.3, 3.0.5

>
> It would be handy if the Shell component supported setting a favicon.  
> eg. same as how the stylesheet can be filled in from the Shell component -
> <link rel="shortcut icon" type="image/x-icon" href="/favicon.ico" />
> I'd expect to be able to have 
> <private-asset name="favicon" resource-path="/images/favicon.ico"/>
> and then
> <span jwcid="@Shell" favicon="ognl:assets.favicon" title="MyCorp Customer Login">
> If this has merit, I'll submit a patch. If there is some elegant way I've overlooked, please let me know.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org