You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org> on 2025/07/28 15:05:53 UTC
Re: [PR] [Chore][Master] Rename methods in StateAction for better readability. [dolphinscheduler]
github-advanced-security[bot] commented on code in PR #17379:
URL: https://github.com/apache/dolphinscheduler/pull/17379#discussion_r2236872594
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/statemachine/ITaskStateAction.java:
##########
@@ -55,105 +55,105 @@
* Perform the necessary actions when the task in a certain state receive a {@link TaskStartLifecycleEvent}.
* <p> This method is called when you want to start a task.
*/
- void startEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskStartLifecycleEvent taskStartEvent);
+ void onStartEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskStartLifecycleEvent taskStartEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskRunningLifecycleEvent}.
* <p> This method is called when the master receive task running event from executor.
*/
- void startedEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskRunningLifecycleEvent taskRunningEvent);
+ void onStartedEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskRunningLifecycleEvent taskRunningEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskRuntimeContextChangedEvent}.
* <p> This method is called when the master receive task runtime context changed event from executor.
*/
- void runtimeContextChangedEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskRuntimeContextChangedEvent taskRuntimeContextChangedEvent);
+ void onRuntimeContextChangedEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
Review Comment:
## Useless parameter
The parameter 'workflowExecutionRunnable' is never used.
[Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/5486)
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/statemachine/ITaskStateAction.java:
##########
@@ -55,105 +55,105 @@
* Perform the necessary actions when the task in a certain state receive a {@link TaskStartLifecycleEvent}.
* <p> This method is called when you want to start a task.
*/
- void startEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskStartLifecycleEvent taskStartEvent);
+ void onStartEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskStartLifecycleEvent taskStartEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskRunningLifecycleEvent}.
* <p> This method is called when the master receive task running event from executor.
*/
- void startedEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskRunningLifecycleEvent taskRunningEvent);
+ void onStartedEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
Review Comment:
## Useless parameter
The parameter 'workflowExecutionRunnable' is never used.
[Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/5487)
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/statemachine/ITaskStateAction.java:
##########
@@ -55,105 +55,105 @@
* Perform the necessary actions when the task in a certain state receive a {@link TaskStartLifecycleEvent}.
* <p> This method is called when you want to start a task.
*/
- void startEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskStartLifecycleEvent taskStartEvent);
+ void onStartEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskStartLifecycleEvent taskStartEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskRunningLifecycleEvent}.
* <p> This method is called when the master receive task running event from executor.
*/
- void startedEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskRunningLifecycleEvent taskRunningEvent);
+ void onStartedEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskRunningLifecycleEvent taskRunningEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskRuntimeContextChangedEvent}.
* <p> This method is called when the master receive task runtime context changed event from executor.
*/
- void runtimeContextChangedEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskRuntimeContextChangedEvent taskRuntimeContextChangedEvent);
+ void onRuntimeContextChangedEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskRuntimeContextChangedEvent taskRuntimeContextChangedEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskRetryLifecycleEvent}.
* <p> This method is called when the task need to retry.
*/
- void retryEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskRetryLifecycleEvent taskRetryEvent);
+ void onRetryEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
Review Comment:
## Useless parameter
The parameter 'workflowExecutionRunnable' is never used.
[Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/5485)
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/statemachine/ITaskStateAction.java:
##########
@@ -55,105 +55,105 @@
* Perform the necessary actions when the task in a certain state receive a {@link TaskStartLifecycleEvent}.
* <p> This method is called when you want to start a task.
*/
- void startEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskStartLifecycleEvent taskStartEvent);
+ void onStartEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskStartLifecycleEvent taskStartEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskRunningLifecycleEvent}.
* <p> This method is called when the master receive task running event from executor.
*/
- void startedEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskRunningLifecycleEvent taskRunningEvent);
+ void onStartedEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskRunningLifecycleEvent taskRunningEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskRuntimeContextChangedEvent}.
* <p> This method is called when the master receive task runtime context changed event from executor.
*/
- void runtimeContextChangedEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskRuntimeContextChangedEvent taskRuntimeContextChangedEvent);
+ void onRuntimeContextChangedEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskRuntimeContextChangedEvent taskRuntimeContextChangedEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskRetryLifecycleEvent}.
* <p> This method is called when the task need to retry.
*/
- void retryEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskRetryLifecycleEvent taskRetryEvent);
+ void onRetryEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskRetryLifecycleEvent taskRetryEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskDispatchLifecycleEvent}.
* <p> This method is called when you want to dispatch a task.
*/
- void dispatchEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskDispatchLifecycleEvent taskDispatchEvent);
+ void onDispatchEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
Review Comment:
## Useless parameter
The parameter 'workflowExecutionRunnable' is never used.
[Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/5484)
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/engine/task/statemachine/ITaskStateAction.java:
##########
@@ -55,105 +55,105 @@
* Perform the necessary actions when the task in a certain state receive a {@link TaskStartLifecycleEvent}.
* <p> This method is called when you want to start a task.
*/
- void startEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskStartLifecycleEvent taskStartEvent);
+ void onStartEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskStartLifecycleEvent taskStartEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskRunningLifecycleEvent}.
* <p> This method is called when the master receive task running event from executor.
*/
- void startedEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskRunningLifecycleEvent taskRunningEvent);
+ void onStartedEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskRunningLifecycleEvent taskRunningEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskRuntimeContextChangedEvent}.
* <p> This method is called when the master receive task runtime context changed event from executor.
*/
- void runtimeContextChangedEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskRuntimeContextChangedEvent taskRuntimeContextChangedEvent);
+ void onRuntimeContextChangedEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskRuntimeContextChangedEvent taskRuntimeContextChangedEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskRetryLifecycleEvent}.
* <p> This method is called when the task need to retry.
*/
- void retryEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskRetryLifecycleEvent taskRetryEvent);
+ void onRetryEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskRetryLifecycleEvent taskRetryEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskDispatchLifecycleEvent}.
* <p> This method is called when you want to dispatch a task.
*/
- void dispatchEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskDispatchLifecycleEvent taskDispatchEvent);
+ void onDispatchEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskDispatchLifecycleEvent taskDispatchEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskDispatchedLifecycleEvent}.
* <p> This method is called when the task has been dispatched to executor.
*/
- void dispatchedEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskDispatchedLifecycleEvent taskDispatchedEvent);
+ void onDispatchedEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskDispatchedLifecycleEvent taskDispatchedEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskPauseLifecycleEvent}.
* <p> This method is called when you want to pause a task.
*/
- void pauseEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskPauseLifecycleEvent taskPauseEvent);
+ void onPauseEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskPauseLifecycleEvent taskPauseEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskPausedLifecycleEvent}.
* <p> This method is called when the task has been paused.
*/
- void pausedEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskPausedLifecycleEvent taskPausedEvent);
+ void onPausedEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskPausedLifecycleEvent taskPausedEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskKillLifecycleEvent}.
* <p> This method is called when you want to kill a task.
*/
- void killEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskKillLifecycleEvent taskKillEvent);
+ void onKillEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskKillLifecycleEvent taskKillEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskKilledLifecycleEvent}.
* <p> This method is called when the task has been killed.
*/
- void killedEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskKilledLifecycleEvent taskKilledEvent);
+ void onKilledEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskKilledLifecycleEvent taskKilledEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskFailedLifecycleEvent}.
* <p> This method is called when the task has been failed.
*/
- void failedEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskFailedLifecycleEvent taskFailedEvent);
+ void onFailedEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskFailedLifecycleEvent taskFailedEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskSuccessLifecycleEvent}.
* <p> This method is called when the task has been success.
*/
- void succeedEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskSuccessLifecycleEvent taskSuccessEvent);
+ void onSucceedEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
+ final ITaskExecutionRunnable taskExecutionRunnable,
+ final TaskSuccessLifecycleEvent taskSuccessEvent);
/**
* Perform the necessary actions when the task in a certain state receive a {@link TaskFailoverLifecycleEvent}.
* <p> This method is called when the task need to failover.
*/
- void failoverEventAction(final IWorkflowExecutionRunnable workflowExecutionRunnable,
- final ITaskExecutionRunnable taskExecutionRunnable,
- final TaskFailoverLifecycleEvent taskFailoverEvent);
+ void onFailoverEvent(final IWorkflowExecutionRunnable workflowExecutionRunnable,
Review Comment:
## Useless parameter
The parameter 'workflowExecutionRunnable' is never used.
[Show more details](https://github.com/apache/dolphinscheduler/security/code-scanning/5483)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org