[GitHub] [skywalking] wankai123 commented on a change in pull request #7509: Support grouped dynamic configurations in DCS and add zookeeper implementation

[GitBox <gi...@apache.org>]

wankai123 commented on a change in pull request #7509:
URL: https://github.com/apache/skywalking/pull/7509#discussion_r692766623



##########
File path: oap-server/server-configuration/configuration-zookeeper/src/main/java/org/apache/skywalking/oap/server/configuration/zookeeper/ZookeeperConfigWatcherRegister.java
##########
@@ -46,9 +51,28 @@ public ZookeeperConfigWatcherRegister(ZookeeperServerSettings settings) throws E
     @Override
     public Optional<ConfigTable> readConfig(Set<String> keys) {
         ConfigTable table = new ConfigTable();
-        keys.forEach(s -> {
-            ChildData data = this.childrenCache.getCurrentData(this.prefix + s);
-            table.add(new ConfigTable.ConfigItem(s, data == null ? null : new String(data.getData())));
+        keys.forEach(key -> {
+            if (key.startsWith(ConfigChangeWatcher.WatchType.GROUP.name())) {

Review comment:
       yes, It can get from `WatcherHolder` by changing the class authority. we don't need to check from the name's prefix.
   and then should we keep the name's prefix `GROUP` to identify it's a `GROUP key`? @wu-sheng wu




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org