You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ilya Pronin <ip...@twitter.com> on 2016/11/29 15:30:51 UTC
Review Request 54167: Removed cyclic header dependency in libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54167/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Bugs: MESOS-6647
https://issues.apache.org/jira/browse/MESOS-6647
Repository: mesos
Description
-------
Removed cyclic header dependency in libprocess.
Diffs
-----
3rdparty/libprocess/include/process/executor.hpp 48c1b34b6bd117653c1728321cf96b909e535964
Diff: https://reviews.apache.org/r/54167/diff/
Testing
-------
```
make && make check
```
Thanks,
Ilya Pronin
Re: Review Request 54167: Removed cyclic header dependency in
libprocess.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54167/#review157261
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Nov. 29, 2016, 4:39 p.m., Ilya Pronin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54167/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 4:39 p.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-6647
> https://issues.apache.org/jira/browse/MESOS-6647
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `executor.hpp` doesn't need anything from `defer.hpp` but defines a macro that is used in it.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/executor.hpp 48c1b34b6bd117653c1728321cf96b909e535964
>
> Diff: https://reviews.apache.org/r/54167/diff/
>
>
> Testing
> -------
>
> ```
> make && make check
> ```
>
>
> Thanks,
>
> Ilya Pronin
>
>
Re: Review Request 54167: Removed cyclic header dependency in
libprocess.
Posted by Ilya Pronin <ip...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54167/
-----------------------------------------------------------
(Updated Nov. 29, 2016, 3:39 p.m.)
Review request for mesos and Benjamin Bannier.
Bugs: MESOS-6647
https://issues.apache.org/jira/browse/MESOS-6647
Repository: mesos
Description (updated)
-------
`executor.hpp` doesn't need anything from `defer.hpp` but defines a macro that is used in it.
Diffs
-----
3rdparty/libprocess/include/process/executor.hpp 48c1b34b6bd117653c1728321cf96b909e535964
Diff: https://reviews.apache.org/r/54167/diff/
Testing
-------
```
make && make check
```
Thanks,
Ilya Pronin