You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2013/11/08 12:14:21 UTC
svn commit: r1539980 -
/tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java
Author: markt
Date: Fri Nov 8 11:14:21 2013
New Revision: 1539980
URL: http://svn.apache.org/r1539980
Log:
Remove TODO and improve comment. Review from kkolinko
Modified:
tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java
Modified: tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java?rev=1539980&r1=1539979&r2=1539980&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java (original)
+++ tomcat/trunk/java/org/apache/catalina/webresources/StandardRoot.java Fri Nov 8 11:14:21 2013
@@ -112,9 +112,9 @@ public class StandardRoot extends Lifecy
}
// Set because we don't want duplicates
- // LinkedHashSet to retain the order (shouldn't matter but Jira is
- // sensitive to the order the JARs are returned in).
- // TODO - Revert to HashSet
+ // LinkedHashSet to retain the order. It is the order of the
+ // WebResourceSet that matters but it is simpler to retain the order
+ // over all of the JARs.
HashSet<String> result = new LinkedHashSet<>();
for (ArrayList<WebResourceSet> list : allResources) {
for (WebResourceSet webResourceSet : list) {
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org