You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Ian Boston <ie...@tfd.co.uk> on 2010/06/03 12:47:18 UTC
Re: svn commit: r950907 - /sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java
On 3 Jun 2010, at 09:04, bdelacretaz@apache.org wrote:
> Modified: sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java
> URL: http://svn.apache.org/viewvc/sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java?rev=950907&r1=950906&r2=950907&view=diff
> ==============================================================================
> --- sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java (original)
> +++ sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java Thu Jun 3 08:04:42 2010
> @@ -57,7 +57,6 @@ public class TestAll extends TestCase {
> "**/launchpad/webapp/integrationtest/**/*Test");
> String testRegex = convertToRegex(testPattern);
> Pattern pattern = Pattern.compile(testRegex);
> - LOGGER.info("Using Pattern " + testRegex);
> for (URL u : urls) {
> try {
> matchingClasses.addAll(scanFile(new File(u.toURI()), pattern));
Might be an idea to leave this in as, at the moment we are parsing the maven DirectorySet and converting it to a regex.
I think the conversion is correct, but I cant be sure for everything that someone might decided to enter.
(also.... every time I do a regex... it does my head in :))
WDYT ?
Ian
Re: svn commit: r950907 - /sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java
Posted by Ian Boston <ie...@tfd.co.uk>.
On 3 Jun 2010, at 13:01, Bertrand Delacretaz wrote:
>
> Sure - I didn't remove the log statement, just moved it a few lines
> later in the method, so as to include the number of test classes
> found, is that ok with you?
oh, sorry, I missed that, must be blind today.
yes absolutely ok with me.
Thanks
Ian
Re: svn commit: r950907 - /sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Thu, Jun 3, 2010 at 12:47 PM, Ian Boston <ie...@tfd.co.uk> wrote:
>
> On 3 Jun 2010, at 09:04, bdelacretaz@apache.org wrote:
>
>> Modified: sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java
>> URL: http://svn.apache.org/viewvc/sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java?rev=950907&r1=950906&r2=950907&view=diff
>> ==============================================================================
>> --- sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java (original)
>> +++ sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java Thu Jun 3 08:04:42 2010
>> @@ -57,7 +57,6 @@ public class TestAll extends TestCase {
>> "**/launchpad/webapp/integrationtest/**/*Test");
>> String testRegex = convertToRegex(testPattern);
>> Pattern pattern = Pattern.compile(testRegex);
>> - LOGGER.info("Using Pattern " + testRegex);
>> for (URL u : urls) {
>> try {
>> matchingClasses.addAll(scanFile(new File(u.toURI()), pattern));
>
>
> Might be an idea to leave this in as, at the moment we are parsing the maven DirectorySet and converting it to a regex.
> I think the conversion is correct, but I cant be sure for everything that someone might decided to enter....
Sure - I didn't remove the log statement, just moved it a few lines
later in the method, so as to include the number of test classes
found, is that ok with you?
> (also.... every time I do a regex... it does my head in :))
of course ;-)
-Bertrand
Re: svn commit: r950907 - /sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Thu, Jun 3, 2010 at 12:47 PM, Ian Boston <ie...@tfd.co.uk> wrote:
>
> On 3 Jun 2010, at 09:04, bdelacretaz@apache.org wrote:
>
>> Modified: sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java
>> URL: http://svn.apache.org/viewvc/sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java?rev=950907&r1=950906&r2=950907&view=diff
>> ==============================================================================
>> --- sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java (original)
>> +++ sling/trunk/launchpad/testing/src/test/java/org/apache/sling/launchpad/testing/TestAll.java Thu Jun 3 08:04:42 2010
>> @@ -57,7 +57,6 @@ public class TestAll extends TestCase {
>> "**/launchpad/webapp/integrationtest/**/*Test");
>> String testRegex = convertToRegex(testPattern);
>> Pattern pattern = Pattern.compile(testRegex);
>> - LOGGER.info("Using Pattern " + testRegex);
>> for (URL u : urls) {
>> try {
>> matchingClasses.addAll(scanFile(new File(u.toURI()), pattern));
>
>
> Might be an idea to leave this in as, at the moment we are parsing the maven DirectorySet and converting it to a regex.
> I think the conversion is correct, but I cant be sure for everything that someone might decided to enter....
Sure - I didn't remove the log statement, just moved it a few lines
later in the method, so as to include the number of test classes
found, is that ok with you?
> (also.... every time I do a regex... it does my head in :))
of course ;-)
-Bertrand