You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by banjiewen <gi...@git.apache.org> on 2016/02/24 02:26:05 UTC

[GitHub] incubator-tinkerpop pull request: Fix HTTP keepalive support

GitHub user banjiewen opened a pull request:

    https://github.com/apache/incubator-tinkerpop/pull/239

    Fix HTTP keepalive support

    [This commit][1] broke HTTP keepalive support by introducing a
    double-negation on the call to Netty's isKeepAlive.
    
    [1]: https://github.com/apache/incubator-tinkerpop/commit/c0121aae8266e9ff2c70c1517e809b5ecf1dd07a

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/banjiewen/incubator-tinkerpop fix-http-keepalive

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tinkerpop/pull/239.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #239
    
----
commit 1a0a81543cf8e258a7cd165e27d58e28c0678dff
Author: Benjamin Anderson <b...@banjiewen.net>
Date:   2016-02-24T01:24:15Z

    Fix HTTP keepalive support
    
    This commit[1] broke HTTP keepalive support by introducing a
    double-negation on the call to Netty's isKeepAlive.
    
    [1]: https://github.com/apache/incubator-tinkerpop/commit/c0121aae8266e9ff2c70c1517e809b5ecf1dd07a

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: Fix HTTP keepalive support

Posted by banjiewen <gi...@git.apache.org>.
Github user banjiewen commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/239#issuecomment-188385569
  
    Sure, will re-open with `tp31` as the target.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: Fix HTTP keepalive support

Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:

    https://github.com/apache/incubator-tinkerpop/pull/239#issuecomment-188227106
  
    damn - i see what i did there. this needs to be fixed for 3.1.2. as such, can you please retarget this PR for the tp31 branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request: Fix HTTP keepalive support

Posted by banjiewen <gi...@git.apache.org>.
Github user banjiewen closed the pull request at:

    https://github.com/apache/incubator-tinkerpop/pull/239


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---