You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2014/11/18 05:45:33 UTC
[GitHub] tajo pull request: TAJO-1190: INSERT INTO to partition tables may ...
GitHub user hyunsik opened a pull request:
https://github.com/apache/tajo/pull/250
TAJO-1190: INSERT INTO to partition tables may cause NPE.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hyunsik/tajo TAJO-1190
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/250.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #250
----
commit 8822b71ce5dd4d96be32329e44196ee452b6f8fd
Author: Hyunsik Choi <hy...@apache.org>
Date: 2014-11-18T04:44:44Z
TAJO-1190: INSERT INTO to partition tables may cause NPE.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1190: INSERT INTO to partition tables may ...
Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:
https://github.com/apache/tajo/pull/250#issuecomment-63754237
+1
It looks good to me and all unit test cases passed successfully.
Push it. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1190: INSERT INTO to partition tables may ...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/250#issuecomment-65177520
Hi @blrunner,
I cleaned up and I've fixed more bugs. This patch also includes TAJO-1219 (https://issues.apache.org/jira/browse/TAJO-1219). Could you review it again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1190: INSERT INTO to partition tables may ...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on the pull request:
https://github.com/apache/tajo/pull/250#issuecomment-65241039
+1
The fix looks straightforward. Travis-CI seem busy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1190: INSERT INTO to partition tables may ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/250
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-1190: INSERT INTO to partition tables may ...
Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/250#issuecomment-65267554
Thanks! I'll commit it shortly. In some cases, I may need the jenkins instead of TravisCI. Of course, I'll submit the patch through PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---