You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/09/29 15:10:36 UTC
[GitHub] [yunikorn-core] 0yukali0 opened a new pull request, #440: [YUNIKORN-1340] Improving coverage in utils.go
0yukali0 opened a new pull request, #440:
URL: https://github.com/apache/yunikorn-core/pull/440
### What is this PR for?
I added some unit test for Improving coverage of following functions.
- WaitFor
- GetBoolEnvVar
- GetPreemptionFromTag
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1340
### How should this be tested?
1. make test
2. go tool cover -html=coverage.txt (optional)
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #440: [YUNIKORN-1340] Improving coverage in utils.go
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #440:
URL: https://github.com/apache/yunikorn-core/pull/440#issuecomment-1262471300
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/440?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#440](https://codecov.io/gh/apache/yunikorn-core/pull/440?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d97c8ae) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/1bfc5792129331c179da8c98730a94ec9839497b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1bfc579) will **increase** coverage by `0.17%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #440 +/- ##
==========================================
+ Coverage 72.44% 72.62% +0.17%
==========================================
Files 65 65
Lines 9568 9568
==========================================
+ Hits 6932 6949 +17
+ Misses 2397 2381 -16
+ Partials 239 238 -1
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/440?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/utils.go](https://codecov.io/gh/apache/yunikorn-core/pull/440/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi91dGlscy5nbw==) | `93.60% <0.00%> (+13.59%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s closed pull request #440: [YUNIKORN-1340] Improving coverage in utils.go
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #440: [YUNIKORN-1340] Improving coverage in utils.go
URL: https://github.com/apache/yunikorn-core/pull/440
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org