[jira] Assigned: (WICKET-1810) StringRequestTarget is bloated and needs some care

["Igor Vaynberg (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg reassigned WICKET-1810:
-------------------------------------

    Assignee: Eelco Hillenius

was there a specific reason you were buffering the string first?

> StringRequestTarget is bloated and needs some care
> --------------------------------------------------
>
>                 Key: WICKET-1810
>                 URL: https://issues.apache.org/jira/browse/WICKET-1810
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Peter Ertl
>            Assignee: Eelco Hillenius
>         Attachments: StringRequestTarget.patch
>
>
> when looking at  StringRequestTarget I found the following things unnecessary
> (1) create a Charset object where a String is sufficient for the encoding
> (2) Write into a stream first, then read back from it and write to the response stream using an internal buffer
> (3) flush the output stream
> (4) having to specify the charset in the 'contentType' and again in the 'charset' parameter.
> I made up an own version of StringRequestTarget and attached a patch for it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.