You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2018/01/24 01:22:10 UTC
[GitHub] spark pull request #20374: [SPARK-XXX][SS][TEST] Fix KafkaContinuousSourceSt...
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/20374
[SPARK-XXX][SS][TEST] Fix KafkaContinuousSourceStressForDontFailOnDataLossSuite to test ContinuousExecution
## What changes were proposed in this pull request?
Currently, `KafkaContinuousSourceStressForDontFailOnDataLossSuite` runs on `MicroBatchExecution`. It should test `ContinuousExecution`.
## How was this patch tested?
Pass the updated test suite.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/spark SPARK-23198
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20374.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20374
----
commit fb7fa9e08bc2337f481a855bc258fe7d52c04d68
Author: Dongjoon Hyun <do...@...>
Date: 2018-01-24T01:13:54Z
[SPARK-XXX][SS][TEST] Fix KafkaContinuousSourceStressForDontFailOnDataLossSuite to test ContinuousExecution
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20374: [SPARK-23198][SS][TEST] Fix KafkaContinuousSourceStressF...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20374
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/164/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20374: [SPARK-23198][SS][TEST] Fix KafkaContinuousSourceStressF...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20374
**[Test build #86556 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86556/testReport)** for PR 20374 at commit [`fb7fa9e`](https://github.com/apache/spark/commit/fb7fa9e08bc2337f481a855bc258fe7d52c04d68).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20374: [SPARK-23198][SS][TEST] Fix KafkaContinuousSource...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20374#discussion_r163431340
--- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaContinuousSourceSuite.scala ---
@@ -91,6 +91,7 @@ class KafkaContinuousSourceStressForDontFailOnDataLossSuite
ds.writeStream
.format("memory")
.queryName("memory")
+ .trigger(Trigger.Continuous("1 second"))
--- End diff --
Hi, @tdas and @jose-torres .
Could you review this PR?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20374: [SPARK-23198][SS][TEST] Fix KafkaContinuousSource...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20374
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20374: [SPARK-23198][SS][TEST] Fix KafkaContinuousSourceStressF...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20374
Thank you, @zsxwing !
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20374: [SPARK-23198][SS][TEST] Fix KafkaContinuousSourceStressF...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20374
Gentle ping, @tdas and @zsxwing .
It's a minor test case issue, but it would be great if we can have this in Spark 2.3.0 RC3.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20374: [SPARK-23198][SS][TEST] Fix KafkaContinuousSourceStressF...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20374
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20374: [SPARK-23198][SS][TEST] Fix KafkaContinuousSourceStressF...
Posted by jose-torres <gi...@git.apache.org>.
Github user jose-torres commented on the issue:
https://github.com/apache/spark/pull/20374
LGTM. Thanks for catching this!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20374: [SPARK-23198][SS][TEST] Fix KafkaContinuousSourceStressF...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20374
**[Test build #86556 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/86556/testReport)** for PR 20374 at commit [`fb7fa9e`](https://github.com/apache/spark/commit/fb7fa9e08bc2337f481a855bc258fe7d52c04d68).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20374: [SPARK-23198][SS][TEST] Fix KafkaContinuousSourceStressF...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20374
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/86556/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20374: [SPARK-23198][SS][TEST] Fix KafkaContinuousSourceStressF...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20374
Thank you for review, @jose-torres !
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20374: [SPARK-23198][SS][TEST] Fix KafkaContinuousSourceStressF...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20374
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20374: [SPARK-23198][SS][TEST] Fix KafkaContinuousSourceStressF...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/20374
LGTM. Thanks! Merging to master and 2.3.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org