You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2021/11/17 09:28:56 UTC
[GitHub] [incubator-hop] mattcasters opened a new pull request #1197: HOP-3479 : Hop Web white on white colors in combo
mattcasters opened a new pull request #1197:
URL: https://github.com/apache/incubator-hop/pull/1197
Also some code hardening for fixed width fonts on the various platforms and other minor color tweaks in the themes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva edited a comment on pull request #1197: HOP-3479 : Hop Web white on white colors in combo
Posted by GitBox <gi...@apache.org>.
hansva edited a comment on pull request #1197:
URL: https://github.com/apache/incubator-hop/pull/1197#issuecomment-971433954
The GUI font seems fine, i replaced it in hop-config.json to "Monaco"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on pull request #1197: HOP-3479 : Hop Web white on white colors in combo
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #1197:
URL: https://github.com/apache/incubator-hop/pull/1197#issuecomment-971433954
The GUI font seems fine, i replaced it in hop-config.json to "Monaco"
Not sure there is an easy fix for this one other then not following the system font color, when you set the OS in dark and Hop Web in light it will still "replace" some elements
<img width="765" alt="Screenshot 2021-11-17 at 11 06 55" src="https://user-images.githubusercontent.com/1140235/142181645-426e432f-1bc1-4f31-aef8-7816025bc994.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] mattcasters commented on a change in pull request #1197: HOP-3479 : Hop Web white on white colors in combo
Posted by GitBox <gi...@apache.org>.
mattcasters commented on a change in pull request #1197:
URL: https://github.com/apache/incubator-hop/pull/1197#discussion_r751054390
##########
File path: ui/src/main/java/org/apache/hop/ui/core/PropsUi.java
##########
@@ -174,8 +186,20 @@ public void setFixedFont(FontData fd) {
public FontData getFixedFont() {
FontData def = getDefaultFontData();
- String name =
- getProperty(STRING_FONT_FIXED_NAME, Const.isWindows() ? "Consolas" : "Monospaced");
+ String name = getProperty(STRING_FONT_FIXED_NAME);
Review comment:
@hansva can you check this font on OSX? You might have to change it in hop-config.json under GuiProperties : FontFixedName
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva merged pull request #1197: HOP-3479 : Hop Web white on white colors in combo
Posted by GitBox <gi...@apache.org>.
hansva merged pull request #1197:
URL: https://github.com/apache/incubator-hop/pull/1197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org