You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "comphead (via GitHub)" <gi...@apache.org> on 2024/11/01 15:08:06 UTC

Re: [PR] Derive `Clone` for more ExecutionPlans [datafusion]

comphead commented on code in PR #13203:
URL: https://github.com/apache/datafusion/pull/13203#discussion_r1825932243


##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -293,7 +293,7 @@ impl JoinLeftData {
 ///                       │  "dimension"  │     │    "fact"     │
 ///                       └───────────────┘     └───────────────┘
 /// ```
-#[derive(Debug)]
+#[derive(Debug)] // note not Clone because of the OnceAsync

Review Comment:
   Would be amazing to clarify what is OnceAsync and why clone is not fit for it? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org