You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by gi...@apache.org on 2026/08/11 19:03:01 UTC
(datafusion) branch asf-site updated: Publish built docs triggered by 9ecb75fb72c4b12c15e9c159cc61b3017357728d
This is an automated email from the ASF dual-hosted git repository.
github-actions[bot] pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/datafusion.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 81e15d61ba Publish built docs triggered by 9ecb75fb72c4b12c15e9c159cc61b3017357728d
81e15d61ba is described below
commit 81e15d61bab2c545458bf188efb49e4aa67152dc
Author: github-actions[bot] <gi...@users.noreply.github.com>
AuthorDate: Tue Aug 11 19:02:54 2026 +0000
Publish built docs triggered by 9ecb75fb72c4b12c15e9c159cc61b3017357728d
---
_sources/contributor-guide/index.md.txt | 23 +-
_sources/contributor-guide/pr_review.md.txt | 240 +++++++++++++
_sources/index.rst.txt | 1 +
contributor-guide/api-health.html | 1 +
contributor-guide/architecture.html | 1 +
.../architecture/dependency-graph.html | 1 +
contributor-guide/communication.html | 7 +-
contributor-guide/development_environment.html | 1 +
contributor-guide/governance.html | 1 +
.../gsoc/gsoc_application_guidelines_2025.html | 1 +
.../gsoc/gsoc_project_ideas_2025.html | 1 +
contributor-guide/gsoc/index.html | 1 +
contributor-guide/howtos.html | 1 +
contributor-guide/index.html | 25 +-
contributor-guide/inviting.html | 1 +
.../{release_management.html => pr_review.html} | 393 +++++++++++----------
contributor-guide/release_management.html | 1 +
contributor-guide/roadmap.html | 1 +
contributor-guide/specification/index.html | 1 +
contributor-guide/specification/invariants.html | 1 +
.../specification/output-field-name-semantic.html | 1 +
contributor-guide/testing.html | 1 +
download.html | 1 +
genindex.html | 1 +
index.html | 2 +
library-user-guide/building-logical-plans.html | 1 +
library-user-guide/catalogs.html | 1 +
library-user-guide/custom-table-providers.html | 1 +
library-user-guide/extending-operators.html | 1 +
library-user-guide/extending-sql.html | 1 +
library-user-guide/extensions.html | 1 +
library-user-guide/functions/adding-udfs.html | 1 +
library-user-guide/functions/index.html | 1 +
library-user-guide/functions/spark.html | 1 +
library-user-guide/index.html | 1 +
library-user-guide/profiling.html | 1 +
library-user-guide/query-optimizer.html | 1 +
library-user-guide/table-constraints.html | 1 +
library-user-guide/upgrading/46.0.0.html | 1 +
library-user-guide/upgrading/47.0.0.html | 1 +
library-user-guide/upgrading/48.0.0.html | 1 +
library-user-guide/upgrading/48.0.1.html | 1 +
library-user-guide/upgrading/49.0.0.html | 1 +
library-user-guide/upgrading/50.0.0.html | 1 +
library-user-guide/upgrading/51.0.0.html | 1 +
library-user-guide/upgrading/52.0.0.html | 1 +
library-user-guide/upgrading/53.0.0.html | 1 +
library-user-guide/upgrading/54.0.0.html | 1 +
library-user-guide/upgrading/55.0.0.html | 1 +
library-user-guide/upgrading/index.html | 1 +
library-user-guide/using-the-dataframe-api.html | 1 +
library-user-guide/using-the-sql-api.html | 1 +
library-user-guide/working-with-exprs.html | 1 +
objects.inv | Bin 2406 -> 2429 bytes
search.html | 1 +
searchindex.js | 2 +-
user-guide/arrow-introduction.html | 1 +
user-guide/cli/datasources.html | 1 +
user-guide/cli/functions.html | 1 +
user-guide/cli/index.html | 1 +
user-guide/cli/installation.html | 1 +
user-guide/cli/overview.html | 1 +
user-guide/cli/usage.html | 1 +
user-guide/concepts-readings-events.html | 1 +
user-guide/configs.html | 1 +
user-guide/crate-configuration.html | 1 +
user-guide/dataframe.html | 1 +
user-guide/example-usage.html | 1 +
user-guide/explain-usage.html | 1 +
user-guide/expressions.html | 1 +
user-guide/faq.html | 1 +
user-guide/features.html | 1 +
user-guide/introduction.html | 1 +
user-guide/metrics.html | 1 +
user-guide/parquet-content-defined-chunking.html | 1 +
user-guide/sql/aggregate_functions.html | 1 +
user-guide/sql/data_types.html | 1 +
user-guide/sql/ddl.html | 1 +
user-guide/sql/dml.html | 1 +
user-guide/sql/explain.html | 1 +
user-guide/sql/format_options.html | 1 +
user-guide/sql/index.html | 1 +
user-guide/sql/information_schema.html | 1 +
user-guide/sql/operators.html | 1 +
user-guide/sql/prepared_statements.html | 1 +
user-guide/sql/scalar_functions.html | 1 +
user-guide/sql/select.html | 1 +
user-guide/sql/special_functions.html | 1 +
user-guide/sql/struct_coercion.html | 1 +
user-guide/sql/subqueries.html | 1 +
user-guide/sql/window_functions.html | 1 +
91 files changed, 557 insertions(+), 218 deletions(-)
diff --git a/_sources/contributor-guide/index.md.txt b/_sources/contributor-guide/index.md.txt
index 6ec1efa4d9..6f1a0f1c19 100644
--- a/_sources/contributor-guide/index.md.txt
+++ b/_sources/contributor-guide/index.md.txt
@@ -101,6 +101,11 @@ If you are concerned that a larger design will be lost in a string of small PRs,
Note all commits in a PR are squashed when merged to the `main` branch so there is one commit per PR after merge.
+For larger PRs, it is often helpful to leave a review on your own PR with
+comments calling out important changes or specific important choices. These
+annotations can help reviewers quickly find areas they should focus on, thus
+speeding up review.
+
## Release Management and Backports
Contributor-facing guidance for release branches, patch releases, and backports
@@ -135,22 +140,8 @@ do take priority over the conventional commit approach, allowing maintainers to
## Reviewing Pull Requests
-Some helpful links:
-
-- [PRs Waiting for Review] on GitHub
-- [Approved PRs Waiting for Merge] on GitHub
-
-[prs waiting for review]: https://github.com/apache/datafusion/pulls?q=is%3Apr+is%3Aopen+-review%3Aapproved+-is%3Adraft+
-[approved prs waiting for merge]: https://github.com/apache/datafusion/pulls?q=is%3Apr+is%3Aopen+review%3Aapproved+-is%3Adraft
-
-When reviewing PRs, our primary goal is to improve DataFusion and its community together. PR feedback should be constructive with the aim to help improve the code as well as the understanding of the contributor.
-
-Please ensure any issues you raise contains a rationale and suggested alternative -- it is frustrating to be told "don't do it this way" without any clear reason or alternate provided.
-
-Some things to specifically check:
-
-1. Is the feature or fix covered sufficiently with tests (see the [Testing](testing.md) section)?
-2. Is the code clear, and fits the style of the existing codebase?
+See the [Reviewing Pull Requests](pr_review.md) guide for what we look for
+when reviewing PRs and how to prepare your own for review.
## Performance Improvements
diff --git a/_sources/contributor-guide/pr_review.md.txt b/_sources/contributor-guide/pr_review.md.txt
new file mode 100644
index 0000000000..1154ae0e96
--- /dev/null
+++ b/_sources/contributor-guide/pr_review.md.txt
@@ -0,0 +1,240 @@
+<!---
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+# Reviewing Pull Requests
+
+When reviewing PRs, our primary goal is to improve DataFusion and its community
+together. PR feedback should be constructive and help improve the code as well
+as the understanding of the contributor.
+
+Review bandwidth is currently our most limited resource, and reviews from the
+broader community are both welcomed and encouraged. Reviewing PRs is a great way
+to learn the codebase, and you do not need to be a committer to leave valuable
+review feedback. In fact, one of the best ways to become a committer is to
+thoughtfully review other PRs.
+
+Please ensure any comments you leave contain a rationale and suggested
+alternative -- it is frustrating to be told "don't do it this way" without any
+clear reason or alternative provided.
+
+The criteria in this guide are also a useful checklist when preparing your own
+PR for review.
+
+## PR Review Mechanics
+
+Some helpful links:
+
+- [PRs Waiting for Review] on GitHub
+- [Approved PRs Waiting for Merge] on GitHub
+
+[prs waiting for review]: https://github.com/apache/datafusion/pulls?q=is%3Apr+is%3Aopen+-review%3Aapproved+-is%3Adraft+
+[approved prs waiting for merge]: https://github.com/apache/datafusion/pulls?q=is%3Apr+is%3Aopen+review%3Aapproved+-is%3Adraft
+
+The overall PR lifecycle (CI triggering, approval, the 24-hour rule for
+"major" PRs, and merging) is described in the
+[Pull Request Overview](index.md#pull-request-overview) section of the
+contributor guide.
+
+Practical tips:
+
+1. Check out the changes locally to explore them in your IDE or with an
+ agent, e.g. `gh pr checkout <PR number>` using the [GitHub CLI].
+2. There is normally no need to rerun locally any tests that CI has already run.
+3. Leave comments on specific lines of the diff where possible, so the
+ discussion has context.
+4. If you review a PR but don't feel confident approving it, leaving comments
+ is still valuable: a partial review (e.g. "I reviewed the tests and they
+ look good") helps the next reviewer focus their time.
+5. Anything that does not need to block the current PR can be noted as a
+ potential follow-up (ideally by filing an issue), keeping the PR focused
+ and quick to merge.
+
+[github cli]: https://cli.github.com/
+
+## Review the PR Description
+
+The PR description is often what users and contributors will find when they have
+a question about the intention behind a change, or when the code itself is not
+clear. The PR description also becomes the extended commit message.
+
+Check that the description:
+
+1. Concisely describes the **problem being solved from the user's point of
+ view**.
+
+2. Follows the [PR template], and answers the template's questions.
+
+3. Accurately describes the content of the PR, including any relevant context or
+ background.
+ Great descriptions have a high signal-to-noise ratio, summarizing
+ important implementation changes without repeating technical minutiae that
+ are already present in the code itself.
+
+4. Explicitly calls out any user-facing or API changes (see
+ [Review the Code](#review-the-code) below).
+
+[pr template]: https://github.com/apache/datafusion/blob/main/.github/pull_request_template.md
+
+## Review the Code Comments
+
+The goal of code comments is to help future readers of the code understand what
+is not obvious from reading the code itself. Great comments make the code easier
+to reason about for readers with the expected background, and help future
+maintainers.
+
+Some practical guidelines for reviewing comments:
+
+1. The code has adequate comments focused on the **rationale** for any
+ non-obvious change (the "why"), not a restatement of what the code does
+ (the "what"), which is typically clear from reading the code itself.
+2. Comments do not narrate irrelevant internal implementation details or the
+ history of how the change was developed (this is common in LLM-assisted
+ code, e.g. "// changed to use a HashMap" or "// this handles the case
+ mentioned above"). Such comments become irrelevant as soon as the PR merges.
+3. When comments refer to other structs, functions, or modules, they should use
+ [rustdoc intra-doc links] (e.g. `` [`SessionContext`] ``) rather than plain
+ text names, so that `cargo doc` link checking ensures the references stay
+ valid as the code evolves.
+4. New public APIs have doc comments, including examples where appropriate
+ (doc examples are also tested by CI, so they double as test coverage).
+5. When documenting modules, functions, or fields, start with simple examples
+ and intuitive explanations, and optionally add formal, math-like
+ definitions when necessary. This makes the implementation easier to reason
+ about.
+6. When something is confusing on first read, treat that as a good
+ opportunity to improve the comments.
+
+[rustdoc intra-doc links]: https://doc.rust-lang.org/rustdoc/write-documentation/linking-to-items-by-name.html
+
+## Review the Test Coverage
+
+Check that the feature or fix is covered sufficiently with tests (see the
+[Testing](testing.md) guide for more details): the PR should include tests for
+any new functionality, and a bug fix should include a test that reproduces the
+reported problem.
+
+Guidelines for evaluating tests:
+
+1. Prefer `sqllogictest` (`.slt`) tests or DataFrame API tests where
+ possible, as they exercise **user-visible behavior** and are less coupled
+ to internal implementation details than unit tests.
+2. Verify tests cover edge cases and common failure scenarios, not just the
+ common successful path. However, it is NOT necessary to test every possible
+ error path, especially if it is difficult to trigger or unlikely to occur in
+ practice.
+3. Verify test coverage of changed code using the `codecov` check on the PR,
+ or by running [`cargo llvm-cov`] locally for an HTML report. Use judgment
+ about any uncovered lines -- the goal is confidence in the change, not
+ slavishly hitting some coverage number.
+4. Avoid tests with lots of repeated boilerplate: when many tests share
+ near-identical setup, it is hard to understand what is different
+ (and thus what is actually being tested) between them. Make the _difference_
+ between cases obvious.
+5. Check that tests assert on specific expected values or plans (e.g. via
+ `insta` snapshots or `.slt` expected output) rather than merely checking
+ "no error occurred".
+6. Verify tests actually cover the bug ("Ablation Testing"): For bug fixes, revert
+ the fix locally and check that the new test fails without it (i.e. the test
+ actually reproduces the bug or covers the new feature).
+
+[`cargo llvm-cov`]: https://github.com/taiki-e/cargo-llvm-cov
+
+## Review the Code
+
+Check that:
+
+1. The code is clear and fits the style of the existing codebase.
+2. New functions and tests are placed near similar functions and
+ tests. For example, helper functions should be defined close to where they are used,
+ and new tests should be placed in the same module as the code they test.
+ SLT tests should be placed in an existing .slt file with related functionality,
+ unless the new tests are large enough to justify their own file.
+3. New APIs are consistent with existing public APIs and patterns; where a
+ similar mechanism already exists, the PR should extend it rather than
+ introduce a parallel one.
+4. Any changes to the public API follow the [API health policy].
+5. The change is appropriately scoped: unrelated refactoring, formatting
+ churn, or drive-by changes make review longer and are better as separate
+ PRs.
+6. New errors are actionable, mention the offending item, and use
+ the right error variant (e.g. `plan_err!` for user-triggerable errors vs
+ `internal_err!` for invariant violations).
+
+[api health policy]: api-health.md
+
+## Review the Performance
+
+Performance is a key feature of DataFusion. See [Performance Improvements](index.md#performance-improvements)
+for the project policy: an improvement should be "enough" to justify any
+added code complexity, and performance PRs should come with benchmark
+results.
+
+When reviewing:
+
+1. Find any relevant existing benchmarks and run them against `main`:
+ the [system-level SQL benchmarks] are run with `bench.sh` (see the
+ [benchmarks README]), and microbenchmarks (e.g. in
+ `datafusion/functions/benches`) are run with `cargo bench`.
+2. Be aware that benchmarking on a machine where other
+ work is being done will make results hard to reproduce. Prefer a quiet,
+ dedicated machine and repeated runs.
+3. If the PR claims a performance improvement, check that the reported
+ results are reproducible and that the benchmark exercises the changed
+ code path.
+
+[system-level sql benchmarks]: https://github.com/apache/datafusion/tree/main/benchmarks
+[benchmarks readme]: https://github.com/apache/datafusion/blob/main/benchmarks/README.md
+
+## Best Practices for Reviewers
+
+Here are some suggested best practices to follow when reviewing PRs.
+
+### Review Tone: Thank Contributors and Praise Good Work Specifically
+
+Open reviews by thanking the author by name, and when a PR is well done, say
+specifically what makes it good -- positive feedback encourages people to keep
+contributing and helps them understand what is valued in the project.
+
+### State Approval Conditions Explicitly
+
+If you are not ready to approve, list concretely what you would need to see
+before approving (e.g. "benchmark results and an upgrade guide entry") so
+the author has a clear path to merge.
+
+### Defer Non-Blocking Work to Follow-On Issues
+
+Explicitly defer non-critical suggestions to a follow-on PR and file
+(or ask the author to file) issues for them, so good PRs merge quickly
+without scope creep.
+
+Similarly, when a PR mixes refactoring with behavior changes or fixes a narrow
+problem with a broad mechanism, ask for it to be split or scoped down rather
+than reviewing it as-is.
+
+### Narrate What You Verified When Approving
+
+Rather than a bare "LGTM", say what you actually checked ("traced the state
+transitions by hand", "confirmed the hasher change cannot affect ordering")
+so it is clear what was verified and what was not.
+
+### Invite Additional Committers on Core Changes
+
+For changes to core, widely shared code, leave the PR open for other
+committers to look at and cc those who know the area, even after you have
+approved.
diff --git a/_sources/index.rst.txt b/_sources/index.rst.txt
index 0e3f56a7e1..ea6ebb74c0 100644
--- a/_sources/index.rst.txt
+++ b/_sources/index.rst.txt
@@ -159,6 +159,7 @@ To get started, see
:caption: Contributor Guide
contributor-guide/index
+ contributor-guide/pr_review
contributor-guide/communication
contributor-guide/development_environment
contributor-guide/architecture
diff --git a/contributor-guide/api-health.html b/contributor-guide/api-health.html
index 5c0265ba85..e180828005 100644
--- a/contributor-guide/api-health.html
+++ b/contributor-guide/api-health.html
@@ -338,6 +338,7 @@
<ul class="current nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="architecture.html">Architecture</a></li>
diff --git a/contributor-guide/architecture.html b/contributor-guide/architecture.html
index e688fe2f8a..62ff4001b8 100644
--- a/contributor-guide/architecture.html
+++ b/contributor-guide/architecture.html
@@ -338,6 +338,7 @@
<ul class="current nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="development_environment.html">Development Environment</a></li>
<li class="toctree-l1 current active"><a class="current reference internal" href="#">Architecture</a></li>
diff --git a/contributor-guide/architecture/dependency-graph.html b/contributor-guide/architecture/dependency-graph.html
index c261f235b1..814486667b 100644
--- a/contributor-guide/architecture/dependency-graph.html
+++ b/contributor-guide/architecture/dependency-graph.html
@@ -338,6 +338,7 @@
<ul class="current nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../architecture.html">Architecture</a></li>
diff --git a/contributor-guide/communication.html b/contributor-guide/communication.html
index 73cd30c0c6..c0aac49687 100644
--- a/contributor-guide/communication.html
+++ b/contributor-guide/communication.html
@@ -48,7 +48,7 @@
<link rel="index" title="Index" href="../genindex.html" />
<link rel="search" title="Search" href="../search.html" />
<link rel="next" title="Development Environment" href="development_environment.html" />
- <link rel="prev" title="Introduction" href="index.html" />
+ <link rel="prev" title="Reviewing Pull Requests" href="pr_review.html" />
<meta name="viewport" content="width=device-width, initial-scale=1"/>
<meta name="docsearch:language" content="en"/>
<meta name="docsearch:version" content="" />
@@ -338,6 +338,7 @@
<ul class="current nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1 current active"><a class="current reference internal" href="#">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="architecture.html">Architecture</a></li>
@@ -539,12 +540,12 @@ mailing list for release coordination and other project-wide discussions. Links:
<div class="prev-next-area">
<a class="left-prev"
- href="index.html"
+ href="pr_review.html"
title="previous page">
<i class="fa-solid fa-angle-left"></i>
<div class="prev-next-info">
<p class="prev-next-subtitle">previous</p>
- <p class="prev-next-title">Introduction</p>
+ <p class="prev-next-title">Reviewing Pull Requests</p>
</div>
</a>
<a class="right-next"
diff --git a/contributor-guide/development_environment.html b/contributor-guide/development_environment.html
index e04ba7bd6b..15a5f563f8 100644
--- a/contributor-guide/development_environment.html
+++ b/contributor-guide/development_environment.html
@@ -338,6 +338,7 @@
<ul class="current nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="communication.html">Community Communication</a></li>
<li class="toctree-l1 current active"><a class="current reference internal" href="#">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="architecture.html">Architecture</a></li>
diff --git a/contributor-guide/governance.html b/contributor-guide/governance.html
index 269bdc5e40..583c68a2e4 100644
--- a/contributor-guide/governance.html
+++ b/contributor-guide/governance.html
@@ -338,6 +338,7 @@
<ul class="current nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="architecture.html">Architecture</a></li>
diff --git a/contributor-guide/gsoc/gsoc_application_guidelines_2025.html b/contributor-guide/gsoc/gsoc_application_guidelines_2025.html
index d20124f215..2133bf56ba 100644
--- a/contributor-guide/gsoc/gsoc_application_guidelines_2025.html
+++ b/contributor-guide/gsoc/gsoc_application_guidelines_2025.html
@@ -338,6 +338,7 @@
<ul class="current nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../architecture.html">Architecture</a></li>
diff --git a/contributor-guide/gsoc/gsoc_project_ideas_2025.html b/contributor-guide/gsoc/gsoc_project_ideas_2025.html
index 4d63a90dc8..98d2941554 100644
--- a/contributor-guide/gsoc/gsoc_project_ideas_2025.html
+++ b/contributor-guide/gsoc/gsoc_project_ideas_2025.html
@@ -337,6 +337,7 @@
<ul class="current nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../architecture.html">Architecture</a></li>
diff --git a/contributor-guide/gsoc/index.html b/contributor-guide/gsoc/index.html
index 2841adb1b9..72484bd285 100644
--- a/contributor-guide/gsoc/index.html
+++ b/contributor-guide/gsoc/index.html
@@ -338,6 +338,7 @@
<ul class="current nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../architecture.html">Architecture</a></li>
diff --git a/contributor-guide/howtos.html b/contributor-guide/howtos.html
index 7f55efc5a1..6aa79a793e 100644
--- a/contributor-guide/howtos.html
+++ b/contributor-guide/howtos.html
@@ -338,6 +338,7 @@
<ul class="current nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="architecture.html">Architecture</a></li>
diff --git a/contributor-guide/index.html b/contributor-guide/index.html
index b38b59c78f..34ec069e2a 100644
--- a/contributor-guide/index.html
+++ b/contributor-guide/index.html
@@ -47,7 +47,7 @@
<link rel="icon" href="../_static/favicon.svg"/>
<link rel="index" title="Index" href="../genindex.html" />
<link rel="search" title="Search" href="../search.html" />
- <link rel="next" title="Community Communication" href="communication.html" />
+ <link rel="next" title="Reviewing Pull Requests" href="pr_review.html" />
<link rel="prev" title="Query Optimizer" href="../library-user-guide/query-optimizer.html" />
<meta name="viewport" content="width=device-width, initial-scale=1"/>
<meta name="docsearch:language" content="en"/>
@@ -338,6 +338,7 @@
<ul class="current nav bd-sidenav">
<li class="toctree-l1 current active"><a class="current reference internal" href="#">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="architecture.html">Architecture</a></li>
@@ -514,6 +515,10 @@ committer who approved your PR to help remind them to merge it.</p>
</ol>
<p>If you are concerned that a larger design will be lost in a string of small PRs, creating a large draft PR that shows how they all work together can help.</p>
<p>Note all commits in a PR are squashed when merged to the <code class="docutils literal notranslate"><span class="pre">main</span></code> branch so there is one commit per PR after merge.</p>
+<p>For larger PRs, it is often helpful to leave a review on your own PR with
+comments calling out important changes or specific important choices. These
+annotations can help reviewers quickly find areas they should focus on, thus
+speeding up review.</p>
</section>
<section id="release-management-and-backports">
<h2>Release Management and Backports<a class="headerlink" href="#release-management-and-backports" title="Link to this heading">#</a></h2>
@@ -543,18 +548,8 @@ do take priority over the conventional commit approach, allowing maintainers to
</section>
<section id="reviewing-pull-requests">
<h2>Reviewing Pull Requests<a class="headerlink" href="#reviewing-pull-requests" title="Link to this heading">#</a></h2>
-<p>Some helpful links:</p>
-<ul class="simple">
-<li><p><a class="reference external" href="https://github.com/apache/datafusion/pulls?q=is%3Apr+is%3Aopen+-review%3Aapproved+-is%3Adraft+">PRs Waiting for Review</a> on GitHub</p></li>
-<li><p><a class="reference external" href="https://github.com/apache/datafusion/pulls?q=is%3Apr+is%3Aopen+review%3Aapproved+-is%3Adraft">Approved PRs Waiting for Merge</a> on GitHub</p></li>
-</ul>
-<p>When reviewing PRs, our primary goal is to improve DataFusion and its community together. PR feedback should be constructive with the aim to help improve the code as well as the understanding of the contributor.</p>
-<p>Please ensure any issues you raise contains a rationale and suggested alternative – it is frustrating to be told “don’t do it this way” without any clear reason or alternate provided.</p>
-<p>Some things to specifically check:</p>
-<ol class="arabic simple">
-<li><p>Is the feature or fix covered sufficiently with tests (see the <a class="reference internal" href="testing.html"><span class="std std-doc">Testing</span></a> section)?</p></li>
-<li><p>Is the code clear, and fits the style of the existing codebase?</p></li>
-</ol>
+<p>See the <a class="reference internal" href="pr_review.html"><span class="std std-doc">Reviewing Pull Requests</span></a> guide for what we look for
+when reviewing PRs and how to prepare your own for review.</p>
</section>
<section id="performance-improvements">
<h2>Performance Improvements<a class="headerlink" href="#performance-improvements" title="Link to this heading">#</a></h2>
@@ -663,11 +658,11 @@ Commenting on the PR will remove the <code class="docutils literal notranslate">
</div>
</a>
<a class="right-next"
- href="communication.html"
+ href="pr_review.html"
title="next page">
<div class="prev-next-info">
<p class="prev-next-subtitle">next</p>
- <p class="prev-next-title">Community Communication</p>
+ <p class="prev-next-title">Reviewing Pull Requests</p>
</div>
<i class="fa-solid fa-angle-right"></i>
</a>
diff --git a/contributor-guide/inviting.html b/contributor-guide/inviting.html
index bf857cd756..10d6879f1f 100644
--- a/contributor-guide/inviting.html
+++ b/contributor-guide/inviting.html
@@ -338,6 +338,7 @@
<ul class="current nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="architecture.html">Architecture</a></li>
diff --git a/contributor-guide/release_management.html b/contributor-guide/pr_review.html
similarity index 62%
copy from contributor-guide/release_management.html
copy to contributor-guide/pr_review.html
index cf647104cc..c364006d55 100644
--- a/contributor-guide/release_management.html
+++ b/contributor-guide/pr_review.html
@@ -8,7 +8,7 @@
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" /><meta name="viewport" content="width=device-width, initial-scale=1" />
- <title>Release Management — Apache DataFusion documentation</title>
+ <title>Reviewing Pull Requests — Apache DataFusion documentation</title>
@@ -42,13 +42,13 @@
<script src="../_static/documentation_options.js?v=5929fcd5"></script>
<script src="../_static/doctools.js?v=fd6eb6e6"></script>
<script src="../_static/sphinx_highlight.js?v=6ffebe34"></script>
- <script>DOCUMENTATION_OPTIONS.pagename = 'contributor-guide/release_management';</script>
+ <script>DOCUMENTATION_OPTIONS.pagename = 'contributor-guide/pr_review';</script>
<script>DOCUMENTATION_OPTIONS.search_as_you_type = false;</script>
<link rel="icon" href="../_static/favicon.svg"/>
<link rel="index" title="Index" href="../genindex.html" />
<link rel="search" title="Search" href="../search.html" />
- <link rel="next" title="Roadmap and Improvement Proposals" href="roadmap.html" />
- <link rel="prev" title="HOWTOs" href="howtos.html" />
+ <link rel="next" title="Community Communication" href="communication.html" />
+ <link rel="prev" title="Introduction" href="index.html" />
<meta name="viewport" content="width=device-width, initial-scale=1"/>
<meta name="docsearch:language" content="en"/>
<meta name="docsearch:version" content="" />
@@ -338,6 +338,7 @@
<ul class="current nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="index.html">Introduction</a></li>
+<li class="toctree-l1 current active"><a class="current reference internal" href="#">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="architecture.html">Architecture</a></li>
@@ -345,7 +346,7 @@
<li class="toctree-l1"><a class="reference internal" href="testing.html">Testing</a></li>
<li class="toctree-l1"><a class="reference internal" href="api-health.html">API health policy</a></li>
<li class="toctree-l1"><a class="reference internal" href="howtos.html">HOWTOs</a></li>
-<li class="toctree-l1 current active"><a class="current reference internal" href="#">Release Management</a></li>
+<li class="toctree-l1"><a class="reference internal" href="release_management.html">Release Management</a></li>
<li class="toctree-l1"><a class="reference internal" href="roadmap.html">Roadmap and Improvement Proposals</a></li>
<li class="toctree-l1"><a class="reference internal" href="governance.html">Governance</a></li>
<li class="toctree-l1"><a class="reference internal" href="inviting.html">Inviting New Committers and PMC Members</a></li>
@@ -408,7 +409,7 @@
<i class="fa-solid fa-home"></i>
</a>
</li>
- <li class="breadcrumb-item active" aria-current="page"><span class="ellipsis">Release Management</span></li>
+ <li class="breadcrumb-item active" aria-current="page"><span class="ellipsis">Reviewing Pull Requests</span></li>
</ul>
</nav>
</div>
@@ -443,175 +444,203 @@
specific language governing permissions and limitations
under the License.
-->
-<section id="release-management">
-<h1>Release Management<a class="headerlink" href="#release-management" title="Link to this heading">#</a></h1>
-<p>This page describes DataFusion release branches and backports. For the
-maintainer release guide, including release candidate artifacts, voting, and
-publication, see <a class="reference external" href="https://github.com/apache/datafusion/blob/main/dev/release/README.md">the release process README in <code class="docutils literal notranslate"><span class="pre">dev/release</span></code></a>.</p>
-<section id="overview">
-<h2>Overview<a class="headerlink" href="#overview" title="Link to this heading">#</a></h2>
-<p>DataFusion typically has a major release about once per month, including
-breaking API changes. Patch releases are made on an ad hoc basis, but we try to
-avoid them because major releases are frequent.</p>
-<p>New development happens on the <a class="reference external" href="https://github.com/apache/datafusion/tree/main"><code class="docutils literal notranslate"><span class="pre">main</span></code> branch</a>. Releases are made from release
-branches named <code class="docutils literal notranslate"><span class="pre">branch-NN</span></code>, such as <a class="reference external" href="https://github.com/apache/datafusion/tree/branch-50"><code class="docutils literal notranslate"><span class="pre">branch-50</span></code></a> for the <code class="docutils literal notranslate"><span class="pre">50.x.y</span></code> release
-series.</p>
-<p>In general:</p>
+<section id="reviewing-pull-requests">
+<h1>Reviewing Pull Requests<a class="headerlink" href="#reviewing-pull-requests" title="Link to this heading">#</a></h1>
+<p>When reviewing PRs, our primary goal is to improve DataFusion and its community
+together. PR feedback should be constructive and help improve the code as well
+as the understanding of the contributor.</p>
+<p>Review bandwidth is currently our most limited resource, and reviews from the
+broader community are both welcomed and encouraged. Reviewing PRs is a great way
+to learn the codebase, and you do not need to be a committer to leave valuable
+review feedback. In fact, one of the best ways to become a committer is to
+thoughtfully review other PRs.</p>
+<p>Please ensure any comments you leave contain a rationale and suggested
+alternative – it is frustrating to be told “don’t do it this way” without any
+clear reason or alternative provided.</p>
+<p>The criteria in this guide are also a useful checklist when preparing your own
+PR for review.</p>
+<section id="pr-review-mechanics">
+<h2>PR Review Mechanics<a class="headerlink" href="#pr-review-mechanics" title="Link to this heading">#</a></h2>
+<p>Some helpful links:</p>
<ul class="simple">
-<li><p>New features land on [<code class="docutils literal notranslate"><span class="pre">main</span></code>]</p></li>
-<li><p>Patch releases are cut from the corresponding <code class="docutils literal notranslate"><span class="pre">branch-NN</span></code></p></li>
-<li><p>Only targeted, low-risk fixes should be added to a release branch</p></li>
-</ul>
-<p>Changes reach a release branch in one of two ways:</p>
-<ul class="simple">
-<li><p>(Most common) Fix the issue on <code class="docutils literal notranslate"><span class="pre">main</span></code> and then backport the merged change to the release branch</p></li>
-<li><p>Fix the issue on the release branch and then forward-port the change to <code class="docutils literal notranslate"><span class="pre">main</span></code></p></li>
-</ul>
-<p>Releases are coordinated using GitHub issues. Each planned release is listed in
-the <a class="reference external" href="https://github.com/apache/datafusion/issues/19783">DataFusion Releases tracking issue</a>, and each release is coordinated in a
-dedicated issue, such as the <a class="reference external" href="https://github.com/apache/datafusion/issues/18072">release issue for 50.3.0</a>. If you think a fix
-should be included in a patch release, discuss it on the relevant tracking issue
-or open a backport PR and link it there.</p>
-<p>To prepare for a new release series, maintainers:</p>
-<ul class="simple">
-<li><p>Create a new branch from <code class="docutils literal notranslate"><span class="pre">main</span></code>, such as <code class="docutils literal notranslate"><span class="pre">branch-50</span></code>, in the Apache repository</p></li>
-<li><p>Continue merging new features to <code class="docutils literal notranslate"><span class="pre">main</span></code></p></li>
-<li><p>Prepare the release branch for release by updating versions, changelog content,
-and any additional release-specific fixes via the
-<a class="reference internal" href="#backport-workflow">Backport Workflow</a></p></li>
-<li><p>Create release candidate artifacts from the release branch</p></li>
-<li><p>After approval, publish to crates.io, ASF distribution servers, and Git tags</p></li>
-</ul>
-</section>
-<section id="backport-criteria">
-<h2>Backport Criteria<a class="headerlink" href="#backport-criteria" title="Link to this heading">#</a></h2>
-<p>A release branch is a stabilization branch for an imminent or recent patch
-release. The bar for landing a change on a release branch is therefore
-<em>higher</em> than the bar for landing on <code class="docutils literal notranslate"><span class="pre">main</span></code>, not lower. These criteria define
-what is eligible for backport; the <a class="reference internal" href="#backport-workflow">Backport Workflow</a>
-below describes the mechanics.</p>
-<p>DataFusion follows Cargo SemVer, with breaking changes allowed at major
-version boundaries — see the <a class="reference internal" href="api-health.html"><span class="std std-doc">API health policy</span></a> for the full framing of
-public Rust and SQL API stability. Patch releases (<code class="docutils literal notranslate"><span class="pre">x.y.z</span></code>, <code class="docutils literal notranslate"><span class="pre">z</span> <span class="pre">≥</span> <span class="pre">1</span></code>) carry
-fixes only and never introduce new features or breaking changes.</p>
-<section id="eligible-for-backport">
-<h3>Eligible for backport<a class="headerlink" href="#eligible-for-backport" title="Link to this heading">#</a></h3>
-<ul class="simple">
-<li><p><strong>Security fixes.</strong> Fixes for known or reported security issues should be
-backported to every actively maintained release branch.</p></li>
-<li><p><strong>Correctness fixes.</strong> Fixes for queries that produce incorrect results,
-panics, data loss, or crashes. If the fix itself changes user-visible SQL
-semantics to make a wrong result right, follow <a class="reference internal" href="#behavior-changes">Behavior changes</a> below.</p></li>
-<li><p><strong>Stability and regression fixes.</strong> Fixes for regressions introduced in the
-current release line, hangs, deadlocks, memory leaks, or other availability
-issues.</p></li>
-<li><p><strong>Build, CI, and test fixes</strong> required to keep the branch buildable and
-releasable.</p></li>
-<li><p><strong>Documentation fixes</strong> for behavior already in the release. Documentation
-for behavior that exists only on <code class="docutils literal notranslate"><span class="pre">main</span></code> does not belong on a release branch.</p></li>
-</ul>
-</section>
-<section id="not-recommended-for-backport">
-<h3>Not recommended for backport<a class="headerlink" href="#not-recommended-for-backport" title="Link to this heading">#</a></h3>
-<ul class="simple">
-<li><p><strong>New features</strong>, including new SQL functions, new optimizer rules, new
-configuration options, new public APIs, and new file-format support. Land
-on <code class="docutils literal notranslate"><span class="pre">main</span></code> and ship in the next major release.</p></li>
-<li><p><strong>Breaking API changes</strong> of any kind, Rust or SQL. DataFusion makes
-breaking changes only at major version boundaries — see <a class="reference internal" href="api-health.html"><span class="std std-doc">API health policy</span></a>.</p></li>
-<li><p><strong>Refactors and cleanup</strong> that do not fix a bug, even if they are correct.</p></li>
-<li><p><strong>Performance improvements</strong> that are not also correctness or stability
-fixes. Land on <code class="docutils literal notranslate"><span class="pre">main</span></code>.</p></li>
-<li><p><strong>Dependency upgrades</strong>, except when the upgrade itself is the security or
-correctness fix and there is no narrower alternative.</p></li>
+<li><p><a class="reference external" href="https://github.com/apache/datafusion/pulls?q=is%3Apr+is%3Aopen+-review%3Aapproved+-is%3Adraft+">PRs Waiting for Review</a> on GitHub</p></li>
+<li><p><a class="reference external" href="https://github.com/apache/datafusion/pulls?q=is%3Apr+is%3Aopen+review%3Aapproved+-is%3Adraft">Approved PRs Waiting for Merge</a> on GitHub</p></li>
</ul>
+<p>The overall PR lifecycle (CI triggering, approval, the 24-hour rule for
+“major” PRs, and merging) is described in the
+<a class="reference internal" href="index.html#pull-request-overview"><span class="std std-ref">Pull Request Overview</span></a> section of the
+contributor guide.</p>
+<p>Practical tips:</p>
+<ol class="arabic simple">
+<li><p>Check out the changes locally to explore them in your IDE or with an
+agent, e.g. <code class="docutils literal notranslate"><span class="pre">gh</span> <span class="pre">pr</span> <span class="pre">checkout</span> <span class="pre"><PR</span> <span class="pre">number></span></code> using the <a class="reference external" href="https://cli.github.com/">GitHub CLI</a>.</p></li>
+<li><p>There is normally no need to rerun locally any tests that CI has already run.</p></li>
+<li><p>Leave comments on specific lines of the diff where possible, so the
+discussion has context.</p></li>
+<li><p>If you review a PR but don’t feel confident approving it, leaving comments
+is still valuable: a partial review (e.g. “I reviewed the tests and they
+look good”) helps the next reviewer focus their time.</p></li>
+<li><p>Anything that does not need to block the current PR can be noted as a
+potential follow-up (ideally by filing an issue), keeping the PR focused
+and quick to merge.</p></li>
+</ol>
</section>
-<section id="behavior-changes">
-<h3>Behavior changes<a class="headerlink" href="#behavior-changes" title="Link to this heading">#</a></h3>
-<p>A “behavior change” is any fix that alters user-visible results: SQL
-semantics (values, ordering, types, null handling), error messages that
-downstream users may rely on, plan output, or default configuration values.</p>
-<p>Behavior-changing fixes need extra scrutiny on a release branch because
-users upgrading between patch versions do not expect their queries to start
-returning different results. When proposing one for backport, state on the
-release tracking issue <em>why</em> the change should ship in this patch release
-rather than wait for the next major. The previous and new behavior should
-already be documented on the original issue or PR — link to that rather
-than restating it.</p>
-<p>If in doubt, default to “land on <code class="docutils literal notranslate"><span class="pre">main</span></code>, ship in the next major.”</p>
+<section id="review-the-pr-description">
+<h2>Review the PR Description<a class="headerlink" href="#review-the-pr-description" title="Link to this heading">#</a></h2>
+<p>The PR description is often what users and contributors will find when they have
+a question about the intention behind a change, or when the code itself is not
+clear. The PR description also becomes the extended commit message.</p>
+<p>Check that the description:</p>
+<ol class="arabic simple">
+<li><p>Concisely describes the <strong>problem being solved from the user’s point of
+view</strong>.</p></li>
+<li><p>Follows the <a class="reference external" href="https://github.com/apache/datafusion/blob/main/.github/pull_request_template.md">PR template</a>, and answers the template’s questions.</p></li>
+<li><p>Accurately describes the content of the PR, including any relevant context or
+background.
+Great descriptions have a high signal-to-noise ratio, summarizing
+important implementation changes without repeating technical minutiae that
+are already present in the code itself.</p></li>
+<li><p>Explicitly calls out any user-facing or API changes (see
+<a class="reference internal" href="#review-the-code">Review the Code</a> below).</p></li>
+</ol>
</section>
-<section id="who-decides">
-<h3>Who decides<a class="headerlink" href="#who-decides" title="Link to this heading">#</a></h3>
-<p>The release manager for the active release line is the final reviewer of
-what goes into the patch release. They coordinate via the release tracking
-issue (for example, the <a class="reference external" href="https://github.com/apache/datafusion/issues/18072">release issue for 50.3.0</a>). Anyone may propose a
-backport by opening a backport PR and linking it from the tracking issue;
-inclusion is the release manager’s call.</p>
+<section id="review-the-code-comments">
+<h2>Review the Code Comments<a class="headerlink" href="#review-the-code-comments" title="Link to this heading">#</a></h2>
+<p>The goal of code comments is to help future readers of the code understand what
+is not obvious from reading the code itself. Great comments make the code easier
+to reason about for readers with the expected background, and help future
+maintainers.</p>
+<p>Some practical guidelines for reviewing comments:</p>
+<ol class="arabic simple">
+<li><p>The code has adequate comments focused on the <strong>rationale</strong> for any
+non-obvious change (the “why”), not a restatement of what the code does
+(the “what”), which is typically clear from reading the code itself.</p></li>
+<li><p>Comments do not narrate irrelevant internal implementation details or the
+history of how the change was developed (this is common in LLM-assisted
+code, e.g. “// changed to use a HashMap” or “// this handles the case
+mentioned above”). Such comments become irrelevant as soon as the PR merges.</p></li>
+<li><p>When comments refer to other structs, functions, or modules, they should use
+<a class="reference external" href="https://doc.rust-lang.org/rustdoc/write-documentation/linking-to-items-by-name.html">rustdoc intra-doc links</a> (e.g. <code class="docutils literal notranslate"><span class="pre">[`SessionContext`]</span></code>) rather than plain
+text names, so that <code class="docutils literal notranslate"><span class="pre">cargo</span> <span class="pre">doc</span></code> link checking ensures the references stay
+valid as the code evolves.</p></li>
+<li><p>New public APIs have doc comments, including examples where appropriate
+(doc examples are also tested by CI, so they double as test coverage).</p></li>
+<li><p>When documenting modules, functions, or fields, start with simple examples
+and intuitive explanations, and optionally add formal, math-like
+definitions when necessary. This makes the implementation easier to reason
+about.</p></li>
+<li><p>When something is confusing on first read, treat that as a good
+opportunity to improve the comments.</p></li>
+</ol>
</section>
-<section id="active-release-branches">
-<h3>Active release branches<a class="headerlink" href="#active-release-branches" title="Link to this heading">#</a></h3>
-<p>DataFusion does not maintain Long-Term Support branches. In general only the
-most recent <code class="docutils literal notranslate"><span class="pre">branch-NN</span></code> is actively maintained for backports, but if you need
-fixes in older releases, we are open to discussion.</p>
-<p>Security fixes are an exception: a maintainer may choose to backport a
-critical security fix to an older branch even after it would otherwise be
-closed. Discuss on the dev list or in a tracking issue before doing so.</p>
+<section id="review-the-test-coverage">
+<h2>Review the Test Coverage<a class="headerlink" href="#review-the-test-coverage" title="Link to this heading">#</a></h2>
+<p>Check that the feature or fix is covered sufficiently with tests (see the
+<a class="reference internal" href="testing.html"><span class="std std-doc">Testing</span></a> guide for more details): the PR should include tests for
+any new functionality, and a bug fix should include a test that reproduces the
+reported problem.</p>
+<p>Guidelines for evaluating tests:</p>
+<ol class="arabic simple">
+<li><p>Prefer <code class="docutils literal notranslate"><span class="pre">sqllogictest</span></code> (<code class="docutils literal notranslate"><span class="pre">.slt</span></code>) tests or DataFrame API tests where
+possible, as they exercise <strong>user-visible behavior</strong> and are less coupled
+to internal implementation details than unit tests.</p></li>
+<li><p>Verify tests cover edge cases and common failure scenarios, not just the
+common successful path. However, it is NOT necessary to test every possible
+error path, especially if it is difficult to trigger or unlikely to occur in
+practice.</p></li>
+<li><p>Verify test coverage of changed code using the <code class="docutils literal notranslate"><span class="pre">codecov</span></code> check on the PR,
+or by running <a class="reference external" href="https://github.com/taiki-e/cargo-llvm-cov"><code class="docutils literal notranslate"><span class="pre">cargo</span> <span class="pre">llvm-cov</span></code></a> locally for an HTML report. Use judgment
+about any uncovered lines – the goal is confidence in the change, not
+slavishly hitting some coverage number.</p></li>
+<li><p>Avoid tests with lots of repeated boilerplate: when many tests share
+near-identical setup, it is hard to understand what is different
+(and thus what is actually being tested) between them. Make the <em>difference</em>
+between cases obvious.</p></li>
+<li><p>Check that tests assert on specific expected values or plans (e.g. via
+<code class="docutils literal notranslate"><span class="pre">insta</span></code> snapshots or <code class="docutils literal notranslate"><span class="pre">.slt</span></code> expected output) rather than merely checking
+“no error occurred”.</p></li>
+<li><p>Verify tests actually cover the bug (“Ablation Testing”): For bug fixes, revert
+the fix locally and check that the new test fails without it (i.e. the test
+actually reproduces the bug or covers the new feature).</p></li>
+</ol>
</section>
+<section id="review-the-code">
+<h2>Review the Code<a class="headerlink" href="#review-the-code" title="Link to this heading">#</a></h2>
+<p>Check that:</p>
+<ol class="arabic simple">
+<li><p>The code is clear and fits the style of the existing codebase.</p></li>
+<li><p>New functions and tests are placed near similar functions and
+tests. For example, helper functions should be defined close to where they are used,
+and new tests should be placed in the same module as the code they test.
+SLT tests should be placed in an existing .slt file with related functionality,
+unless the new tests are large enough to justify their own file.</p></li>
+<li><p>New APIs are consistent with existing public APIs and patterns; where a
+similar mechanism already exists, the PR should extend it rather than
+introduce a parallel one.</p></li>
+<li><p>Any changes to the public API follow the <a class="reference internal" href="api-health.html"><span class="std std-doc">API health policy</span></a>.</p></li>
+<li><p>The change is appropriately scoped: unrelated refactoring, formatting
+churn, or drive-by changes make review longer and are better as separate
+PRs.</p></li>
+<li><p>New errors are actionable, mention the offending item, and use
+the right error variant (e.g. <code class="docutils literal notranslate"><span class="pre">plan_err!</span></code> for user-triggerable errors vs
+<code class="docutils literal notranslate"><span class="pre">internal_err!</span></code> for invariant violations).</p></li>
+</ol>
</section>
-<section id="backport-workflow">
-<h2>Backport Workflow<a class="headerlink" href="#backport-workflow" title="Link to this heading">#</a></h2>
-<p>The usual workflow is:</p>
+<section id="review-the-performance">
+<h2>Review the Performance<a class="headerlink" href="#review-the-performance" title="Link to this heading">#</a></h2>
+<p>Performance is a key feature of DataFusion. See <a class="reference internal" href="index.html#performance-improvements"><span class="std std-ref">Performance Improvements</span></a>
+for the project policy: an improvement should be “enough” to justify any
+added code complexity, and performance PRs should come with benchmark
+results.</p>
+<p>When reviewing:</p>
<ol class="arabic simple">
-<li><p>Fix on <code class="docutils literal notranslate"><span class="pre">main</span></code> first, and merge the fix via a normal PR workflow.</p></li>
-<li><p>Cherry-pick the merged commit onto the release branch.</p></li>
-<li><p>Open a backport PR targeting the release branch (examples below).</p></li>
+<li><p>Find any relevant existing benchmarks and run them against <code class="docutils literal notranslate"><span class="pre">main</span></code>:
+the <a class="reference external" href="https://github.com/apache/datafusion/tree/main/benchmarks">system-level SQL benchmarks</a> are run with <code class="docutils literal notranslate"><span class="pre">bench.sh</span></code> (see the
+<a class="reference external" href="https://github.com/apache/datafusion/blob/main/benchmarks/README.md">benchmarks README</a>), and microbenchmarks (e.g. in
+<code class="docutils literal notranslate"><span class="pre">datafusion/functions/benches</span></code>) are run with <code class="docutils literal notranslate"><span class="pre">cargo</span> <span class="pre">bench</span></code>.</p></li>
+<li><p>Be aware that benchmarking on a machine where other
+work is being done will make results hard to reproduce. Prefer a quiet,
+dedicated machine and repeated runs.</p></li>
+<li><p>If the PR claims a performance improvement, check that the reported
+results are reproducible and that the benchmark exercises the changed
+code path.</p></li>
</ol>
-<ul class="simple">
-<li><p><a class="reference external" href="https://github.com/apache/datafusion/pull/18131">Example backport PR</a></p></li>
-<li><p><a class="reference external" href="https://github.com/apache/datafusion/pull/20792">Additional backport PR example</a></p></li>
-</ul>
-<section id="inputs">
-<h3>Inputs<a class="headerlink" href="#inputs" title="Link to this heading">#</a></h3>
-<p>To backport a change, gather the following information:</p>
-<ul class="simple">
-<li><p>Target branch, such as <code class="docutils literal notranslate"><span class="pre">apache/branch-52</span></code></p></li>
-<li><p>The release tracking issue URL, such as https://github.com/apache/datafusion/issues/19692</p></li>
-<li><p>The original PR URL, such as https://github.com/apache/datafusion/pull/20192</p></li>
-<li><p>Optional explicit commit SHA to backport</p></li>
-</ul>
</section>
-<section id="apply-the-backport">
-<h3>Apply the Backport<a class="headerlink" href="#apply-the-backport" title="Link to this heading">#</a></h3>
-<p>Start from the target release branch, create a dedicated backport branch, and
-use <code class="docutils literal notranslate"><span class="pre">git</span> <span class="pre">cherry-pick</span></code>. For example, to backport PR #1234 to <code class="docutils literal notranslate"><span class="pre">branch-52</span></code> when
-the commit SHA is <code class="docutils literal notranslate"><span class="pre">abc123</span></code>, run:</p>
-<div class="highlight-bash notranslate"><div class="highlight"><pre><span></span>git<span class="w"> </span>checkout<span class="w"> </span>apache/branch-52
-git<span class="w"> </span>checkout<span class="w"> </span>-b<span class="w"> </span>alamb/backport_1234
-git<span class="w"> </span>cherry-pick<span class="w"> </span>abc123
-</pre></div>
-</div>
+<section id="best-practices-for-reviewers">
+<h2>Best Practices for Reviewers<a class="headerlink" href="#best-practices-for-reviewers" title="Link to this heading">#</a></h2>
+<p>Here are some suggested best practices to follow when reviewing PRs.</p>
+<section id="review-tone-thank-contributors-and-praise-good-work-specifically">
+<h3>Review Tone: Thank Contributors and Praise Good Work Specifically<a class="headerlink" href="#review-tone-thank-contributors-and-praise-good-work-specifically" title="Link to this heading">#</a></h3>
+<p>Open reviews by thanking the author by name, and when a PR is well done, say
+specifically what makes it good – positive feedback encourages people to keep
+contributing and helps them understand what is valued in the project.</p>
</section>
-<section id="test">
-<h3>Test<a class="headerlink" href="#test" title="Link to this heading">#</a></h3>
-<p>Run tests as described in the <a class="reference internal" href="testing.html"><span class="std std-doc">testing documentation</span></a>.</p>
+<section id="state-approval-conditions-explicitly">
+<h3>State Approval Conditions Explicitly<a class="headerlink" href="#state-approval-conditions-explicitly" title="Link to this heading">#</a></h3>
+<p>If you are not ready to approve, list concretely what you would need to see
+before approving (e.g. “benchmark results and an upgrade guide entry”) so
+the author has a clear path to merge.</p>
</section>
-<section id="open-the-pr">
-<h3>Open the PR<a class="headerlink" href="#open-the-pr" title="Link to this heading">#</a></h3>
-<p>Create a PR against the release branch, not <code class="docutils literal notranslate"><span class="pre">main</span></code>, and prefix it with
-<code class="docutils literal notranslate"><span class="pre">[branch-NN]</span></code> to show which release branch the backport targets. For example:</p>
-<ul class="simple">
-<li><p><code class="docutils literal notranslate"><span class="pre">[branch-52]</span> <span class="pre">fix:</span> <span class="pre">validate</span> <span class="pre">inter-file</span> <span class="pre">ordering</span> <span class="pre">in</span> <span class="pre">eq_properties()</span> <span class="pre">(#20329)</span></code></p></li>
-</ul>
-<p>Use a PR description that links the tracking issue, original PR, and target
-branch, for example:</p>
-<div class="highlight-markdown notranslate"><div class="highlight"><pre><span></span><span class="k">-</span><span class="w"> </span>Part of <tracking-issue-url>
-<span class="k">-</span><span class="w"> </span>Closes <backport-issue-url> on <branch-name>
-
-This PR:
-
-<span class="k">-</span><span class="w"> </span>Backports <original-pr-url> from @<author> to the <branch-name> line
-</pre></div>
-</div>
+<section id="defer-non-blocking-work-to-follow-on-issues">
+<h3>Defer Non-Blocking Work to Follow-On Issues<a class="headerlink" href="#defer-non-blocking-work-to-follow-on-issues" title="Link to this heading">#</a></h3>
+<p>Explicitly defer non-critical suggestions to a follow-on PR and file
+(or ask the author to file) issues for them, so good PRs merge quickly
+without scope creep.</p>
+<p>Similarly, when a PR mixes refactoring with behavior changes or fixes a narrow
+problem with a broad mechanism, ask for it to be split or scoped down rather
+than reviewing it as-is.</p>
+</section>
+<section id="narrate-what-you-verified-when-approving">
+<h3>Narrate What You Verified When Approving<a class="headerlink" href="#narrate-what-you-verified-when-approving" title="Link to this heading">#</a></h3>
+<p>Rather than a bare “LGTM”, say what you actually checked (“traced the state
+transitions by hand”, “confirmed the hasher change cannot affect ordering”)
+so it is clear what was verified and what was not.</p>
+</section>
+<section id="invite-additional-committers-on-core-changes">
+<h3>Invite Additional Committers on Core Changes<a class="headerlink" href="#invite-additional-committers-on-core-changes" title="Link to this heading">#</a></h3>
+<p>For changes to core, widely shared code, leave the PR open for other
+committers to look at and cc those who know the area, even after you have
+approved.</p>
</section>
</section>
</section>
@@ -627,20 +656,20 @@ This PR:
<div class="prev-next-area">
<a class="left-prev"
- href="howtos.html"
+ href="index.html"
title="previous page">
<i class="fa-solid fa-angle-left"></i>
<div class="prev-next-info">
<p class="prev-next-subtitle">previous</p>
- <p class="prev-next-title">HOWTOs</p>
+ <p class="prev-next-title">Introduction</p>
</div>
</a>
<a class="right-next"
- href="roadmap.html"
+ href="communication.html"
title="next page">
<div class="prev-next-info">
<p class="prev-next-subtitle">next</p>
- <p class="prev-next-title">Roadmap and Improvement Proposals</p>
+ <p class="prev-next-title">Community Communication</p>
</div>
<i class="fa-solid fa-angle-right"></i>
</a>
@@ -663,20 +692,18 @@ This PR:
</div>
<nav id="pst-page-toc-nav" class="page-toc" aria-labelledby="pst-page-navigation-heading-2">
<ul class="pst-show_toc_level nav section-nav flex-column">
-<li class="toc-h2 nav-item toc-entry"><a class="reference internal nav-link" href="#overview">Overview</a></li>
-<li class="toc-h2 nav-item toc-entry"><a class="reference internal nav-link" href="#backport-criteria">Backport Criteria</a><ul class="nav section-nav flex-column">
-<li class="toc-h3 nav-item toc-entry"><a class="reference internal nav-link" href="#eligible-for-backport">Eligible for backport</a></li>
-<li class="toc-h3 nav-item toc-entry"><a class="reference internal nav-link" href="#not-recommended-for-backport">Not recommended for backport</a></li>
-<li class="toc-h3 nav-item toc-entry"><a class="reference internal nav-link" href="#behavior-changes">Behavior changes</a></li>
-<li class="toc-h3 nav-item toc-entry"><a class="reference internal nav-link" href="#who-decides">Who decides</a></li>
-<li class="toc-h3 nav-item toc-entry"><a class="reference internal nav-link" href="#active-release-branches">Active release branches</a></li>
-</ul>
-</li>
-<li class="toc-h2 nav-item toc-entry"><a class="reference internal nav-link" href="#backport-workflow">Backport Workflow</a><ul class="nav section-nav flex-column">
-<li class="toc-h3 nav-item toc-entry"><a class="reference internal nav-link" href="#inputs">Inputs</a></li>
-<li class="toc-h3 nav-item toc-entry"><a class="reference internal nav-link" href="#apply-the-backport">Apply the Backport</a></li>
-<li class="toc-h3 nav-item toc-entry"><a class="reference internal nav-link" href="#test">Test</a></li>
-<li class="toc-h3 nav-item toc-entry"><a class="reference internal nav-link" href="#open-the-pr">Open the PR</a></li>
+<li class="toc-h2 nav-item toc-entry"><a class="reference internal nav-link" href="#pr-review-mechanics">PR Review Mechanics</a></li>
+<li class="toc-h2 nav-item toc-entry"><a class="reference internal nav-link" href="#review-the-pr-description">Review the PR Description</a></li>
+<li class="toc-h2 nav-item toc-entry"><a class="reference internal nav-link" href="#review-the-code-comments">Review the Code Comments</a></li>
+<li class="toc-h2 nav-item toc-entry"><a class="reference internal nav-link" href="#review-the-test-coverage">Review the Test Coverage</a></li>
+<li class="toc-h2 nav-item toc-entry"><a class="reference internal nav-link" href="#review-the-code">Review the Code</a></li>
+<li class="toc-h2 nav-item toc-entry"><a class="reference internal nav-link" href="#review-the-performance">Review the Performance</a></li>
+<li class="toc-h2 nav-item toc-entry"><a class="reference internal nav-link" href="#best-practices-for-reviewers">Best Practices for Reviewers</a><ul class="nav section-nav flex-column">
+<li class="toc-h3 nav-item toc-entry"><a class="reference internal nav-link" href="#review-tone-thank-contributors-and-praise-good-work-specifically">Review Tone: Thank Contributors and Praise Good Work Specifically</a></li>
+<li class="toc-h3 nav-item toc-entry"><a class="reference internal nav-link" href="#state-approval-conditions-explicitly">State Approval Conditions Explicitly</a></li>
+<li class="toc-h3 nav-item toc-entry"><a class="reference internal nav-link" href="#defer-non-blocking-work-to-follow-on-issues">Defer Non-Blocking Work to Follow-On Issues</a></li>
+<li class="toc-h3 nav-item toc-entry"><a class="reference internal nav-link" href="#narrate-what-you-verified-when-approving">Narrate What You Verified When Approving</a></li>
+<li class="toc-h3 nav-item toc-entry"><a class="reference internal nav-link" href="#invite-additional-committers-on-core-changes">Invite Additional Committers on Core Changes</a></li>
</ul>
</li>
</ul>
@@ -686,7 +713,7 @@ This PR:
<div class="tocsection editthispage">
- <a href="https://github.com/apache/arrow-datafusion/edit/main/docs/source/contributor-guide/release_management.md">
+ <a href="https://github.com/apache/arrow-datafusion/edit/main/docs/source/contributor-guide/pr_review.md">
<i class="fa-solid fa-pencil"></i>
@@ -701,7 +728,7 @@ This PR:
<div class="sidebar-secondary-item">
<div class="tocsection sourcelink">
- <a href="../_sources/contributor-guide/release_management.md.txt">
+ <a href="../_sources/contributor-guide/pr_review.md.txt">
<i class="fa-solid fa-file-lines"></i> Show Source
</a>
</div>
diff --git a/contributor-guide/release_management.html b/contributor-guide/release_management.html
index cf647104cc..4b33d58c3f 100644
--- a/contributor-guide/release_management.html
+++ b/contributor-guide/release_management.html
@@ -338,6 +338,7 @@
<ul class="current nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="architecture.html">Architecture</a></li>
diff --git a/contributor-guide/roadmap.html b/contributor-guide/roadmap.html
index e6a9095891..c3f48d24fc 100644
--- a/contributor-guide/roadmap.html
+++ b/contributor-guide/roadmap.html
@@ -338,6 +338,7 @@
<ul class="current nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="architecture.html">Architecture</a></li>
diff --git a/contributor-guide/specification/index.html b/contributor-guide/specification/index.html
index 3e3474e8a3..b5d003dd77 100644
--- a/contributor-guide/specification/index.html
+++ b/contributor-guide/specification/index.html
@@ -338,6 +338,7 @@
<ul class="current nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../architecture.html">Architecture</a></li>
diff --git a/contributor-guide/specification/invariants.html b/contributor-guide/specification/invariants.html
index 70d5da5afb..90e801fe2b 100644
--- a/contributor-guide/specification/invariants.html
+++ b/contributor-guide/specification/invariants.html
@@ -338,6 +338,7 @@
<ul class="current nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../architecture.html">Architecture</a></li>
diff --git a/contributor-guide/specification/output-field-name-semantic.html b/contributor-guide/specification/output-field-name-semantic.html
index bc31f266d6..0b209de14b 100644
--- a/contributor-guide/specification/output-field-name-semantic.html
+++ b/contributor-guide/specification/output-field-name-semantic.html
@@ -338,6 +338,7 @@
<ul class="current nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../architecture.html">Architecture</a></li>
diff --git a/contributor-guide/testing.html b/contributor-guide/testing.html
index bf995531e8..3fdfc623b5 100644
--- a/contributor-guide/testing.html
+++ b/contributor-guide/testing.html
@@ -338,6 +338,7 @@
<ul class="current nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="architecture.html">Architecture</a></li>
diff --git a/download.html b/download.html
index b9f1d3b7d8..bec0e8b094 100644
--- a/download.html
+++ b/download.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/architecture.html">Architecture</a></li>
diff --git a/genindex.html b/genindex.html
index 639c9dcc0b..37032108d8 100644
--- a/genindex.html
+++ b/genindex.html
@@ -333,6 +333,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/architecture.html">Architecture</a></li>
diff --git a/index.html b/index.html
index 63768943f0..2781148973 100644
--- a/index.html
+++ b/index.html
@@ -339,6 +339,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/architecture.html">Architecture</a></li>
@@ -523,6 +524,7 @@ See the <a class="reference external" href="https://datafusion.apache.org/contri
<ul>
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/index.html">Introduction</a></li>
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/index.html#developer-s-guide">Developer’s guide</a></li>
+<li class="toctree-l1"><a class="reference internal" href="contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/building-logical-plans.html b/library-user-guide/building-logical-plans.html
index 607e1ec0d0..6e18ae9580 100644
--- a/library-user-guide/building-logical-plans.html
+++ b/library-user-guide/building-logical-plans.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/catalogs.html b/library-user-guide/catalogs.html
index e1c261ef8b..01991511dd 100644
--- a/library-user-guide/catalogs.html
+++ b/library-user-guide/catalogs.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/custom-table-providers.html b/library-user-guide/custom-table-providers.html
index d5fc0ec8ce..d489a662f2 100644
--- a/library-user-guide/custom-table-providers.html
+++ b/library-user-guide/custom-table-providers.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/extending-operators.html b/library-user-guide/extending-operators.html
index 8a04e1c572..3a3fefd92f 100644
--- a/library-user-guide/extending-operators.html
+++ b/library-user-guide/extending-operators.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/extending-sql.html b/library-user-guide/extending-sql.html
index d88e55d378..85c2f11b67 100644
--- a/library-user-guide/extending-sql.html
+++ b/library-user-guide/extending-sql.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/extensions.html b/library-user-guide/extensions.html
index 1492b1faaa..085eee0d8e 100644
--- a/library-user-guide/extensions.html
+++ b/library-user-guide/extensions.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/functions/adding-udfs.html b/library-user-guide/functions/adding-udfs.html
index d6876abda0..86208bc65e 100644
--- a/library-user-guide/functions/adding-udfs.html
+++ b/library-user-guide/functions/adding-udfs.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/functions/index.html b/library-user-guide/functions/index.html
index 49cea64a10..0dc4666039 100644
--- a/library-user-guide/functions/index.html
+++ b/library-user-guide/functions/index.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/functions/spark.html b/library-user-guide/functions/spark.html
index 4f64b30c59..03305d18aa 100644
--- a/library-user-guide/functions/spark.html
+++ b/library-user-guide/functions/spark.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/index.html b/library-user-guide/index.html
index 80007a5297..6a7addbb3f 100644
--- a/library-user-guide/index.html
+++ b/library-user-guide/index.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/profiling.html b/library-user-guide/profiling.html
index c1de185e13..00536d57e0 100644
--- a/library-user-guide/profiling.html
+++ b/library-user-guide/profiling.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/query-optimizer.html b/library-user-guide/query-optimizer.html
index 96e11fd51f..6490cc9ae3 100644
--- a/library-user-guide/query-optimizer.html
+++ b/library-user-guide/query-optimizer.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/table-constraints.html b/library-user-guide/table-constraints.html
index fcb36f521e..1c3ac25551 100644
--- a/library-user-guide/table-constraints.html
+++ b/library-user-guide/table-constraints.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/upgrading/46.0.0.html b/library-user-guide/upgrading/46.0.0.html
index 41d7189151..05f6a5348a 100644
--- a/library-user-guide/upgrading/46.0.0.html
+++ b/library-user-guide/upgrading/46.0.0.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/upgrading/47.0.0.html b/library-user-guide/upgrading/47.0.0.html
index ea22f471a0..671cf50a12 100644
--- a/library-user-guide/upgrading/47.0.0.html
+++ b/library-user-guide/upgrading/47.0.0.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/upgrading/48.0.0.html b/library-user-guide/upgrading/48.0.0.html
index 0d333d1049..bae403adaf 100644
--- a/library-user-guide/upgrading/48.0.0.html
+++ b/library-user-guide/upgrading/48.0.0.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/upgrading/48.0.1.html b/library-user-guide/upgrading/48.0.1.html
index 17d1b012fb..22813f4719 100644
--- a/library-user-guide/upgrading/48.0.1.html
+++ b/library-user-guide/upgrading/48.0.1.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/upgrading/49.0.0.html b/library-user-guide/upgrading/49.0.0.html
index 9430520c4d..8e77df552c 100644
--- a/library-user-guide/upgrading/49.0.0.html
+++ b/library-user-guide/upgrading/49.0.0.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/upgrading/50.0.0.html b/library-user-guide/upgrading/50.0.0.html
index 8fc45ae4c6..f660dcb03b 100644
--- a/library-user-guide/upgrading/50.0.0.html
+++ b/library-user-guide/upgrading/50.0.0.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/upgrading/51.0.0.html b/library-user-guide/upgrading/51.0.0.html
index 314938b30d..3f6659cab7 100644
--- a/library-user-guide/upgrading/51.0.0.html
+++ b/library-user-guide/upgrading/51.0.0.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/upgrading/52.0.0.html b/library-user-guide/upgrading/52.0.0.html
index 7541f38f1f..39c5ba0253 100644
--- a/library-user-guide/upgrading/52.0.0.html
+++ b/library-user-guide/upgrading/52.0.0.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/upgrading/53.0.0.html b/library-user-guide/upgrading/53.0.0.html
index cbe3a4969d..518b912530 100644
--- a/library-user-guide/upgrading/53.0.0.html
+++ b/library-user-guide/upgrading/53.0.0.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/upgrading/54.0.0.html b/library-user-guide/upgrading/54.0.0.html
index 74f5fd04f6..c02280eb9d 100644
--- a/library-user-guide/upgrading/54.0.0.html
+++ b/library-user-guide/upgrading/54.0.0.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/upgrading/55.0.0.html b/library-user-guide/upgrading/55.0.0.html
index dfc6d1af43..87fac35502 100644
--- a/library-user-guide/upgrading/55.0.0.html
+++ b/library-user-guide/upgrading/55.0.0.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/upgrading/index.html b/library-user-guide/upgrading/index.html
index 8a4767c31d..c2756d872d 100644
--- a/library-user-guide/upgrading/index.html
+++ b/library-user-guide/upgrading/index.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/using-the-dataframe-api.html b/library-user-guide/using-the-dataframe-api.html
index 901f951453..0bd711cdce 100644
--- a/library-user-guide/using-the-dataframe-api.html
+++ b/library-user-guide/using-the-dataframe-api.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/using-the-sql-api.html b/library-user-guide/using-the-sql-api.html
index 2df8ea860c..35d94b66b3 100644
--- a/library-user-guide/using-the-sql-api.html
+++ b/library-user-guide/using-the-sql-api.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/library-user-guide/working-with-exprs.html b/library-user-guide/working-with-exprs.html
index 39f4416b54..3bb1c82317 100644
--- a/library-user-guide/working-with-exprs.html
+++ b/library-user-guide/working-with-exprs.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/objects.inv b/objects.inv
index 95e18da8ab..02cdaa6007 100644
Binary files a/objects.inv and b/objects.inv differ
diff --git a/search.html b/search.html
index 400f74210c..61b99ee2c6 100644
--- a/search.html
+++ b/search.html
@@ -332,6 +332,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="contributor-guide/architecture.html">Architecture</a></li>
diff --git a/searchindex.js b/searchindex.js
index 1f8ed6af3e..834b995c63 100644
--- a/searchindex.js
+++ b/searchindex.js
@@ -1 +1 @@
-Search.setIndex({"alltitles":{"!=":[[75,"op-neq"]],"!~":[[75,"op-re-not-match"]],"!~*":[[75,"op-re-not-match-i"]],"!~~":[[75,"id19"]],"!~~*":[[75,"id20"]],"#":[[75,"op-bit-xor"]],"%":[[75,"op-modulo"]],"&":[[75,"op-bit-and"]],"(relation, name) tuples in logical fields and logical columns are unique":[[15,"relation-name-tuples-in-logical-fields-and-logical-columns-are-unique"]],"*":[[75,"op-multiply"]],"+":[[75,"op-plus"]],"-":[[75,"op-minus"]],"/":[[75,"op-divide"]],"1. Array Literal Con [...]
\ No newline at end of file
+Search.setIndex({"alltitles":{"!=":[[76,"op-neq"]],"!~":[[76,"op-re-not-match"]],"!~*":[[76,"op-re-not-match-i"]],"!~~":[[76,"id19"]],"!~~*":[[76,"id20"]],"#":[[76,"op-bit-xor"]],"%":[[76,"op-modulo"]],"&":[[76,"op-bit-and"]],"(relation, name) tuples in logical fields and logical columns are unique":[[16,"relation-name-tuples-in-logical-fields-and-logical-columns-are-unique"]],"*":[[76,"op-multiply"]],"+":[[76,"op-plus"]],"-":[[76,"op-minus"]],"/":[[76,"op-divide"]],"1. Array Literal Con [...]
\ No newline at end of file
diff --git a/user-guide/arrow-introduction.html b/user-guide/arrow-introduction.html
index dc734072fe..d8cca819a0 100644
--- a/user-guide/arrow-introduction.html
+++ b/user-guide/arrow-introduction.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/cli/datasources.html b/user-guide/cli/datasources.html
index 715c4c3407..64c52d2570 100644
--- a/user-guide/cli/datasources.html
+++ b/user-guide/cli/datasources.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/cli/functions.html b/user-guide/cli/functions.html
index 18115b9993..781b802399 100644
--- a/user-guide/cli/functions.html
+++ b/user-guide/cli/functions.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/cli/index.html b/user-guide/cli/index.html
index 9d2c3e656f..be97b20f0a 100644
--- a/user-guide/cli/index.html
+++ b/user-guide/cli/index.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/cli/installation.html b/user-guide/cli/installation.html
index 56bf136072..5f3c50b7e0 100644
--- a/user-guide/cli/installation.html
+++ b/user-guide/cli/installation.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/cli/overview.html b/user-guide/cli/overview.html
index 4df8dc2223..8fec3cf3cb 100644
--- a/user-guide/cli/overview.html
+++ b/user-guide/cli/overview.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/cli/usage.html b/user-guide/cli/usage.html
index 59904de8f6..9120f01535 100644
--- a/user-guide/cli/usage.html
+++ b/user-guide/cli/usage.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/concepts-readings-events.html b/user-guide/concepts-readings-events.html
index def6a6ab77..504ba23d75 100644
--- a/user-guide/concepts-readings-events.html
+++ b/user-guide/concepts-readings-events.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/configs.html b/user-guide/configs.html
index b7895d0ca1..e8cd1f16c9 100644
--- a/user-guide/configs.html
+++ b/user-guide/configs.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/crate-configuration.html b/user-guide/crate-configuration.html
index c1f6645037..c137b0a7e2 100644
--- a/user-guide/crate-configuration.html
+++ b/user-guide/crate-configuration.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/dataframe.html b/user-guide/dataframe.html
index 13d7aa5b63..c7ae631d7e 100644
--- a/user-guide/dataframe.html
+++ b/user-guide/dataframe.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/example-usage.html b/user-guide/example-usage.html
index 9a3d645ec9..2dad68ca94 100644
--- a/user-guide/example-usage.html
+++ b/user-guide/example-usage.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/explain-usage.html b/user-guide/explain-usage.html
index a89c723385..5f74f2a6e6 100644
--- a/user-guide/explain-usage.html
+++ b/user-guide/explain-usage.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/expressions.html b/user-guide/expressions.html
index d272fc0aef..692d22a386 100644
--- a/user-guide/expressions.html
+++ b/user-guide/expressions.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/faq.html b/user-guide/faq.html
index 0dd22a6aa9..5edb4f9690 100644
--- a/user-guide/faq.html
+++ b/user-guide/faq.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/features.html b/user-guide/features.html
index 71e4270b0a..2105101ac6 100644
--- a/user-guide/features.html
+++ b/user-guide/features.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/introduction.html b/user-guide/introduction.html
index 312fc58a2f..bc5c08bfd4 100644
--- a/user-guide/introduction.html
+++ b/user-guide/introduction.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/metrics.html b/user-guide/metrics.html
index f21a67ee51..f4e8f22e02 100644
--- a/user-guide/metrics.html
+++ b/user-guide/metrics.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/parquet-content-defined-chunking.html b/user-guide/parquet-content-defined-chunking.html
index fd61ddfdb7..581f46dc37 100644
--- a/user-guide/parquet-content-defined-chunking.html
+++ b/user-guide/parquet-content-defined-chunking.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/sql/aggregate_functions.html b/user-guide/sql/aggregate_functions.html
index 93ba8a5349..2b10293a38 100644
--- a/user-guide/sql/aggregate_functions.html
+++ b/user-guide/sql/aggregate_functions.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/sql/data_types.html b/user-guide/sql/data_types.html
index 8fc07234f0..f311b8f81f 100644
--- a/user-guide/sql/data_types.html
+++ b/user-guide/sql/data_types.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/sql/ddl.html b/user-guide/sql/ddl.html
index 4476b07a4d..da2fb0ef94 100644
--- a/user-guide/sql/ddl.html
+++ b/user-guide/sql/ddl.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/sql/dml.html b/user-guide/sql/dml.html
index f172b1ae9d..663d9f9bd4 100644
--- a/user-guide/sql/dml.html
+++ b/user-guide/sql/dml.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/sql/explain.html b/user-guide/sql/explain.html
index 2b7475d971..8c10460e77 100644
--- a/user-guide/sql/explain.html
+++ b/user-guide/sql/explain.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/sql/format_options.html b/user-guide/sql/format_options.html
index cef3a58990..c55d150c74 100644
--- a/user-guide/sql/format_options.html
+++ b/user-guide/sql/format_options.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/sql/index.html b/user-guide/sql/index.html
index 115e001327..9616c7a139 100644
--- a/user-guide/sql/index.html
+++ b/user-guide/sql/index.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/sql/information_schema.html b/user-guide/sql/information_schema.html
index ed9dde6a0a..a493928249 100644
--- a/user-guide/sql/information_schema.html
+++ b/user-guide/sql/information_schema.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/sql/operators.html b/user-guide/sql/operators.html
index a2b31a94f4..471583b4c8 100644
--- a/user-guide/sql/operators.html
+++ b/user-guide/sql/operators.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/sql/prepared_statements.html b/user-guide/sql/prepared_statements.html
index 15a4f1e9e8..d1da473560 100644
--- a/user-guide/sql/prepared_statements.html
+++ b/user-guide/sql/prepared_statements.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/sql/scalar_functions.html b/user-guide/sql/scalar_functions.html
index 75c6833ef4..15bff22187 100644
--- a/user-guide/sql/scalar_functions.html
+++ b/user-guide/sql/scalar_functions.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/sql/select.html b/user-guide/sql/select.html
index 86d7c19bd6..4a8764eafb 100644
--- a/user-guide/sql/select.html
+++ b/user-guide/sql/select.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/sql/special_functions.html b/user-guide/sql/special_functions.html
index 7e6db55b30..a8526c01fd 100644
--- a/user-guide/sql/special_functions.html
+++ b/user-guide/sql/special_functions.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/sql/struct_coercion.html b/user-guide/sql/struct_coercion.html
index b550fecad1..0360602475 100644
--- a/user-guide/sql/struct_coercion.html
+++ b/user-guide/sql/struct_coercion.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/sql/subqueries.html b/user-guide/sql/subqueries.html
index 6d01999235..99bed78ac1 100644
--- a/user-guide/sql/subqueries.html
+++ b/user-guide/sql/subqueries.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
diff --git a/user-guide/sql/window_functions.html b/user-guide/sql/window_functions.html
index 3b246728fd..0363a593c4 100644
--- a/user-guide/sql/window_functions.html
+++ b/user-guide/sql/window_functions.html
@@ -338,6 +338,7 @@
<ul class="nav bd-sidenav">
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/index.html">Introduction</a></li>
+<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/pr_review.html">Reviewing Pull Requests</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/communication.html">Community Communication</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/development_environment.html">Development Environment</a></li>
<li class="toctree-l1"><a class="reference internal" href="../../contributor-guide/architecture.html">Architecture</a></li>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org