You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2018/09/14 21:44:33 UTC
[Impala-ASF-CR] IMPALA-7573: Fix GroupingAggregator::Reset with output partition
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11446
Change subject: IMPALA-7573: Fix GroupingAggregator::Reset with output_partition_
......................................................................
IMPALA-7573: Fix GroupingAggregator::Reset with output_partition_
GroupingAggregator::Reset() doesn't call Close() on output_partition_,
which can lead to hitting a DCHECK(is_closed) in the Partition
destructor.
Testing:
- Added an e2e regression test.
Change-Id: I6db8ec8479b18b5ed681d7ac438480711ab7a1ba
---
M be/src/exec/grouping-aggregator.cc
M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
2 files changed, 21 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/11446/1
--
To view, visit http://gerrit.cloudera.org:8080/11446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6db8ec8479b18b5ed681d7ac438480711ab7a1ba
Gerrit-Change-Number: 11446
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-7573: Fix GroupingAggregator::Reset with output partition
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11446
to look at the new patch set (#2).
Change subject: IMPALA-7573: Fix GroupingAggregator::Reset with output_partition_
......................................................................
IMPALA-7573: Fix GroupingAggregator::Reset with output_partition_
GroupingAggregator::Reset() doesn't call Close() on output_partition_,
which can lead to hitting a DCHECK(is_closed) in the Partition
destructor.
Testing:
- Added an e2e regression test.
Change-Id: I6db8ec8479b18b5ed681d7ac438480711ab7a1ba
---
M be/src/exec/grouping-aggregator.cc
M be/src/exec/grouping-aggregator.h
M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
3 files changed, 26 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/11446/2
--
To view, visit http://gerrit.cloudera.org:8080/11446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6db8ec8479b18b5ed681d7ac438480711ab7a1ba
Gerrit-Change-Number: 11446
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7573: Fix GroupingAggregator::Reset with output partition
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11446 )
Change subject: IMPALA-7573: Fix GroupingAggregator::Reset with output_partition_
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6db8ec8479b18b5ed681d7ac438480711ab7a1ba
Gerrit-Change-Number: 11446
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Sep 2018 20:52:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7573: Fix GroupingAggregator::Reset with output partition
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11446 )
Change subject: IMPALA-7573: Fix GroupingAggregator::Reset with output_partition_
......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Couple of opportunities to improve comments but the fix makes sense, thanks for finding and fixing.
http://gerrit.cloudera.org:8080/#/c/11446/1/be/src/exec/grouping-aggregator.h
File be/src/exec/grouping-aggregator.h:
http://gerrit.cloudera.org:8080/#/c/11446/1/be/src/exec/grouping-aggregator.h@583
PS1, Line 583: /// 'spilled_partitions_', and 'hash_partitions_' and then resets the lists,
Comment needs update to mention output_partition_.
http://gerrit.cloudera.org:8080/#/c/11446/1/be/src/exec/grouping-aggregator.cc
File be/src/exec/grouping-aggregator.cc:
http://gerrit.cloudera.org:8080/#/c/11446/1/be/src/exec/grouping-aggregator.cc@260
PS1, Line 260: DCHECK(output_partition_ != nullptr);
Can you document this invariant (!output_iterator_.AtEnd() implies output_partition_ != nullptr) in the header?
--
To view, visit http://gerrit.cloudera.org:8080/11446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6db8ec8479b18b5ed681d7ac438480711ab7a1ba
Gerrit-Change-Number: 11446
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 15 Sep 2018 00:15:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7573: Fix GroupingAggregator::Reset with output partition
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11446 )
Change subject: IMPALA-7573: Fix GroupingAggregator::Reset with output_partition_
......................................................................
IMPALA-7573: Fix GroupingAggregator::Reset with output_partition_
GroupingAggregator::Reset() doesn't call Close() on output_partition_,
which can lead to hitting a DCHECK(is_closed) in the Partition
destructor.
Testing:
- Added an e2e regression test.
Change-Id: I6db8ec8479b18b5ed681d7ac438480711ab7a1ba
Reviewed-on: http://gerrit.cloudera.org:8080/11446
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/grouping-aggregator.cc
M be/src/exec/grouping-aggregator.h
M testdata/workloads/functional-query/queries/QueryTest/nested-types-subplan.test
3 files changed, 26 insertions(+), 12 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6db8ec8479b18b5ed681d7ac438480711ab7a1ba
Gerrit-Change-Number: 11446
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7573: Fix GroupingAggregator::Reset with output partition
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11446 )
Change subject: IMPALA-7573: Fix GroupingAggregator::Reset with output_partition_
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3166/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6db8ec8479b18b5ed681d7ac438480711ab7a1ba
Gerrit-Change-Number: 11446
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Sep 2018 20:52:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7573: Fix GroupingAggregator::Reset with output partition
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11446 )
Change subject: IMPALA-7573: Fix GroupingAggregator::Reset with output_partition_
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6db8ec8479b18b5ed681d7ac438480711ab7a1ba
Gerrit-Change-Number: 11446
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 18 Sep 2018 00:37:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7573: Fix GroupingAggregator::Reset with output partition
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11446 )
Change subject: IMPALA-7573: Fix GroupingAggregator::Reset with output_partition_
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
carrying forward
http://gerrit.cloudera.org:8080/#/c/11446/1/be/src/exec/grouping-aggregator.h
File be/src/exec/grouping-aggregator.h:
http://gerrit.cloudera.org:8080/#/c/11446/1/be/src/exec/grouping-aggregator.h@583
PS1, Line 583: /// Calls Close() on 'output_partition_' and every Partition in
> Comment needs update to mention output_partition_.
Done
http://gerrit.cloudera.org:8080/#/c/11446/1/be/src/exec/grouping-aggregator.cc
File be/src/exec/grouping-aggregator.cc:
http://gerrit.cloudera.org:8080/#/c/11446/1/be/src/exec/grouping-aggregator.cc@260
PS1, Line 260: DCHECK(output_partition_ != nullptr);
> Can you document this invariant (!output_iterator_.AtEnd() implies output_p
Done
--
To view, visit http://gerrit.cloudera.org:8080/11446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6db8ec8479b18b5ed681d7ac438480711ab7a1ba
Gerrit-Change-Number: 11446
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Sep 2018 20:52:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7573: Fix GroupingAggregator::Reset with output partition
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11446 )
Change subject: IMPALA-7573: Fix GroupingAggregator::Reset with output_partition_
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/682/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6db8ec8479b18b5ed681d7ac438480711ab7a1ba
Gerrit-Change-Number: 11446
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Sep 2018 22:18:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7573: Fix GroupingAggregator::Reset with output partition
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11446 )
Change subject: IMPALA-7573: Fix GroupingAggregator::Reset with output_partition_
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/695/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6db8ec8479b18b5ed681d7ac438480711ab7a1ba
Gerrit-Change-Number: 11446
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 17 Sep 2018 21:24:35 +0000
Gerrit-HasComments: No