You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/11/05 14:59:46 UTC
(commons-pool) branch master updated: Make package private class final
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-pool.git
The following commit(s) were added to refs/heads/master by this push:
new 2a17b229 Make package private class final
2a17b229 is described below
commit 2a17b2295216cdea74a5b39e4c61531e6ea1913d
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Nov 5 09:59:40 2023 -0500
Make package private class final
---
.../java/org/apache/commons/pool3/impl/BaseGenericObjectPool.java | 4 ++--
src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java | 2 +-
.../org/apache/commons/pool3/impl/InterruptibleReentrantLock.java | 2 +-
.../java/org/apache/commons/pool3/impl/LinkedBlockingDeque.java | 2 +-
src/main/java/org/apache/commons/pool3/impl/PoolImplUtils.java | 2 +-
src/main/java/org/apache/commons/pool3/proxy/CglibProxyHandler.java | 2 +-
src/main/java/org/apache/commons/pool3/proxy/JdkProxyHandler.java | 2 +-
src/test/java/org/apache/commons/pool3/TestTrackedUse.java | 2 +-
.../org/apache/commons/pool3/impl/TestAbandonedKeyedObjectPool.java | 4 ++--
.../java/org/apache/commons/pool3/impl/TestAbandonedObjectPool.java | 6 +++---
.../java/org/apache/commons/pool3/impl/TestGenericObjectPool.java | 2 +-
.../java/org/apache/commons/pool3/performance/PerformanceTest.java | 2 +-
.../java/org/apache/commons/pool3/pool407/Pool407Constants.java | 2 +-
13 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/src/main/java/org/apache/commons/pool3/impl/BaseGenericObjectPool.java b/src/main/java/org/apache/commons/pool3/impl/BaseGenericObjectPool.java
index 6a98f08a..29572e76 100644
--- a/src/main/java/org/apache/commons/pool3/impl/BaseGenericObjectPool.java
+++ b/src/main/java/org/apache/commons/pool3/impl/BaseGenericObjectPool.java
@@ -66,7 +66,7 @@ public abstract class BaseGenericObjectPool<T, E extends Exception> extends Base
/**
* The idle object eviction iterator. Holds a reference to the idle objects.
*/
- class EvictionIterator implements Iterator<PooledObject<T>> {
+ final class EvictionIterator implements Iterator<PooledObject<T>> {
private final Deque<PooledObject<T>> idleObjects;
private final Iterator<PooledObject<T>> idleObjectIterator;
@@ -118,7 +118,7 @@ public abstract class BaseGenericObjectPool<T, E extends Exception> extends Base
*
* @see GenericKeyedObjectPool#setTimeBetweenEvictionRunsMillis
*/
- class Evictor implements Runnable {
+ final class Evictor implements Runnable {
private ScheduledFuture<?> scheduledFuture;
diff --git a/src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java b/src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java
index 5be2c369..7bbfcb3f 100644
--- a/src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java
+++ b/src/main/java/org/apache/commons/pool3/impl/EvictionTimer.java
@@ -46,7 +46,7 @@ import java.util.concurrent.TimeUnit;
*
* @since 2.0
*/
-class EvictionTimer {
+final class EvictionTimer {
/**
* Thread factory that creates a daemon thread, with the context class loader from this class.
diff --git a/src/main/java/org/apache/commons/pool3/impl/InterruptibleReentrantLock.java b/src/main/java/org/apache/commons/pool3/impl/InterruptibleReentrantLock.java
index 4231805e..0c2def7c 100644
--- a/src/main/java/org/apache/commons/pool3/impl/InterruptibleReentrantLock.java
+++ b/src/main/java/org/apache/commons/pool3/impl/InterruptibleReentrantLock.java
@@ -29,7 +29,7 @@ import java.util.concurrent.locks.ReentrantLock;
*
* @since 2.0
*/
-class InterruptibleReentrantLock extends ReentrantLock {
+final class InterruptibleReentrantLock extends ReentrantLock {
private static final long serialVersionUID = 1L;
diff --git a/src/main/java/org/apache/commons/pool3/impl/LinkedBlockingDeque.java b/src/main/java/org/apache/commons/pool3/impl/LinkedBlockingDeque.java
index 3b1de2ed..555fff89 100644
--- a/src/main/java/org/apache/commons/pool3/impl/LinkedBlockingDeque.java
+++ b/src/main/java/org/apache/commons/pool3/impl/LinkedBlockingDeque.java
@@ -65,7 +65,7 @@ import java.util.concurrent.locks.Condition;
*
* @since 2.0
*/
-class LinkedBlockingDeque<E> extends AbstractQueue<E>
+final class LinkedBlockingDeque<E> extends AbstractQueue<E>
implements Deque<E>, Serializable {
/*
diff --git a/src/main/java/org/apache/commons/pool3/impl/PoolImplUtils.java b/src/main/java/org/apache/commons/pool3/impl/PoolImplUtils.java
index 0ee19dd4..e5b25037 100644
--- a/src/main/java/org/apache/commons/pool3/impl/PoolImplUtils.java
+++ b/src/main/java/org/apache/commons/pool3/impl/PoolImplUtils.java
@@ -32,7 +32,7 @@ import org.apache.commons.pool3.PooledObjectFactory;
*
* @since 2.0
*/
-class PoolImplUtils {
+final class PoolImplUtils {
/**
* Identifies the concrete type of object that an object factory creates.
diff --git a/src/main/java/org/apache/commons/pool3/proxy/CglibProxyHandler.java b/src/main/java/org/apache/commons/pool3/proxy/CglibProxyHandler.java
index a458bc80..83640696 100644
--- a/src/main/java/org/apache/commons/pool3/proxy/CglibProxyHandler.java
+++ b/src/main/java/org/apache/commons/pool3/proxy/CglibProxyHandler.java
@@ -30,7 +30,7 @@ import net.sf.cglib.proxy.MethodProxy;
*
* @since 2.0
*/
-class CglibProxyHandler<T> extends BaseProxyHandler<T>
+final class CglibProxyHandler<T> extends BaseProxyHandler<T>
implements MethodInterceptor {
diff --git a/src/main/java/org/apache/commons/pool3/proxy/JdkProxyHandler.java b/src/main/java/org/apache/commons/pool3/proxy/JdkProxyHandler.java
index ae79b0ba..4c71ea01 100644
--- a/src/main/java/org/apache/commons/pool3/proxy/JdkProxyHandler.java
+++ b/src/main/java/org/apache/commons/pool3/proxy/JdkProxyHandler.java
@@ -28,7 +28,7 @@ import org.apache.commons.pool3.UsageTracking;
*
* @since 2.0
*/
-class JdkProxyHandler<T> extends BaseProxyHandler<T>
+final class JdkProxyHandler<T> extends BaseProxyHandler<T>
implements InvocationHandler {
/**
diff --git a/src/test/java/org/apache/commons/pool3/TestTrackedUse.java b/src/test/java/org/apache/commons/pool3/TestTrackedUse.java
index 9cb704c6..0ce30d0a 100644
--- a/src/test/java/org/apache/commons/pool3/TestTrackedUse.java
+++ b/src/test/java/org/apache/commons/pool3/TestTrackedUse.java
@@ -25,7 +25,7 @@ import org.junit.jupiter.api.Test;
public class TestTrackedUse {
- class DefaultTrackedUse implements TrackedUse {
+ final class DefaultTrackedUse implements TrackedUse {
@Override
public Instant getLastUsedInstant() {
diff --git a/src/test/java/org/apache/commons/pool3/impl/TestAbandonedKeyedObjectPool.java b/src/test/java/org/apache/commons/pool3/impl/TestAbandonedKeyedObjectPool.java
index 712e1b38..f202859e 100644
--- a/src/test/java/org/apache/commons/pool3/impl/TestAbandonedKeyedObjectPool.java
+++ b/src/test/java/org/apache/commons/pool3/impl/TestAbandonedKeyedObjectPool.java
@@ -46,7 +46,7 @@ import org.junit.jupiter.api.Test;
*/
public class TestAbandonedKeyedObjectPool {
- class ConcurrentBorrower extends Thread {
+ final class ConcurrentBorrower extends Thread {
private final ArrayList<PooledTestObject> borrowed;
public ConcurrentBorrower(final ArrayList<PooledTestObject> borrowed) {
@@ -62,7 +62,7 @@ public class TestAbandonedKeyedObjectPool {
}
}
}
- class ConcurrentReturner extends Thread {
+ final class ConcurrentReturner extends Thread {
private final PooledTestObject returned;
public ConcurrentReturner(final PooledTestObject obj) {
returned = obj;
diff --git a/src/test/java/org/apache/commons/pool3/impl/TestAbandonedObjectPool.java b/src/test/java/org/apache/commons/pool3/impl/TestAbandonedObjectPool.java
index 471b814e..77bb2ad7 100644
--- a/src/test/java/org/apache/commons/pool3/impl/TestAbandonedObjectPool.java
+++ b/src/test/java/org/apache/commons/pool3/impl/TestAbandonedObjectPool.java
@@ -44,7 +44,7 @@ import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-class PooledTestObject implements TrackedUse {
+final class PooledTestObject implements TrackedUse {
private static final AtomicInteger ATOMIC_HASH = new AtomicInteger();
private static final Instant INSTANT_0 = Instant.ofEpochMilli(0);
private static final Instant INSTANT_1 = Instant.ofEpochMilli(1);
@@ -115,7 +115,7 @@ class PooledTestObject implements TrackedUse {
*/
public class TestAbandonedObjectPool {
- class ConcurrentBorrower extends Thread {
+ final class ConcurrentBorrower extends Thread {
private final ArrayList<PooledTestObject> borrowed;
public ConcurrentBorrower(final ArrayList<PooledTestObject> borrowed) {
@@ -131,7 +131,7 @@ public class TestAbandonedObjectPool {
}
}
}
- class ConcurrentReturner extends Thread {
+ final class ConcurrentReturner extends Thread {
private final PooledTestObject returned;
public ConcurrentReturner(final PooledTestObject obj) {
returned = obj;
diff --git a/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPool.java b/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPool.java
index b052c749..36002035 100644
--- a/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPool.java
+++ b/src/test/java/org/apache/commons/pool3/impl/TestGenericObjectPool.java
@@ -1617,7 +1617,7 @@ public class TestGenericObjectPool extends TestBaseObjectPool {
@Test
@Timeout(value = 60000, unit = TimeUnit.MILLISECONDS)
public void testEvictionSoftMinIdle() throws Exception {
- class TimeTest extends BasePooledObjectFactory<TimeTest, RuntimeException> {
+ final class TimeTest extends BasePooledObjectFactory<TimeTest, RuntimeException> {
private final long createTimeMillis;
public TimeTest() {
diff --git a/src/test/java/org/apache/commons/pool3/performance/PerformanceTest.java b/src/test/java/org/apache/commons/pool3/performance/PerformanceTest.java
index b05bcc7f..6cadf317 100644
--- a/src/test/java/org/apache/commons/pool3/performance/PerformanceTest.java
+++ b/src/test/java/org/apache/commons/pool3/performance/PerformanceTest.java
@@ -33,7 +33,7 @@ import org.apache.commons.pool3.impl.GenericObjectPool;
*/
public class PerformanceTest {
- class PerfTask implements Callable<TaskStats> {
+ final class PerfTask implements Callable<TaskStats> {
final TaskStats taskStats = new TaskStats();
long borrowTimeNanos;
long returnTimeNanos;
diff --git a/src/test/java/org/apache/commons/pool3/pool407/Pool407Constants.java b/src/test/java/org/apache/commons/pool3/pool407/Pool407Constants.java
index fab67127..734ca209 100644
--- a/src/test/java/org/apache/commons/pool3/pool407/Pool407Constants.java
+++ b/src/test/java/org/apache/commons/pool3/pool407/Pool407Constants.java
@@ -24,7 +24,7 @@ import org.apache.commons.pool3.impl.BaseObjectPoolConfig;
/**
* Tests POOL-407.
*/
-class Pool407Constants {
+final class Pool407Constants {
static final int AWAIT_TERMINATION_SECONDS = 10;
static final boolean BLOCK_WHEN_EXHAUSTED = true;