You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/12/07 06:56:21 UTC
[GitHub] [camel-quarkus] zhfeng opened a new pull request, #4323: Fix #4317 to update jms documentation for pooling and XA support
zhfeng opened a new pull request, #4323:
URL: https://github.com/apache/camel-quarkus/pull/4323
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #4323: Fix #4317 to update jms documentation for pooling and XA support
Posted by GitBox <gi...@apache.org>.
zhfeng commented on PR #4323:
URL: https://github.com/apache/camel-quarkus/pull/4323#issuecomment-1340881122
Thanks @ppalaga annd I think I need the other commit to apply your suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #4323: Fix #4317 to update jms documentation for pooling and XA support
Posted by GitBox <gi...@apache.org>.
zhfeng commented on PR #4323:
URL: https://github.com/apache/camel-quarkus/pull/4323#issuecomment-1340906843
I raise https://github.com/apache/camel-quarkus/pull/4327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng merged pull request #4323: Fix #4317 to update jms documentation for pooling and XA support
Posted by GitBox <gi...@apache.org>.
zhfeng merged PR #4323:
URL: https://github.com/apache/camel-quarkus/pull/4323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a diff in pull request #4323: Fix #4317 to update jms documentation for pooling and XA support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on code in PR #4323:
URL: https://github.com/apache/camel-quarkus/pull/4323#discussion_r1042064796
##########
extensions/jms/runtime/src/main/doc/usage.adoc:
##########
@@ -7,3 +7,29 @@ you must ensure that the `camel-quarkus-xml-jaxp` extension is present on the cl
When sending JMS message payloads as `javax.jms.ObjectMessage`, you must annotate the relevant classes to be registered for serialization with `@RegisterForReflection(serialization = true)`.
Note that this extension automatically sets `quarkus.camel.native.reflection.serialization-enabled = true` for you. Refer to the xref:user-guide/native-mode.adoc#serialization[native mode user guide] for more information.
+
+=== Pooling and XA integrate support
+
+You can use the `quarkus-pooled-jms` extension to get pooling and XA integrate support for JMS connections. Refer to the https://quarkiverse.github.io/quarkiverse-docs/quarkus-pooled-jms/dev/index.html[quarkus-pooled-jms] extension documentation for more information. Currently, it only works with `quarkus-artemis-jms` extension. Just add these two dependencies to your `pom.xml`:
+[source,xml]
+----
+<dependency>
+ <groupId>io.quarkiverse.messaginghub</groupId>
+ <artifactId>quarkus-pooled-jms</artifactId>
+</dependency>
+<dependency>
+ <groupId>io.quarkiverse.artemis</groupId>
+ <artifactId>quarkus-artemis-jms</artifactId>
+</dependency>
+----
+
+Pooling is default enabled and for XA integrate support, you need to add the following configuration to your `application.properties`:
Review Comment:
```suggestion
Note that pooling is enabled by default.
To enable XA, you need to add the following configuration to your `application.properties`:
```
##########
extensions/jms/runtime/src/main/doc/usage.adoc:
##########
@@ -7,3 +7,29 @@ you must ensure that the `camel-quarkus-xml-jaxp` extension is present on the cl
When sending JMS message payloads as `javax.jms.ObjectMessage`, you must annotate the relevant classes to be registered for serialization with `@RegisterForReflection(serialization = true)`.
Note that this extension automatically sets `quarkus.camel.native.reflection.serialization-enabled = true` for you. Refer to the xref:user-guide/native-mode.adoc#serialization[native mode user guide] for more information.
+
+=== Pooling and XA integrate support
+
+You can use the `quarkus-pooled-jms` extension to get pooling and XA integrate support for JMS connections. Refer to the https://quarkiverse.github.io/quarkiverse-docs/quarkus-pooled-jms/dev/index.html[quarkus-pooled-jms] extension documentation for more information. Currently, it only works with `quarkus-artemis-jms` extension. Just add these two dependencies to your `pom.xml`:
Review Comment:
```suggestion
You can use the `quarkus-pooled-jms` extension to get pooling and XA support for JMS connections. Refer to the https://quarkiverse.github.io/quarkiverse-docs/quarkus-pooled-jms/dev/index.html[quarkus-pooled-jms] extension documentation for more information. Currently, it only works with `quarkus-artemis-jms` extension. Just add these two dependencies to your `pom.xml`:
```
Side note: Single sentence per line makes the reviews and future changes easier to track.
##########
extensions/jms/runtime/src/main/doc/usage.adoc:
##########
@@ -7,3 +7,29 @@ you must ensure that the `camel-quarkus-xml-jaxp` extension is present on the cl
When sending JMS message payloads as `javax.jms.ObjectMessage`, you must annotate the relevant classes to be registered for serialization with `@RegisterForReflection(serialization = true)`.
Note that this extension automatically sets `quarkus.camel.native.reflection.serialization-enabled = true` for you. Refer to the xref:user-guide/native-mode.adoc#serialization[native mode user guide] for more information.
+
+=== Pooling and XA integrate support
Review Comment:
```suggestion
=== Support for Connection pooling and X/Open XA distributed transactions
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org