You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "jmuehlner (via GitHub)" <gi...@apache.org> on 2023/05/19 22:12:00 UTC
[GitHub] [guacamole-client] jmuehlner opened a new pull request, #873: GUACAMOLE-926: Fix UTF-8 handling in batch import files.
jmuehlner opened a new pull request, #873:
URL: https://github.com/apache/guacamole-client/pull/873
I tried creating a connection with the name “平仮名” using CSV, JSON, and YAML file types. The existing file parsing logic will return a name of "平仮å" instead.
Luckily, the fix was easy. All the file type checks (including the check of the first few bytes to see if the file is secretly a zip in disguise) still work as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] mike-jumper merged pull request #873: GUACAMOLE-926: Fix UTF-8 handling in batch import files.
Posted by "mike-jumper (via GitHub)" <gi...@apache.org>.
mike-jumper merged PR #873:
URL: https://github.com/apache/guacamole-client/pull/873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] jmuehlner commented on a diff in pull request #873: GUACAMOLE-926: Fix UTF-8 handling in batch import files.
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner commented on code in PR #873:
URL: https://github.com/apache/guacamole-client/pull/873#discussion_r1199464160
##########
guacamole/src/main/frontend/src/app/import/controllers/importConnectionsController.js:
##########
@@ -693,7 +693,7 @@ angular.module('import').controller('importConnectionsController', ['$scope', '$
});
// Read all the data into memory
- $scope.fileReader.readAsBinaryString(file);
+ $scope.fileReader.readAsText(file);
Review Comment:
This method defaults to a UTF-8 encoding if not otherwise specified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org