You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by hsaputra <gi...@git.apache.org> on 2016/01/05 22:50:31 UTC
[GitHub] flink pull request: [Refactor] [Cleanup] Change bunch of if-else c...
GitHub user hsaputra opened a pull request:
https://github.com/apache/flink/pull/1485
[Refactor] [Cleanup] Change bunch of if-else conditions with swith commands
Change bunch of if-else conditions with swith command to describe better readability and intent.
Switch statement shows intent to have different possible execution based on one value, in this case the "action" variable.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsaputra/flink change_if_to_switch_clifrontend
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1485.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1485
----
commit 71759fc878d984577ff87138f147cf3f55f8658b
Author: Henry Saputra <hs...@apache.org>
Date: 2016-01-05T21:45:14Z
Change bunch of if-else conditions with swith command to describe better readibility and intent.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [Refactor] [Cleanup] Change bunch of if-else c...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1485#issuecomment-169703489
Will merge this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [Refactor] [Cleanup] Change bunch of if-else c...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1485#issuecomment-169661628
Change looks good to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [Refactor] [Cleanup] Change bunch of if-else c...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1485#issuecomment-169761859
Thank you guys =)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [Refactor] [Cleanup] Change bunch of if-else c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1485
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---