You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by chenghao-intel <gi...@git.apache.org> on 2016/03/15 15:00:57 UTC
[GitHub] spark pull request: [SPARK-13895][SQL]Change the return type of Da...
GitHub user chenghao-intel opened a pull request:
https://github.com/apache/spark/pull/11731
[SPARK-13895][SQL]Change the return type of DataFrameReader.text
## What changes were proposed in this pull request?
Change the return type of `DataFrameReader.text` from `DataFrame` to `Dataset[String]`
## How was this patch tested?
No additional unit test required.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chenghao-intel/spark dfreader
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11731.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11731
----
commit be163d6b353fde70565ff962bd3dea391f932120
Author: Cheng Hao <ha...@intel.com>
Date: 2016-03-15T13:58:04Z
change the return type of DataFrameReader.text from DataFrame to Dataset[String]
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13895][SQL]Change the return type of Da...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11731#discussion_r56224944
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -399,7 +399,7 @@ class DataFrameReader private[sql](sqlContext: SQLContext) extends Logging {
}
/**
- * Loads a text file and returns a [[DataFrame]] with a single string column named "value".
+ * Loads a text file and returns a [[Dataset[String]] with a single string column named "value".
--- End diff --
does the `[[Dataset[String]]]` actaully work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13895][SQL]Change the return type of Da...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11731#issuecomment-196883566
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/53197/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13895][SQL]Change the return type of Da...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11731#issuecomment-196883558
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13895][SQL]Change the return type of Da...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11731#issuecomment-196882502
**[Test build #53197 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53197/consoleFull)** for PR 11731 at commit [`be163d6`](https://github.com/apache/spark/commit/be163d6b353fde70565ff962bd3dea391f932120).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13895][SQL]Change the return type of Da...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11731#issuecomment-196834771
**[Test build #53197 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/53197/consoleFull)** for PR 11731 at commit [`be163d6`](https://github.com/apache/spark/commit/be163d6b353fde70565ff962bd3dea391f932120).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13895][SQL]Change the return type of Da...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11731#discussion_r56224899
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -410,10 +410,13 @@ class DataFrameReader private[sql](sqlContext: SQLContext) extends Logging {
* }}}
*
* @param paths input path
- * @since 1.6.0
+ * @since 2.0.0
*/
@scala.annotation.varargs
- def text(paths: String*): DataFrame = format("text").load(paths : _*)
+ def text(paths: String*): Dataset[String] = {
+ import sqlContext.implicits._
+ format("text").load(paths: _*).toDF("value").as[String]
--- End diff --
isn't this just
format("text").load(paths: _*).as[String] ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-13895][SQL]Change the return type of Da...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11731
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org