You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by ad...@apache.org on 2014/05/19 23:09:43 UTC
git commit: [WICKET-5596]
DropDownChoice#wantsOnSelectionChangedNotifications(T) not being called on
unmounted page
Repository: wicket
Updated Branches:
refs/heads/wicket-6.x 3c6c41f19 -> 6dfd3d9d2
[WICKET-5596] DropDownChoice#wantsOnSelectionChangedNotifications(T) not
being called on unmounted page
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/6dfd3d9d
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/6dfd3d9d
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/6dfd3d9d
Branch: refs/heads/wicket-6.x
Commit: 6dfd3d9d2cb7e378275db0458c9d241de8e7e7d8
Parents: 3c6c41f
Author: adelbene <an...@gmail.com>
Authored: Mon May 19 22:24:55 2014 +0200
Committer: adelbene <an...@gmail.com>
Committed: Mon May 19 22:24:55 2014 +0200
----------------------------------------------------------------------
.../org/apache/wicket/markup/html/form/DropDownChoice.java | 6 +-----
.../extensions/yui/calendar/DatesPage1_ExpectedResult.html | 2 +-
2 files changed, 2 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/6dfd3d9d/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
----------------------------------------------------------------------
diff --git a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
index 0db8dc6..1da483a 100644
--- a/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
+++ b/wicket-core/src/main/java/org/apache/wicket/markup/html/form/DropDownChoice.java
@@ -21,8 +21,6 @@ import java.util.List;
import org.apache.wicket.ajax.form.AjaxFormComponentUpdatingBehavior;
import org.apache.wicket.markup.ComponentTag;
import org.apache.wicket.model.IModel;
-import org.apache.wicket.core.request.handler.ListenerInterfaceRequestHandler;
-import org.apache.wicket.core.request.handler.PageAndComponentProvider;
import org.apache.wicket.request.mapper.parameter.PageParameters;
@@ -233,9 +231,7 @@ public class DropDownChoice<T> extends AbstractSingleSelectChoice<T> implements
{
// we do not want relative URL here, because it will be used by
// Form#dispatchEvent
- CharSequence url = urlFor(new ListenerInterfaceRequestHandler(
- new PageAndComponentProvider(getPage(), this, new PageParameters()),
- IOnChangeListener.INTERFACE));
+ CharSequence url = urlFor(IOnChangeListener.INTERFACE, new PageParameters());
Form<?> form = findParent(Form.class);
if (form != null)
http://git-wip-us.apache.org/repos/asf/wicket/blob/6dfd3d9d/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
----------------------------------------------------------------------
diff --git a/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html b/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
index 45bc50e..e32bce0 100644
--- a/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
+++ b/wicket-datetime/src/test/java/org/apache/wicket/extensions/yui/calendar/DatesPage1_ExpectedResult.html
@@ -105,7 +105,7 @@ Wicket.DateTimeInit.CalendarAdd(function() {
</head>
<body>
<form wicket:id="localeForm" id="localeForm2" method="post" action="./org.apache.wicket.extensions.yui.calendar.DatesPage1?0-1.IFormSubmitListener-localeForm"><div style="width:0px;height:0px;position:absolute;left:-100px;top:-100px;overflow:hidden"><input type="hidden" name="localeForm2_hf_0" id="localeForm2_hf_0" /></div>
-<p><select wicket:id="localeSelect" onchange="document.getElementById('localeForm2_hf_0').value='../../page?0-1.IOnChangeListener-localeForm-localeSelect';document.getElementById('localeForm2').submit();" name="localeSelect">
+<p><select wicket:id="localeSelect" onchange="document.getElementById('localeForm2_hf_0').value='./org.apache.wicket.extensions.yui.calendar.DatesPage1?0-1.IOnChangeListener-localeForm-localeSelect';document.getElementById('localeForm2').submit();" name="localeSelect">
<option value="0">cinese (Cina) (Chinese (China))</option>
<option value="1">cinese (Cina) (Chinese (China))</option>
<option value="2">cinese (Cina) (Chinese (China))</option>