You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@polaris.apache.org by ad...@apache.org on 2026/06/26 11:27:46 UTC

(polaris) branch main updated: Remove unused fields in NoSqlMetaStore (#4904)

This is an automated email from the ASF dual-hosted git repository.

adutra pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/polaris.git


The following commit(s) were added to refs/heads/main by this push:
     new ca1ab428d9 Remove unused fields in NoSqlMetaStore (#4904)
ca1ab428d9 is described below

commit ca1ab428d9be4492728dcd17e20e5d8a6b0c0301
Author: Alexandre Dutra <ad...@apache.org>
AuthorDate: Fri Jun 26 13:27:41 2026 +0200

    Remove unused fields in NoSqlMetaStore (#4904)
---
 .../polaris/persistence/nosql/metastore/NoSqlMetaStore.java  | 12 +-----------
 .../nosql/metastore/NoSqlMetaStoreManagerFactory.java        | 12 ++----------
 2 files changed, 3 insertions(+), 21 deletions(-)

diff --git a/persistence/nosql/persistence/metastore/src/main/java/org/apache/polaris/persistence/nosql/metastore/NoSqlMetaStore.java b/persistence/nosql/persistence/metastore/src/main/java/org/apache/polaris/persistence/nosql/metastore/NoSqlMetaStore.java
index ba28cc3035..67edb887a3 100644
--- a/persistence/nosql/persistence/metastore/src/main/java/org/apache/polaris/persistence/nosql/metastore/NoSqlMetaStore.java
+++ b/persistence/nosql/persistence/metastore/src/main/java/org/apache/polaris/persistence/nosql/metastore/NoSqlMetaStore.java
@@ -62,7 +62,6 @@ import java.util.function.Function;
 import java.util.function.Predicate;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
-import org.apache.polaris.core.PolarisDiagnostics;
 import org.apache.polaris.core.entity.AsyncTaskType;
 import org.apache.polaris.core.entity.LocationBasedEntity;
 import org.apache.polaris.core.entity.PolarisBaseEntity;
@@ -91,7 +90,6 @@ import org.apache.polaris.core.persistence.pagination.PageToken;
 import org.apache.polaris.core.policy.PolarisPolicyMappingRecord;
 import org.apache.polaris.core.policy.PolicyMappingUtil;
 import org.apache.polaris.core.policy.PolicyType;
-import org.apache.polaris.core.storage.PolarisStorageIntegrationProvider;
 import org.apache.polaris.core.storage.StorageLocation;
 import org.apache.polaris.persistence.nosql.api.Persistence;
 import org.apache.polaris.persistence.nosql.api.index.Index;
@@ -144,20 +142,12 @@ class NoSqlMetaStore extends NonFunctionalBasePersistence {
 
   private final Persistence persistence;
   private final Privileges privileges;
-  private final PolarisStorageIntegrationProvider storageIntegrationProvider;
   private final MemoizedIndexedAccess memoizedIndexedAccess;
-  private final PolarisDiagnostics diagnostics;
 
-  NoSqlMetaStore(
-      Persistence persistence,
-      Privileges privileges,
-      PolarisStorageIntegrationProvider storageIntegrationProvider,
-      PolarisDiagnostics diagnostics) {
+  NoSqlMetaStore(Persistence persistence, Privileges privileges) {
     this.persistence = persistence;
     this.privileges = privileges;
-    this.storageIntegrationProvider = storageIntegrationProvider;
     this.memoizedIndexedAccess = newMemoizedIndexedAccess(persistence);
-    this.diagnostics = diagnostics;
   }
 
   <REF_OBJ extends ContainerObj, RESULT> RESULT performChange(
diff --git a/persistence/nosql/persistence/metastore/src/main/java/org/apache/polaris/persistence/nosql/metastore/NoSqlMetaStoreManagerFactory.java b/persistence/nosql/persistence/metastore/src/main/java/org/apache/polaris/persistence/nosql/metastore/NoSqlMetaStoreManagerFactory.java
index 63e30a4b7f..2eb850e36f 100644
--- a/persistence/nosql/persistence/metastore/src/main/java/org/apache/polaris/persistence/nosql/metastore/NoSqlMetaStoreManagerFactory.java
+++ b/persistence/nosql/persistence/metastore/src/main/java/org/apache/polaris/persistence/nosql/metastore/NoSqlMetaStoreManagerFactory.java
@@ -39,7 +39,6 @@ import java.util.Map;
 import java.util.Optional;
 import java.util.concurrent.ConcurrentHashMap;
 import org.apache.polaris.core.PolarisCallContext;
-import org.apache.polaris.core.PolarisDiagnostics;
 import org.apache.polaris.core.config.RealmConfig;
 import org.apache.polaris.core.config.RealmConfigurationSource;
 import org.apache.polaris.core.context.RealmContext;
@@ -51,7 +50,6 @@ import org.apache.polaris.core.persistence.cache.EntityCache;
 import org.apache.polaris.core.persistence.dao.entity.BaseResult;
 import org.apache.polaris.core.persistence.dao.entity.PrincipalSecretsResult;
 import org.apache.polaris.core.persistence.metrics.MetricsPersistence;
-import org.apache.polaris.core.storage.PolarisStorageIntegrationProvider;
 import org.apache.polaris.persistence.nosql.api.Persistence;
 import org.apache.polaris.persistence.nosql.api.RealmPersistenceFactory;
 import org.apache.polaris.persistence.nosql.authz.api.Privileges;
@@ -72,9 +70,7 @@ class NoSqlMetaStoreManagerFactory implements MetaStoreManagerFactory {
   private final RealmManagement realmManagement;
   private final RealmPersistenceFactory realmPersistenceFactory;
   private final Privileges privileges;
-  private final PolarisStorageIntegrationProvider storageIntegrationProvider;
   private final Clock clock;
-  private final PolarisDiagnostics diagnostics;
 
   @SuppressWarnings("CdiInjectionPointsInspection")
   @Inject
@@ -82,15 +78,11 @@ class NoSqlMetaStoreManagerFactory implements MetaStoreManagerFactory {
       RealmManagement realmManagement,
       RealmPersistenceFactory realmPersistenceFactory,
       Privileges privileges,
-      PolarisStorageIntegrationProvider storageIntegrationProvider,
-      Clock clock,
-      PolarisDiagnostics diagnostics) {
+      Clock clock) {
     this.realmManagement = realmManagement;
     this.realmPersistenceFactory = realmPersistenceFactory;
     this.privileges = privileges;
-    this.storageIntegrationProvider = storageIntegrationProvider;
     this.clock = clock;
-    this.diagnostics = diagnostics;
   }
 
   @PostConstruct
@@ -155,7 +147,7 @@ class NoSqlMetaStoreManagerFactory implements MetaStoreManagerFactory {
   }
 
   private NoSqlMetaStore newPersistenceMetaStore(Persistence persistence) {
-    return new NoSqlMetaStore(persistence, privileges, storageIntegrationProvider, diagnostics);
+    return new NoSqlMetaStore(persistence, privileges);
   }
 
   private Persistence initializedRealmPersistence(String realmId) {