You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Sean Busbey (Jira)" <ji...@apache.org> on 2020/06/05 14:05:00 UTC

[jira] [Commented] (HBASE-24466) Release scripts in docker mode should be able to use a named volume for maven repo

    [ https://issues.apache.org/jira/browse/HBASE-24466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126793#comment-17126793 ] 

Sean Busbey commented on HBASE-24466:
-------------------------------------

I'm not sure this is going to be worth doing.

With a change in place to put the repository on a volume, on mac os a clean release's first maven install takes basically the same amount of time as when we were using a temporary repo in the build output area with delegated consistency (that's good and expected)

{code}
03:16:42 [INFO] ------------------------------------------------------------------------
03:16:42 [INFO] BUILD SUCCESS
03:16:42 [INFO] ------------------------------------------------------------------------
03:16:42 [INFO] Total time:  18:07 min
03:16:42 [INFO] Finished at: 2020-06-05T03:16:42Z
03:16:42 [INFO] ------------------------------------------------------------------------
{code}

since a full release always reuses a maven repo across the builds in the release that step should be the one where we pay the most cost for downloading things.

with this change the next time I do a release candidate that step is faster (also good and expected)

{code}
13:59:42 [INFO] ------------------------------------------------------------------------
13:59:42 [INFO] BUILD SUCCESS
13:59:42 [INFO] ------------------------------------------------------------------------
13:59:42 [INFO] Total time:  14:45 min
13:59:42 [INFO] Finished at: 2020-06-05T13:59:42Z
13:59:42 [INFO] ------------------------------------------------------------------------
{code}

but it's only a bit over 3 minutes faster. on a total release time of 4.5 hours this doesn't seem necessary.

I'll let the full release keep going. maybe there are more download savings in later steps of the release when different profiles are on. But generally, if this can't save us like a half hour I don't think it's worth it.

> Release scripts in docker mode should be able to use a named volume for maven repo
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-24466
>                 URL: https://issues.apache.org/jira/browse/HBASE-24466
>             Project: HBase
>          Issue Type: Improvement
>          Components: build, community
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Major
>
> Allow optional volume name to use to mount the maven repo so we get reuse of third party artifacts between runs.
> Forcefully remove artifacts we build from it (assuming we can't make a read-only one that's shared for third party dependencies and an isolated one that's for what we're building)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)