You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zjureel <gi...@git.apache.org> on 2017/08/11 05:03:18 UTC
[GitHub] flink pull request #4524: [FLINK-7419] Shade jackson dependency in flink-avr...
GitHub user zjureel opened a pull request:
https://github.com/apache/flink/pull/4524
[FLINK-7419] Shade jackson dependency in flink-avro
## What is the purpose of the change
Shade jackson dependency in flink-avro to avoid incompatible versions
## Brief change log
- *Shade jackson in pom.xml of flink-avro project*
## Verifying this change
*(Please pick either of the following options)*
No test case
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zjureel/flink FLINK-7419
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4524.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4524
----
commit da6ceca91b53e9fac120dfc00219de35927215de
Author: zjureel <zj...@gmail.com>
Date: 2017-08-11T03:35:02Z
[FLINK-7419] Shade jackson dependency in flink-avro
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4524: [FLINK-7419] Shade jackson dependency in flink-avr...
Posted by zjureel <gi...@git.apache.org>.
Github user zjureel closed the pull request at:
https://github.com/apache/flink/pull/4524
---
[GitHub] flink pull request #4524: [FLINK-7419] Shade jackson dependency in flink-avr...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4524#discussion_r132914215
--- Diff: flink-connectors/flink-avro/pom.xml ---
@@ -174,6 +174,35 @@ under the License.
</execution>
</executions>
</plugin>
+
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>shade-flink</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration combine.self="override">
+ <dependencyReducedPomLocation>${project.basedir}/target/dependency-reduced-pom.xml</dependencyReducedPomLocation>
+ <promoteTransitiveDependencies>true</promoteTransitiveDependencies>
+ <artifactSet>
+ <includes>
+ <include>org.codehaus.jackson:*</include>
+ </includes>
+ </artifactSet>
+ <relocations>
+ <relocation>
+ <pattern>org.codehaus.jackson</pattern>
+ <shadedPattern>org.apache.flink.shaded.avro.org.codehouse.jackson</shadedPattern>
--- End diff --
Please switch the pattern to `... avro.shaded....` . I would like to reserver the `org.apache.flink.shaded` namespaces for dependencies from flink-shaded.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4524: [FLINK-7419] Shade jackson dependency in flink-avro
Posted by zjureel <gi...@git.apache.org>.
Github user zjureel commented on the issue:
https://github.com/apache/flink/pull/4524
@zentol Thank you for your review, I have rename the pattern, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4524: [FLINK-7419] Shade jackson dependency in flink-avro
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4524
Merging this...
---
[GitHub] flink issue #4524: [FLINK-7419] Shade jackson dependency in flink-avro
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4524
@zjureel The PR has been merged, could you close the PR?
---