[GitHub] BradHolmes opened a new pull request #3964: [AIRFLOW-3079] Improve migration scripts to support MSSQL Server

[GitBox <gi...@apache.org>]

BradHolmes opened a new pull request #3964: [AIRFLOW-3079] Improve migration scripts to support MSSQL Server
URL: https://github.com/apache/incubator-airflow/pull/3964
 
 
   There were two problems for MSSQL.  First, 'timestamp' data type in MSSQL Server is essentially a row-id,
   and not a timezone enabled date/time stamp.  Second, alembic creates invalid SQL when applying the 0/1 constraint
   to boolean values.  MSSQL should enforce this constrait by simply asserting a boolean value.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses [AIRFLOW-3079](https://issues.apache.org/jira/browse/AIRFLOW-3079)
   
   ### Description
   
   - [x] See commit message.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
     * No tests added as I only adjusted the migration scripts to work for MSSQL.
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
      NONE
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services