You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2020/01/17 06:07:27 UTC
[GitHub] [dubbo] codecov-io commented on issue #5580: [Dubbo-5560] fix useless null check in ServiceConfig

# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5580?src=pr&el=h1) Report
> Merging [#5580](https://codecov.io/gh/apache/dubbo/pull/5580?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/d47c73941278a35952c44839eab8d39644c87122?src=pr&el=desc) will **decrease** coverage by `0.05%`.
> The diff coverage is `71.08%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/5580/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/dubbo/pull/5580?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #5580      +/-   ##
============================================
- Coverage     61.19%   61.14%   -0.06%     
- Complexity      422      423       +1     
============================================
  Files           922      923       +1     
  Lines         37502    37568      +66     
  Branches       5431     5441      +10     
============================================
+ Hits          22951    22972      +21     
- Misses        12068    12100      +32     
- Partials       2483     2496      +13
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5580?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/dubbo/config/ConfigInitializer.java](https://codecov.io/gh/apache/dubbo/pull/5580/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25maWdJbml0aWFsaXplci5qYXZh) | `0% <ø> (ø)` | `0 <0> (?)` | |
| [...in/java/org/apache/dubbo/rpc/ListenableFilter.java](https://codecov.io/gh/apache/dubbo/pull/5580/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9MaXN0ZW5hYmxlRmlsdGVyLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...api/src/main/java/org/apache/dubbo/rpc/Filter.java](https://codecov.io/gh/apache/dubbo/pull/5580/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9GaWx0ZXIuamF2YQ==) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/dubbo/common/BaseServiceMetadata.java](https://codecov.io/gh/apache/dubbo/pull/5580/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQmFzZVNlcnZpY2VNZXRhZGF0YS5qYXZh) | `41.17% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...n/serialize/kryo/optimized/KryoSerialization2.java](https://codecov.io/gh/apache/dubbo/pull/5580/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWtyeW8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbW1vbi9zZXJpYWxpemUva3J5by9vcHRpbWl6ZWQvS3J5b1NlcmlhbGl6YXRpb24yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/dubbo/config/ConfigPostProcessor.java](https://codecov.io/gh/apache/dubbo/pull/5580/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Db25maWdQb3N0UHJvY2Vzc29yLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...protobuf/support/GenericProtobufSerialization.java](https://codecov.io/gh/apache/dubbo/pull/5580/diff?src=pr&el=tree#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLXByb3RvYnVmL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL3Byb3RvYnVmL3N1cHBvcnQvR2VuZXJpY1Byb3RvYnVmU2VyaWFsaXphdGlvbi5qYXZh) | `60% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...main/java/org/apache/dubbo/rpc/AsyncRpcResult.java](https://codecov.io/gh/apache/dubbo/pull/5580/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9Bc3luY1JwY1Jlc3VsdC5qYXZh) | `54.94% <0%> (-1.24%)` | `0 <0> (ø)` | |
| [.../rpc/protocol/dubbo/LazyConnectExchangeClient.java](https://codecov.io/gh/apache/dubbo/pull/5580/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0xhenlDb25uZWN0RXhjaGFuZ2VDbGllbnQuamF2YQ==) | `58.24% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...java/org/apache/dubbo/rpc/model/ConsumerModel.java](https://codecov.io/gh/apache/dubbo/pull/5580/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvQ29uc3VtZXJNb2RlbC5qYXZh) | `58.13% <100%> (+2.32%)` | `0 <0> (ø)` | :arrow_down: |
| ... and [40 more](https://codecov.io/gh/apache/dubbo/pull/5580/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5580?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5580?src=pr&el=footer). Last update [d47c739...ff957f4](https://codecov.io/gh/apache/dubbo/pull/5580?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo/pull/5580 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org