[GitHub] spark pull request #20116: [SPARK-20960][SQL] make ColumnVector public

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20116#discussion_r159227467
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/sources/v2/vectorized/ColumnarBatch.java ---
    @@ -87,19 +79,7 @@ public void remove() {
       }
     
       /**
    -   * Resets the batch for writing.
    -   */
    -  public void reset() {
    -    for (int i = 0; i < numCols(); ++i) {
    -      if (columns[i] instanceof WritableColumnVector) {
    -        ((WritableColumnVector) columns[i]).reset();
    -      }
    -    }
    -    this.numRows = 0;
    --- End diff --
    
    This doesn't matter. The `numRows` is only used when calling `rowsInterator`, and we always call `setNumRows` before calling `rowsIterator`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org