[GitHub] [airflow] TobKed commented on a change in pull request #14554: Remove unnecessary WARNINGs from BeamHook

[GitBox <gi...@apache.org>]

TobKed commented on a change in pull request #14554:
URL: https://github.com/apache/airflow/pull/14554#discussion_r585850683



##########
File path: airflow/providers/apache/beam/hooks/beam.py
##########
@@ -25,7 +25,7 @@
 from typing import Callable, List, Optional
 
 from airflow.exceptions import AirflowException
-from airflow.hooks.base_hook import BaseHook
+from airflow.hooks.base import BaseHook

Review comment:
       If `backport *` jobs on CI are passing I would think backports will work, however I am not 100% sure.

##########
File path: airflow/providers/apache/beam/provider.yaml
##########
@@ -41,6 +41,3 @@ hooks:
   - integration-name: Apache Beam
     python-modules:
       - airflow.providers.apache.beam.hooks.beam
-
-hook-class-names:
-  - airflow.providers.apache.beam.hooks.beam.BeamHook

Review comment:
       Is it not better to add `conn_type`, `conn_name_attr` and `hook_name` to `BeamHook` instead of deleting these lines?
   (e.g in Casssanda: https://github.com/apache/airflow/blob/b34f236eb657553daac855c4b833db37fc3e56ce/airflow/providers/apache/cassandra/hooks/cassandra.py#L86)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org