You are viewing a plain text version of this content. The canonical link for it is here.
Posted to httpclient-users@hc.apache.org by Sandeep Kulkarni <sa...@gmail.com> on 2023/03/10 15:53:42 UTC
Questions for migration of httpclient-win to httpclient5-win
Hi,
I am looking for a migration guide for httpclient-win to httpclient5-win. I
could not find one at
https://hc.apache.org/httpcomponents-client-5.2.x/migration-guide/index.html
Also I am looking for any reason(s) for removal of
WindowsCredentialsProvider from httpclient5-win. Our code uses it and we
are looking for alternatives when we move to v5.
Also why the call to setDefaultCredentialsProvider() was removed. I have
got over the history of the file but could not find any reason mentioned.
https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/client/WinHttpClients.java#L77-L80
vs
https://github.com/apache/httpcomponents-client/blob/master/httpclient5-win/src/main/java/org/apache/hc/client5/http/impl/win/WinHttpClients.java#L66-L67
Regards,
Sandeep Kulkarni
Re: Questions for migration of httpclient-win to httpclient5-win
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Sat, 2023-03-11 at 19:18 +0530, Sandeep Kulkarni wrote:
> Hi Oleg,
>
> Thanks for the explanation. From it I understand that earlier code
> did not
> do anything and it was a mistake to include it.
>
> NTLM authentication is not used anymore, so it can be safely removed.
> However, I don't think removing httpclient5-win entirely makes sense.
> It is
> used by many people like us who want to support Windows
> authentication. So
> please do consider keeping it supported for longer.
>
> Many people have started migrating from v4 or v4.5 of httpclient to
> v5
> recently in the past 1-2 years. Enterprise softwares needs a longer
> support
> timeframe. They will be facing issues going forward. We find
> httpclient to
> be really good for our use case.
>
You are welcome to help us maintain it.
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
For additional commands, e-mail: httpclient-users-help@hc.apache.org
Re: Questions for migration of httpclient-win to httpclient5-win
Posted by Sandeep Kulkarni <sa...@gmail.com>.
Hi,
Based on an earlier comment from Oleg that WindowsCredentialsProvider class
did nothing, I did some experiment with our existing code which still uses
httpclient 4.5.x.
Ours is a Dropwizard based application and we also make use of Jersey
Client. I commented the code below which is used to setup credential
provider.
CredentialsProvider cp = new WindowsCredentialsProvider(new
SystemDefaultCredentialsProvider());
clientConfig.property(ApacheClientProperties.CREDENTIALS_PROVIDER, cp);
Once the code is commented, the authentication is failing. So I am confused
now.
Regards,
Sandeep Kulkarni
On Sun, 12 Mar 2023 at 18:07, Gary Gregory <ga...@gmail.com> wrote:
> Well said Michael! Get some skin in the game ;-)
>
> Gary
>
> On Sun, Mar 12, 2023, 05:52 Michael Osipov <mi...@apache.org> wrote:
>
> > Am 2023-03-11 um 14:48 schrieb Sandeep Kulkarni:
> > > Hi Oleg,
> > >
> > > Thanks for the explanation. From it I understand that earlier code did
> > not
> > > do anything and it was a mistake to include it.
> > >
> > > NTLM authentication is not used anymore, so it can be safely removed.
> > > However, I don't think removing httpclient5-win entirely makes sense.
> It
> > is
> > > used by many people like us who want to support Windows authentication.
> > So
> > > please do consider keeping it supported for longer.
> > >
> > > Many people have started migrating from v4 or v4.5 of httpclient to v5
> > > recently in the past 1-2 years. Enterprise softwares needs a longer
> > support
> > > timeframe. They will be facing issues going forward. We find httpclient
> > to
> > > be really good for our use case.
> >
> > If you need it for your enterprise, support and maintain! Convince your
> > employer to dedicate time to it.
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
> > For additional commands, e-mail: httpclient-users-help@hc.apache.org
> >
> >
>
Re: Questions for migration of httpclient-win to httpclient5-win
Posted by Gary Gregory <ga...@gmail.com>.
Well said Michael! Get some skin in the game ;-)
Gary
On Sun, Mar 12, 2023, 05:52 Michael Osipov <mi...@apache.org> wrote:
> Am 2023-03-11 um 14:48 schrieb Sandeep Kulkarni:
> > Hi Oleg,
> >
> > Thanks for the explanation. From it I understand that earlier code did
> not
> > do anything and it was a mistake to include it.
> >
> > NTLM authentication is not used anymore, so it can be safely removed.
> > However, I don't think removing httpclient5-win entirely makes sense. It
> is
> > used by many people like us who want to support Windows authentication.
> So
> > please do consider keeping it supported for longer.
> >
> > Many people have started migrating from v4 or v4.5 of httpclient to v5
> > recently in the past 1-2 years. Enterprise softwares needs a longer
> support
> > timeframe. They will be facing issues going forward. We find httpclient
> to
> > be really good for our use case.
>
> If you need it for your enterprise, support and maintain! Convince your
> employer to dedicate time to it.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
> For additional commands, e-mail: httpclient-users-help@hc.apache.org
>
>
Re: Questions for migration of httpclient-win to httpclient5-win
Posted by Michael Osipov <mi...@apache.org>.
Am 2023-03-11 um 14:48 schrieb Sandeep Kulkarni:
> Hi Oleg,
>
> Thanks for the explanation. From it I understand that earlier code did not
> do anything and it was a mistake to include it.
>
> NTLM authentication is not used anymore, so it can be safely removed.
> However, I don't think removing httpclient5-win entirely makes sense. It is
> used by many people like us who want to support Windows authentication. So
> please do consider keeping it supported for longer.
>
> Many people have started migrating from v4 or v4.5 of httpclient to v5
> recently in the past 1-2 years. Enterprise softwares needs a longer support
> timeframe. They will be facing issues going forward. We find httpclient to
> be really good for our use case.
If you need it for your enterprise, support and maintain! Convince your
employer to dedicate time to it.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
For additional commands, e-mail: httpclient-users-help@hc.apache.org
Re: Questions for migration of httpclient-win to httpclient5-win
Posted by Sandeep Kulkarni <sa...@gmail.com>.
Hi Oleg,
Thanks for the explanation. From it I understand that earlier code did not
do anything and it was a mistake to include it.
NTLM authentication is not used anymore, so it can be safely removed.
However, I don't think removing httpclient5-win entirely makes sense. It is
used by many people like us who want to support Windows authentication. So
please do consider keeping it supported for longer.
Many people have started migrating from v4 or v4.5 of httpclient to v5
recently in the past 1-2 years. Enterprise softwares needs a longer support
timeframe. They will be facing issues going forward. We find httpclient to
be really good for our use case.
Regards,
Sandeep Kulkarni
On Sat, 11 Mar 2023 at 14:45, Oleg Kalnichevski <ol...@apache.org> wrote:
> On Fri, 2023-03-10 at 21:23 +0530, Sandeep Kulkarni wrote:
> > Hi,
> >
> > I am looking for a migration guide for httpclient-win to httpclient5-
> > win. I
> > could not find one at
> >
> https://hc.apache.org/httpcomponents-client-5.2.x/migration-guide/index.html
> >
> > Also I am looking for any reason(s) for removal of
> > WindowsCredentialsProvider from httpclient5-win. Our code uses it and
> > we
> > are looking for alternatives when we move to v5.
> >
>
> If you look at the source code of the WindowsCredentialsProvider you
> can see that it is basically useless.
>
>
> > Also why the call to setDefaultCredentialsProvider() was removed. I
> > have
> > got over the history of the file but could not find any reason
> > mentioned.
>
> Because one cannot set credentials for the WindowsNegotiateScheme.
> Those credentials would be meaningless. The scheme uses the actual
> credentials of the current system user.
>
> >
> >
> https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/client/WinHttpClients.java#L77-L80
> >
> > vs
> >
> >
> https://github.com/apache/httpcomponents-client/blob/master/httpclient5-win/src/main/java/org/apache/hc/client5/http/impl/win/WinHttpClients.java#L66-L67
> >
> > Regards,
> > Sandeep Kulkarni
>
> Please also note we are going to deprecate `httpclient5-win` and NTLM
> authentication scheme in the coming release (5.3) and remove them
> entirely in 6.0. There is presently no one willing to support this
> scheme.
>
> Oleg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
> For additional commands, e-mail: httpclient-users-help@hc.apache.org
>
>
Re: Questions for migration of httpclient-win to httpclient5-win
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Fri, 2023-03-10 at 21:23 +0530, Sandeep Kulkarni wrote:
> Hi,
>
> I am looking for a migration guide for httpclient-win to httpclient5-
> win. I
> could not find one at
> https://hc.apache.org/httpcomponents-client-5.2.x/migration-guide/index.html
>
> Also I am looking for any reason(s) for removal of
> WindowsCredentialsProvider from httpclient5-win. Our code uses it and
> we
> are looking for alternatives when we move to v5.
>
If you look at the source code of the WindowsCredentialsProvider you
can see that it is basically useless.
> Also why the call to setDefaultCredentialsProvider() was removed. I
> have
> got over the history of the file but could not find any reason
> mentioned.
Because one cannot set credentials for the WindowsNegotiateScheme.
Those credentials would be meaningless. The scheme uses the actual
credentials of the current system user.
>
> https://github.com/apache/httpcomponents-client/blob/4.5.x/httpclient-win/src/main/java/org/apache/http/impl/client/WinHttpClients.java#L77-L80
>
> vs
>
> https://github.com/apache/httpcomponents-client/blob/master/httpclient5-win/src/main/java/org/apache/hc/client5/http/impl/win/WinHttpClients.java#L66-L67
>
> Regards,
> Sandeep Kulkarni
Please also note we are going to deprecate `httpclient5-win` and NTLM
authentication scheme in the coming release (5.3) and remove them
entirely in 6.0. There is presently no one willing to support this
scheme.
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: httpclient-users-unsubscribe@hc.apache.org
For additional commands, e-mail: httpclient-users-help@hc.apache.org