You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ning Zhang <nz...@fb.com> on 2011/10/24 07:20:19 UTC
Review Request: Dynamic partition insert should enforce the order of the
partition spec is the same as the one in schema
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2541/
-----------------------------------------------------------
Review request for hive.
Summary
-------
Suppose the table schema is (a string, b string) partitioned by (p1 string, p2 string), a dynamic partition insert is allowed to:
insert overwrite ... partition (p2="...", p1);
which will create the wrong HDFS directory structure such as /.../p2=.../p1=.... This is contradictory to the metastore's assumption of the HDFS directory structure.
This addresses bug HIVE-2519.
https://issues.apache.org/jira/browse/HIVE-2519
Diffs
-----
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 1188024
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1188024
trunk/ql/src/test/queries/clientnegative/dyn_part4.q PRE-CREATION
trunk/ql/src/test/results/clientnegative/dyn_part4.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/2541/diff
Testing
-------
ant test
Thanks,
Ning
Re: Review Request: Dynamic partition insert should enforce the order of the
partition spec is the same as the one in schema
Posted by Ning Zhang <nz...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2541/
-----------------------------------------------------------
(Updated 2011-10-24 05:25:21.441963)
Review request for hive.
Summary
-------
Suppose the table schema is (a string, b string) partitioned by (p1 string, p2 string), a dynamic partition insert is allowed to:
insert overwrite ... partition (p2="...", p1);
which will create the wrong HDFS directory structure such as /.../p2=.../p1=.... This is contradictory to the metastore's assumption of the HDFS directory structure.
This addresses bug HIVE-2519.
https://issues.apache.org/jira/browse/HIVE-2519
Diffs (updated)
-----
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 1188024
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1188024
trunk/ql/src/test/queries/clientnegative/dyn_part4.q PRE-CREATION
trunk/ql/src/test/results/clientnegative/dyn_part4.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/2541/diff
Testing
-------
ant test
Thanks,
Ning