[GitHub] [kafka] fvaleri commented on a diff in pull request #13127: KAFKA-14586: Moving StreamResetter to tools

["fvaleri (via GitHub)" <gi...@apache.org>]

fvaleri commented on code in PR #13127:
URL: https://github.com/apache/kafka/pull/13127#discussion_r1103828591


##########
checkstyle/import-control.xml:
##########
@@ -475,14 +477,15 @@
       <allow pkg="scala" />
       <allow class="kafka.zk.EmbeddedZookeeper"/>
       <allow pkg="com.fasterxml.jackson" />
+      <allow pkg="org.apache.kafka.tools" />
     </subpackage>
 
     <subpackage name="test">
       <allow pkg="kafka.admin" />
     </subpackage>
 
     <subpackage name="tools">
-      <allow pkg="kafka.tools" />
+      <allow pkg="org.apache.kafka.tools" />

Review Comment:
   This subpackage is not needed if you move StreamsResetterTest to tools test.



##########
build.gradle:
##########
@@ -1790,6 +1790,8 @@ project(':tools') {
 
     implementation libs.jose4j                    // for SASL/OAUTHBEARER JWT validation
     implementation libs.jacksonJaxrsJsonProvider
+    implementation libs.joptSimple

Review Comment:
   This is duplicated and the one below this seems to be unnecessary.



##########
streams/src/test/java/org/apache/kafka/streams/tools/StreamsResetterTest.java:
##########
@@ -16,7 +16,7 @@
  */
 package org.apache.kafka.streams.tools;
 
-import kafka.tools.StreamsResetter;
+import org.apache.kafka.tools.StreamsResetter;

Review Comment:
   I think this test belongs to the tools module, where the class under test lives.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org