You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2010/06/02 02:45:37 UTC

[jira] Created: (HBASE-2651) Allow alternate column separators to be specified for ImportTsv job

Allow alternate column separators to be specified for ImportTsv job
-------------------------------------------------------------------

                 Key: HBASE-2651
                 URL: https://issues.apache.org/jira/browse/HBASE-2651
             Project: HBase
          Issue Type: Improvement
          Components: mapreduce
    Affects Versions: 0.21.0
            Reporter: Todd Lipcon
            Assignee: Todd Lipcon
            Priority: Minor


The version committed in HBASE-1923 only allows TSV files to truly be tab-separated. It's straightforward to make this configurable, so we should!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-2651) Allow alternate column separators to be specified for ImportTsv job

Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875352#action_12875352 ] 

HBase Review Board commented on HBASE-2651:
-------------------------------------------

Message from: "Ryan Rawson" <ry...@gmail.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/116/#review128
-----------------------------------------------------------

Ship it!


- Ryan





> Allow alternate column separators to be specified for ImportTsv job
> -------------------------------------------------------------------
>
>                 Key: HBASE-2651
>                 URL: https://issues.apache.org/jira/browse/HBASE-2651
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>    Affects Versions: 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: hbase-2651.txt
>
>
> The version committed in HBASE-1923 only allows TSV files to truly be tab-separated. It's straightforward to make this configurable, so we should!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-2651) Allow alternate column separators to be specified for ImportTsv job

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HBASE-2651:
-------------------------------

           Status: Resolved  (was: Patch Available)
     Hadoop Flags: [Reviewed]
    Fix Version/s: 0.21.0
       Resolution: Fixed

Committed, thanks for taking a look, Stack.

> Allow alternate column separators to be specified for ImportTsv job
> -------------------------------------------------------------------
>
>                 Key: HBASE-2651
>                 URL: https://issues.apache.org/jira/browse/HBASE-2651
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>    Affects Versions: 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: hbase-2651.txt
>
>
> The version committed in HBASE-1923 only allows TSV files to truly be tab-separated. It's straightforward to make this configurable, so we should!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-2651) Allow alternate column separators to be specified for ImportTsv job

Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875275#action_12875275 ] 

HBase Review Board commented on HBASE-2651:
-------------------------------------------

Message from: "Todd Lipcon" <to...@cloudera.com>


bq.  On 2010-06-03 12:53:48, stack wrote:
bq.  > +1 I reviewed this already but seems like review board lost my review.

really? cuz I just posted it a minute ago :)


- Todd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/116/#review126
-----------------------------------------------------------





> Allow alternate column separators to be specified for ImportTsv job
> -------------------------------------------------------------------
>
>                 Key: HBASE-2651
>                 URL: https://issues.apache.org/jira/browse/HBASE-2651
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>    Affects Versions: 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: hbase-2651.txt
>
>
> The version committed in HBASE-1923 only allows TSV files to truly be tab-separated. It's straightforward to make this configurable, so we should!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-2651) Allow alternate column separators to be specified for ImportTsv job

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HBASE-2651:
-------------------------------

    Status: Patch Available  (was: Open)

> Allow alternate column separators to be specified for ImportTsv job
> -------------------------------------------------------------------
>
>                 Key: HBASE-2651
>                 URL: https://issues.apache.org/jira/browse/HBASE-2651
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>    Affects Versions: 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hbase-2651.txt
>
>
> The version committed in HBASE-1923 only allows TSV files to truly be tab-separated. It's straightforward to make this configurable, so we should!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-2651) Allow alternate column separators to be specified for ImportTsv job

Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HBASE-2651:
-------------------------------

    Attachment: hbase-2651.txt

> Allow alternate column separators to be specified for ImportTsv job
> -------------------------------------------------------------------
>
>                 Key: HBASE-2651
>                 URL: https://issues.apache.org/jira/browse/HBASE-2651
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>    Affects Versions: 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hbase-2651.txt
>
>
> The version committed in HBASE-1923 only allows TSV files to truly be tab-separated. It's straightforward to make this configurable, so we should!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-2651) Allow alternate column separators to be specified for ImportTsv job

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875307#action_12875307 ] 

stack commented on HBASE-2651:
------------------------------

Must have been a pigment of my emancipation (I read the patch last night -- but must not have commented in here, not up on review.hbase.org)

> Allow alternate column separators to be specified for ImportTsv job
> -------------------------------------------------------------------
>
>                 Key: HBASE-2651
>                 URL: https://issues.apache.org/jira/browse/HBASE-2651
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>    Affects Versions: 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: hbase-2651.txt
>
>
> The version committed in HBASE-1923 only allows TSV files to truly be tab-separated. It's straightforward to make this configurable, so we should!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-2651) Allow alternate column separators to be specified for ImportTsv job

Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875272#action_12875272 ] 

HBase Review Board commented on HBASE-2651:
-------------------------------------------

Message from: stack@duboce.net

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/116/#review126
-----------------------------------------------------------

Ship it!


+1 I reviewed this already but seems like review board lost my review.

- stack





> Allow alternate column separators to be specified for ImportTsv job
> -------------------------------------------------------------------
>
>                 Key: HBASE-2651
>                 URL: https://issues.apache.org/jira/browse/HBASE-2651
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>    Affects Versions: 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hbase-2651.txt
>
>
> The version committed in HBASE-1923 only allows TSV files to truly be tab-separated. It's straightforward to make this configurable, so we should!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-2651) Allow alternate column separators to be specified for ImportTsv job

Posted by "HBase Review Board (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12875266#action_12875266 ] 

HBase Review Board commented on HBASE-2651:
-------------------------------------------

Message from: "Todd Lipcon" <to...@cloudera.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/116/
-----------------------------------------------------------

Review request for hbase and Jonathan Gray.


Summary
-------

Pretty self explanatory.


This addresses bug HBASE-2651.
    http://issues.apache.org/jira/browse/HBASE-2651


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java 32ba01d 
  src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsv.java 612b00a 

Diff: http://review.hbase.org/r/116/diff


Testing
-------


Thanks,

Todd




> Allow alternate column separators to be specified for ImportTsv job
> -------------------------------------------------------------------
>
>                 Key: HBASE-2651
>                 URL: https://issues.apache.org/jira/browse/HBASE-2651
>             Project: HBase
>          Issue Type: Improvement
>          Components: mapreduce
>    Affects Versions: 0.21.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hbase-2651.txt
>
>
> The version committed in HBASE-1923 only allows TSV files to truly be tab-separated. It's straightforward to make this configurable, so we should!

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.