[GitHub] [httpcomponents-client] nielsbasjes commented on a change in pull request #174: HTTPCLIENT-2030: Fix PublicSuffixMatcher::getDomainRoot on invalid hostnames

[GitBox <gi...@apache.org>]

nielsbasjes commented on a change in pull request #174: HTTPCLIENT-2030: Fix PublicSuffixMatcher::getDomainRoot on invalid hostnames
URL: https://github.com/apache/httpcomponents-client/pull/174#discussion_r350653508
 
 

 ##########
 File path: httpclient5/src/main/java/org/apache/hc/client5/http/psl/PublicSuffixMatcherLoader.java
 ##########
 @@ -50,7 +50,8 @@
 @Contract(threading = ThreadingBehavior.SAFE)
 public final class PublicSuffixMatcherLoader {
 
-    private static PublicSuffixMatcher load(final InputStream in) throws IOException {
+    public static PublicSuffixMatcher load(final InputStream in) throws IOException {
 
 Review comment:
   I reverted this and used a different solution.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org