You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Coty Sutherland <cs...@apache.org> on 2019/05/08 14:35:49 UTC
The migration guide configuration file difference feature is broken
Hi,
Someone on freenode (CiscoEagle) pointed out to me that the migration
guide's file comparison feature doesn't work :( Looking at the "configure
file differences" section on the 9.0 migration guide (
http://tomcat.apache.org/migration-9.html#Tomcat_9.0.x_configuration_file_differences),
if you click the "view differences" button you get taken to the gitbox web
UI, but it returns a 403. Does anyone have any idea how to fix it? I looked
to see if there was an alternative method to get the diff in the web UI but
I don't see one that allows you to compare files across tags.
Additionally the 8.0.x configuration file differences section is completely
broken (returns a 404) because it tries to use the svn repo for comparison,
which no longer exists. Example:
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/conf/catalina.policy?diff_format=h&r1=1830460&r2=1834688
Thanks,
Coty
Re: The migration guide configuration file difference feature is broken
Posted by Coty Sutherland <cs...@apache.org>.
On Wed, May 8, 2019 at 11:17 AM Mark Thomas <ma...@apache.org> wrote:
> On 08/05/2019 15:35, Coty Sutherland wrote:
> > Hi,
> >
> > Someone on freenode (CiscoEagle) pointed out to me that the migration
> > guide's file comparison feature doesn't work :( Looking at the "configure
> > file differences" section on the 9.0 migration guide (
> >
> http://tomcat.apache.org/migration-9.html#Tomcat_9.0.x_configuration_file_differences
> ),
> > if you click the "view differences" button you get taken to the gitbox
> web
> > UI, but it returns a 403. Does anyone have any idea how to fix it? I
> looked
> > to see if there was an alternative method to get the diff in the web UI
> but
> > I don't see one that allows you to compare files across tags.
>
> The feature has been (hopefully) temporarily disabled by infra due to
> abuse. If there was a way of doing this in GitHub, we could use that.
> I've tried, and failed, to find one.
>
Ah, OK. I tried to find a quick way to do it on GitHub but all I can find
is comparing all files in a tag, like
https://github.com/apache/tomcat/compare/9.0.1...9.0.17. It's really easy
to do in the git CLI, but I don't see an easy way in the web UI.
>
> > Additionally the 8.0.x configuration file differences section is
> completely
> > broken (returns a 404) because it tries to use the svn repo for
> comparison,
> > which no longer exists. Example:
> >
> http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/conf/catalina.policy?diff_format=h&r1=1830460&r2=1834688
>
> That page shouldn't be publicly linked any more but we can fix it to
> point to the new svn location.
>
OK. I can adjust it if you tell me where the new location is :)
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
Re: The migration guide configuration file difference feature is broken
Posted by Konstantin Kolinko <kn...@gmail.com>.
> >>> Looking at the "configure
> >>> file differences" section on the 9.0 migration guide (
> >>> http://tomcat.apache.org/migration-9.html#Tomcat_9.0.x_configuration_file_differences),
> >>> if you click the "view differences" button you get taken to the gitbox web
> >>> UI, but it returns a 403. Does anyone have any idea how to fix it? I looked
> >>> to see if there was an alternative method to get the diff in the web UI but
> >>> I don't see one that allows you to compare files across tags.
> >>
> >> The feature has been (hopefully) temporarily disabled by infra due to
> >> abuse. If there was a way of doing this in GitHub, we could use that.
> >> I've tried, and failed, to find one.
> >
> > I think that one solution is generate a series of diff files and
> > upload the diff files to the Tomcat web site. The web form can be
> > replaces with a static table that links to the diff files.
>
> That is an n-squared problem where n is the number of formally released
> versions. Do we really want to create that many files?
>
> It isn't impossible and it should be easy to script. But still I
> hesitate to start down that road.
I mean just for adjacent pairs (diff N vs N-1). There are not many
changes really.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: The migration guide configuration file difference feature is
broken
Posted by Mark Thomas <ma...@apache.org>.
On 08/05/2019 17:21, Konstantin Kolinko wrote:
> ср, 8 мая 2019 г. в 18:16, Mark Thomas <ma...@apache.org>:
>>
>> On 08/05/2019 15:35, Coty Sutherland wrote:
>>> Hi,
>>>
>>> Someone on freenode (CiscoEagle) pointed out to me that the migration
>>> guide's file comparison feature doesn't work :(
>
> This has already been reported 5-6 times. See the archives.
>
>>> Looking at the "configure
>>> file differences" section on the 9.0 migration guide (
>>> http://tomcat.apache.org/migration-9.html#Tomcat_9.0.x_configuration_file_differences),
>>> if you click the "view differences" button you get taken to the gitbox web
>>> UI, but it returns a 403. Does anyone have any idea how to fix it? I looked
>>> to see if there was an alternative method to get the diff in the web UI but
>>> I don't see one that allows you to compare files across tags.
>>
>> The feature has been (hopefully) temporarily disabled by infra due to
>> abuse. If there was a way of doing this in GitHub, we could use that.
>> I've tried, and failed, to find one.
>
> I think that one solution is generate a series of diff files and
> upload the diff files to the Tomcat web site. The web form can be
> replaces with a static table that links to the diff files.
That is an n-squared problem where n is the number of formally released
versions. Do we really want to create that many files?
It isn't impossible and it should be easy to script. But still I
hesitate to start down that road.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: The migration guide configuration file difference feature is broken
Posted by Konstantin Kolinko <kn...@gmail.com>.
ср, 8 мая 2019 г. в 18:16, Mark Thomas <ma...@apache.org>:
>
> On 08/05/2019 15:35, Coty Sutherland wrote:
> > Hi,
> >
> > Someone on freenode (CiscoEagle) pointed out to me that the migration
> > guide's file comparison feature doesn't work :(
This has already been reported 5-6 times. See the archives.
> > Looking at the "configure
> > file differences" section on the 9.0 migration guide (
> > http://tomcat.apache.org/migration-9.html#Tomcat_9.0.x_configuration_file_differences),
> > if you click the "view differences" button you get taken to the gitbox web
> > UI, but it returns a 403. Does anyone have any idea how to fix it? I looked
> > to see if there was an alternative method to get the diff in the web UI but
> > I don't see one that allows you to compare files across tags.
>
> The feature has been (hopefully) temporarily disabled by infra due to
> abuse. If there was a way of doing this in GitHub, we could use that.
> I've tried, and failed, to find one.
I think that one solution is generate a series of diff files and
upload the diff files to the Tomcat web site. The web form can be
replaces with a static table that links to the diff files.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: The migration guide configuration file difference feature is
broken
Posted by Mark Thomas <ma...@apache.org>.
On 08/05/2019 15:35, Coty Sutherland wrote:
> Hi,
>
> Someone on freenode (CiscoEagle) pointed out to me that the migration
> guide's file comparison feature doesn't work :( Looking at the "configure
> file differences" section on the 9.0 migration guide (
> http://tomcat.apache.org/migration-9.html#Tomcat_9.0.x_configuration_file_differences),
> if you click the "view differences" button you get taken to the gitbox web
> UI, but it returns a 403. Does anyone have any idea how to fix it? I looked
> to see if there was an alternative method to get the diff in the web UI but
> I don't see one that allows you to compare files across tags.
The feature has been (hopefully) temporarily disabled by infra due to
abuse. If there was a way of doing this in GitHub, we could use that.
I've tried, and failed, to find one.
> Additionally the 8.0.x configuration file differences section is completely
> broken (returns a 404) because it tries to use the svn repo for comparison,
> which no longer exists. Example:
> http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/conf/catalina.policy?diff_format=h&r1=1830460&r2=1834688
That page shouldn't be publicly linked any more but we can fix it to
point to the new svn location.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org