You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Henry Saputra <hs...@apache.org> on 2012/04/12 04:09:46 UTC
Review Request: Refactor DefaultRequestPipeline to be eaiser to be
overridden by breaking the long execute method to small protected methods
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4706/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
Refactor DefaultRequestPipeline to be easier to be overridden by breaking the long execute method to small protected methods.
Diffs
-----
trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java 1325046
Diff: https://reviews.apache.org/r/4706/diff
Testing
-------
Pass unit test
Thanks,
Henry
Re: Review Request: Refactor DefaultRequestPipeline to be eaiser to be
overridden by breaking the long execute method to small protected methods
Posted by Henry Saputra <hs...@apache.org>.
> On 2012-04-12 11:21:45, Stanton Sievers wrote:
> > This looks good to me. My only request is that you add some javadoc to each of the protected methods. In addition, having a one-liner for each one of the form "override this method if you want to _______" would be great.
Good idea, will add the Javadoc and comments
- Henry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4706/#review6870
-----------------------------------------------------------
On 2012-04-12 02:09:46, Henry Saputra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4706/
> -----------------------------------------------------------
>
> (Updated 2012-04-12 02:09:46)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Refactor DefaultRequestPipeline to be easier to be overridden by breaking the long execute method to small protected methods.
>
>
> Diffs
> -----
>
> trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java 1325046
>
> Diff: https://reviews.apache.org/r/4706/diff
>
>
> Testing
> -------
>
> Pass unit test
>
>
> Thanks,
>
> Henry
>
>
Re: Review Request: Refactor DefaultRequestPipeline to be eaiser to be
overridden by breaking the long execute method to small protected methods
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4706/#review6870
-----------------------------------------------------------
Ship it!
This looks good to me. My only request is that you add some javadoc to each of the protected methods. In addition, having a one-liner for each one of the form "override this method if you want to _______" would be great.
- Stanton
On 2012-04-12 02:09:46, Henry Saputra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4706/
> -----------------------------------------------------------
>
> (Updated 2012-04-12 02:09:46)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> Refactor DefaultRequestPipeline to be easier to be overridden by breaking the long execute method to small protected methods.
>
>
> Diffs
> -----
>
> trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java 1325046
>
> Diff: https://reviews.apache.org/r/4706/diff
>
>
> Testing
> -------
>
> Pass unit test
>
>
> Thanks,
>
> Henry
>
>
Re: Review Request: Refactor DefaultRequestPipeline to be eaiser to be
overridden by breaking the long execute method to small protected methods
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4706/#review8619
-----------------------------------------------------------
Hey Henry, what's the status of this review? Committed? Not needed?
- Dan Dumont
On April 12, 2012, 2:09 a.m., Henry Saputra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4706/
> -----------------------------------------------------------
>
> (Updated April 12, 2012, 2:09 a.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Refactor DefaultRequestPipeline to be easier to be overridden by breaking the long execute method to small protected methods.
>
>
> Diffs
> -----
>
> trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/DefaultRequestPipeline.java 1325046
>
> Diff: https://reviews.apache.org/r/4706/diff/
>
>
> Testing
> -------
>
> Pass unit test
>
>
> Thanks,
>
> Henry Saputra
>
>