[GitHub] [cordova-plugin-geolocation] sithwarrior commented on issue #189: Variable for Require GPS Hardware

[GitBox <gi...@apache.org>]

sithwarrior commented on issue #189: Variable for Require GPS Hardware
URL: https://github.com/apache/cordova-plugin-geolocation/pull/189#issuecomment-597214568
 
 
   > > why isn't this merged ? this or #171 @breautek
   > 
   > Two main reasons:
   > 
   > 1. Because both PRs introduce preference in a `UPPERCASE_FORMAT`, which doesn't match existing format cordova uses for preferences, which in a `PascalCase` format. I'm hesitate to add inconsitencies.
   > 2. Generally speaking, we need at least two positive votes and 0 negative votes from apache members for a PR to be accepted. So even if I agreed with this PR, I need one more member to review before I can merge.
   
   Actually as @jony89 also states `UPPERCASE_FORMAT` is the norm for this sort of setting, that effects the native build.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org